All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Tvrtko Ursulin <tursulin@ursulin.net>
Cc: "Loïc Molinari" <loic.molinari@collabora.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Jani Nikula" <jani.nikula@linux.intel.com>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"Rob Herring" <robh@kernel.org>,
	"Steven Price" <steven.price@arm.com>,
	"Liviu Dudau" <liviu.dudau@arm.com>,
	"Melissa Wen" <mwen@igalia.com>,
	"Maíra Canal" <mcanal@igalia.com>,
	"Hugh Dickins" <hughd@google.com>,
	"Baolin Wang" <baolin.wang@linux.alibaba.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Al Viro" <viro@zeniv.linux.org.uk>,
	"Mikołaj Wasiak" <mikolaj.wasiak@intel.com>,
	"Christian Brauner" <brauner@kernel.org>,
	"Nitin Gote" <nitin.r.gote@intel.com>,
	"Andi Shyti" <andi.shyti@linux.intel.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Christopher Healy" <healych@amazon.com>,
	"Matthew Wilcox" <willy@infradead.org>,
	"Bagas Sanjaya" <bagasdotme@gmail.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org, linux-mm@kvack.org,
	linux-doc@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH v12 05/10] drm/i915: Use huge tmpfs mountpoint helpers
Date: Fri, 5 Dec 2025 12:32:50 +0100	[thread overview]
Message-ID: <20251205123250.7672fa41@fedora> (raw)
In-Reply-To: <f08c170b-714f-46d0-87fc-3218c42ce93a@ursulin.net>

On Fri, 5 Dec 2025 11:18:39 +0000
Tvrtko Ursulin <tursulin@ursulin.net> wrote:

> On 05/12/2025 09:12, Loïc Molinari wrote:
> > Make use of the new drm_gem_huge_mnt_create() and
> > drm_gem_get_huge_mnt() helpers to avoid code duplication. Now that
> > it's just a few lines long, the single function in i915_gemfs.c is
> > moved into i915_gem_shmem.c.
> > 
> > v3:
> > - use huge tmpfs mountpoint in drm_device
> > - move i915_gemfs.c into i915_gem_shmem.c
> > 
> > v4:
> > - clean up mountpoint creation error handling
> > 
> > v5:
> > - use drm_gem_has_huge_mnt() helper
> > 
> > v7:
> > - include <drm/drm_print.h> in i915_gem_shmem.c
> > 
> > v8:
> > - keep logging notice message with CONFIG_TRANSPARENT_HUGEPAGE=n
> > - don't access huge_mnt field with CONFIG_TRANSPARENT_HUGEPAGE=n
> > 
> > v9:
> > - replace drm_gem_has_huge_mnt() by drm_gem_get_huge_mnt()
> > - remove useless ternary op test in selftests/huge_pages.c
> > 
> > v12:
> > - fix layering violation in selftests (Tvrtko)
> > - fix incorrect filename in commit message  
> 
> Thanks, looks good to me.
> 
> Acked-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
> 
> What are your plans for landing the series? Presumably you'd like to do 
> it in one go via drm-misc-next rather than in stages and different trees?

Yep, ideally this would go through drm-misc-next.

  reply	other threads:[~2025-12-05 11:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-05  9:12 [PATCH v12 00/10] drm: Reduce page tables overhead with THP Loïc Molinari
2025-12-05  9:12 ` [PATCH v12 01/10] drm/shmem-helper: Simplify page offset calculation in fault handler Loïc Molinari
2025-12-05  9:12 ` [PATCH v12 02/10] drm/shmem-helper: Map huge pages " Loïc Molinari
2025-12-05  9:12 ` [PATCH v12 03/10] drm/gem: Introduce drm_gem_get_unmapped_area() fop Loïc Molinari
2025-12-05  9:12 ` [PATCH v12 04/10] drm/gem: Add huge tmpfs mountpoint helpers Loïc Molinari
2025-12-05  9:12 ` [PATCH v12 05/10] drm/i915: Use " Loïc Molinari
2025-12-05 11:18   ` Tvrtko Ursulin
2025-12-05 11:32     ` Boris Brezillon [this message]
2025-12-05  9:12 ` [PATCH v12 06/10] drm/v3d: " Loïc Molinari
2025-12-05  9:12 ` [PATCH v12 07/10] drm/gem: Get rid of *_with_mnt helpers Loïc Molinari
2025-12-05  9:12 ` [PATCH v12 08/10] drm/panthor: Introduce huge tmpfs mountpoint option Loïc Molinari
2025-12-05  9:12 ` [PATCH v12 09/10] drm/panfrost: " Loïc Molinari
2025-12-05  9:12 ` [PATCH v12 10/10] Documentation/gpu/drm-mm: Add THP paragraph to GEM mapping section Loïc Molinari
2025-12-05 13:05 ` ✗ i915.CI.BAT: failure for drm: Reduce page tables overhead with THP Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251205123250.7672fa41@fedora \
    --to=boris.brezillon@collabora.com \
    --cc=airlied@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi.shyti@linux.intel.com \
    --cc=bagasdotme@gmail.com \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=brauner@kernel.org \
    --cc=corbet@lwn.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=healych@amazon.com \
    --cc=hughd@google.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=kernel@collabora.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liviu.dudau@arm.com \
    --cc=loic.molinari@collabora.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mcanal@igalia.com \
    --cc=mikolaj.wasiak@intel.com \
    --cc=mripard@kernel.org \
    --cc=mwen@igalia.com \
    --cc=nitin.r.gote@intel.com \
    --cc=robh@kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=simona@ffwll.ch \
    --cc=steven.price@arm.com \
    --cc=tursulin@ursulin.net \
    --cc=tzimmermann@suse.de \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.