All of lore.kernel.org
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: JaeJoon Jung <rgbi3307@gmail.com>
Cc: SeongJae Park <sj@kernel.org>,
	damon@lists.linux.dev, linux-mm@kvack.org, lienze@kylinos.cn
Subject: Re: [PATCH v3] mm/damon/stat: deduplicate intervals_goal setup in damon_stat_build_ctx()
Date: Fri,  5 Dec 2025 17:50:10 -0800	[thread overview]
Message-ID: <20251206015010.47826-1-sj@kernel.org> (raw)
In-Reply-To: <20251206011716.7185-1-rgbi3307@gmail.com>

On Sat,  6 Dec 2025 10:17:13 +0900 JaeJoon Jung <rgbi3307@gmail.com> wrote:

> The damon_stat_build_ctx() function sets the values of intervals_goal
> structure members.  These values are applied to damon_ctx in
> damon_set_attrs().  However, It is resetting the values that were already
> applied previously to the same values.  I suggest removing this code as it
> constitutes duplicate execution.
> 
> Signed-off-by: JaeJoon Jung <rgbi3307@gmail.com>
> Reviewed-by: Enze Li <lienze@kylinos.cn>

I show Enze did suggest changes [1] to v2 of this patch.  But I don't show Enze
gave Reviewed-by: tag to the patch.  Am I missing something?

[1] https://lore.kernel.org/875xal44lf.fsf@

> Reviewed-by: SeongJae Park <sj@kernel.org>


Thanks,
SJ

[...]

  reply	other threads:[~2025-12-06  1:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-06  1:17 [PATCH v3] mm/damon/stat: deduplicate intervals_goal setup in damon_stat_build_ctx() JaeJoon Jung
2025-12-06  1:50 ` SeongJae Park [this message]
2025-12-06  4:17   ` JaeJoon Jung
2025-12-06  7:58     ` Enze Li
2025-12-06 14:52       ` SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251206015010.47826-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=damon@lists.linux.dev \
    --cc=lienze@kylinos.cn \
    --cc=linux-mm@kvack.org \
    --cc=rgbi3307@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.