From: Rob Herring <robh@kernel.org>
To: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
Cc: Dinh Nguyen <dinguyen@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
Vinod Koul <vkoul@kernel.org>,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: dma: snps,dw-axi-dmac: Add compatible string for Agilex5
Date: Tue, 9 Dec 2025 15:21:52 -0600 [thread overview]
Message-ID: <20251209212152.GA1121752-robh@kernel.org> (raw)
In-Reply-To: <09c56ccbd5b9cfa717c7901ac35d9235458bbc30.1764927089.git.khairul.anuar.romli@altera.com>
On Mon, Dec 08, 2025 at 09:57:42AM +0800, Khairul Anuar Romli wrote:
> The address bus on Agilex5 is limited to 40 bits. When SMMU is enable this
> will cause address truncation and translation faults. Hence introducing
> "altr,agilex5-axi-dma" to enable platform specific configuration to
> configure the dma addressable bit mask.
>
> Add a fallback capability for the compatible property to allow driver to
> probe and initialize with a newly added compatible string without requiring
> additional entry in the driver.
>
> Add dma-ranges to the binding schema to allow specifying DMA address
> mapping between the controller and its parent bus.
>
> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
> ---
> Changes in v2:
> - Add dma-ranges
> ---
> .../bindings/dma/snps,dw-axi-dmac.yaml | 23 +++++++++++++++----
> 1 file changed, 18 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> index a393a33c8908..1a1800d9b544 100644
> --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> @@ -17,11 +17,15 @@ allOf:
>
> properties:
> compatible:
> - enum:
> - - snps,axi-dma-1.01a
> - - intel,kmb-axi-dma
> - - starfive,jh7110-axi-dma
> - - starfive,jh8100-axi-dma
> + oneOf:
> + - enum:
> + - snps,axi-dma-1.01a
> + - intel,kmb-axi-dma
> + - starfive,jh7110-axi-dma
> + - starfive,jh8100-axi-dma
> + - items:
> + - const: altr,agilex5-axi-dma
> + - const: snps,axi-dma-1.01a
>
> reg:
> minItems: 1
> @@ -104,6 +108,15 @@ properties:
> minimum: 1
> maximum: 256
>
> + dma-ranges:
> + description: |
> + Describe memory addresses translation between the DMA address and the
> + CPU address. Each memory region, is declared with 3-6 32-bit cells
> + parameters:
> + - param 1: device base address
> + - param 2: physical base address
> + - param 3: size of the memory region.
No need to generically describe dma-ranges. Just 'dma-ranges: true'
unless you define constaints on the number of entries or want to put
some description about why it is needed here.
> +
> required:
> - compatible
> - reg
> --
> 2.43.7
>
next prev parent reply other threads:[~2025-12-09 21:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-08 1:57 [PATCH v2 0/4] Add Agilex5 AXI DMA support Khairul Anuar Romli
2025-12-08 1:57 ` [PATCH v2 1/4] dt-bindings: dma: snps,dw-axi-dmac: Add compatible string for Agilex5 Khairul Anuar Romli
2025-12-09 21:21 ` Rob Herring [this message]
2025-12-08 1:57 ` [PATCH v2 2/4] dt-bindings: dma: snps,dw-axi-dmac: Add #address-cells and #size-cells Khairul Anuar Romli
2025-12-09 21:26 ` Rob Herring
2025-12-08 1:57 ` [PATCH v2 3/4] arm64: dts: intel: agilex5: Add dma-ranges, address and size cells to dma node Khairul Anuar Romli
2025-12-08 1:57 ` [PATCH v2 4/4] dma: dw-axi-dmac: Add support for Agilex5 and dynamic bus width Khairul Anuar Romli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251209212152.GA1121752-robh@kernel.org \
--to=robh@kernel.org \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=khairul.anuar.romli@altera.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.