From: Steven Rostedt <rostedt@goodmis.org>
To: Thomas Ballasi <tballasi@linux.microsoft.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm: vmscan: add PIDs to vmscan tracepoints
Date: Tue, 9 Dec 2025 22:09:44 -0500 [thread overview]
Message-ID: <20251209220944.6ff1a578@fedora> (raw)
In-Reply-To: <20251208181413.4722-3-tballasi@linux.microsoft.com>
On Mon, 8 Dec 2025 10:14:13 -0800
Thomas Ballasi <tballasi@linux.microsoft.com> wrote:
> ---
> include/trace/events/vmscan.h | 20 ++++++++++++++++----
> 1 file changed, 16 insertions(+), 4 deletions(-)
>
> diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h
> index afc9f80d03f34..eddb4e75e2e23 100644
> --- a/include/trace/events/vmscan.h
> +++ b/include/trace/events/vmscan.h
> @@ -121,18 +121,21 @@ DECLARE_EVENT_CLASS(mm_vmscan_direct_reclaim_begin_template,
> TP_STRUCT__entry(
> __field( int, order )
> __field( unsigned long, gfp_flags )
> + __field( int, pid )
This puts a hole in the ring buffer on 64 bit machines. Please keep pid
next to order as they are both 'int' and not have an "unsigned long"
between the two.
> __field( unsigned short, memcg_id )
> ),
-- Steve
next prev parent reply other threads:[~2025-12-10 3:09 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-08 18:14 [PATCH 0/2] mm: vmscan: add PID and cgroup ID to vmscan tracepoints Thomas Ballasi
2025-12-08 18:14 ` [PATCH 1/2] mm: vmscan: add cgroup IDs " Thomas Ballasi
2025-12-08 18:14 ` [PATCH 2/2] mm: vmscan: add PIDs " Thomas Ballasi
2025-12-10 3:09 ` Steven Rostedt [this message]
2025-12-16 14:02 ` [PATCH v2 0/2] mm: vmscan: add PID and cgroup ID " Thomas Ballasi
2025-12-16 14:02 ` [PATCH v2 1/2] mm: vmscan: add cgroup IDs " Thomas Ballasi
2025-12-16 18:50 ` Shakeel Butt
2025-12-17 22:21 ` Steven Rostedt
2025-12-16 14:02 ` [PATCH v2 2/2] mm: vmscan: add PIDs " Thomas Ballasi
2025-12-16 18:03 ` Steven Rostedt
2025-12-29 10:54 ` Thomas Ballasi
2025-12-29 18:29 ` Steven Rostedt
2025-12-29 21:36 ` Steven Rostedt
2026-01-05 16:04 ` [PATCH v3 0/2] mm: vmscan: add PID and cgroup ID " Thomas Ballasi
2026-01-05 16:04 ` [PATCH v3 1/2] mm: vmscan: add cgroup IDs " Thomas Ballasi
2026-01-05 22:46 ` Shakeel Butt
2026-01-07 18:14 ` Shakeel Butt
2026-01-07 18:32 ` Andrew Morton
2026-01-07 20:35 ` Shakeel Butt
2026-01-07 1:56 ` build error on CONFIG_MEMCG=n "error: invalid use of undefined type 'struct mem_cgroup'" Harry Yoo
2026-01-07 2:17 ` Andrew Morton
2026-01-05 16:04 ` [PATCH v3 2/2] mm: vmscan: add PIDs to vmscan tracepoints Thomas Ballasi
2026-01-06 9:51 ` kernel test robot
2026-01-06 10:13 ` kernel test robot
2026-01-06 2:06 ` [PATCH v3 0/2] mm: vmscan: add PID and cgroup ID " Andrew Morton
2026-01-06 2:21 ` Steven Rostedt
2026-01-15 12:38 ` [PATCH v4 0/3] " Thomas Ballasi
2026-01-15 12:38 ` [PATCH v4 1/3] tracing: Add __event_in_*irq() helpers Thomas Ballasi
2026-01-15 12:38 ` [PATCH v4 2/3] mm: vmscan: add cgroup IDs to vmscan tracepoints Thomas Ballasi
2026-01-15 12:38 ` [PATCH v4 3/3] mm: vmscan: add PIDs " Thomas Ballasi
2026-01-22 18:25 ` [PATCH v5 0/3] mm: vmscan: add PID and cgroup ID " Thomas Ballasi
2026-01-22 18:25 ` [PATCH v5 1/3] tracing: Add __event_in_*irq() helpers Thomas Ballasi
2026-01-22 18:25 ` [PATCH v5 2/3] mm: vmscan: add cgroup IDs to vmscan tracepoints Thomas Ballasi
2026-01-27 23:43 ` Shakeel Butt
2026-01-22 18:25 ` [PATCH v5 3/3] mm: vmscan: add PIDs " Thomas Ballasi
2026-01-22 18:52 ` [PATCH v5 0/3] mm: vmscan: add PID and cgroup ID " Andrew Morton
2026-02-13 18:15 ` [PATCH v6 " Thomas Ballasi
2026-02-13 18:15 ` [PATCH v6 1/3] tracing: Add __event_in_*irq() helpers Thomas Ballasi
2026-02-16 16:13 ` Usama Arif
2026-02-17 0:54 ` Steven Rostedt
2026-02-13 18:15 ` [PATCH v6 2/3] mm: vmscan: add cgroup IDs to vmscan tracepoints Thomas Ballasi
2026-02-13 18:15 ` [PATCH v6 3/3] mm: vmscan: add PIDs " Thomas Ballasi
2026-02-16 16:02 ` Usama Arif
2026-02-23 17:15 ` [PATCH v7 0/3] mm: vmscan: add PID and cgroup ID " Thomas Ballasi
2026-02-23 17:15 ` [PATCH v7 1/3] tracing: Add __event_in_*irq() helpers Thomas Ballasi
2026-02-23 19:33 ` Shakeel Butt
2026-02-23 17:15 ` [PATCH v7 2/3] mm: vmscan: add cgroup IDs to vmscan tracepoints Thomas Ballasi
2026-02-23 19:34 ` Shakeel Butt
2026-02-23 17:15 ` [PATCH v7 3/3] mm: vmscan: add PIDs " Thomas Ballasi
2026-02-23 19:42 ` Shakeel Butt
2026-02-23 23:30 ` Masami Hiramatsu
2026-03-16 16:09 ` [PATCH v8 0/3] mm: vmscan: add PID and cgroup ID " Thomas Ballasi
2026-03-16 16:09 ` [PATCH v8 1/3] tracing: Add __event_in_*irq() helpers Thomas Ballasi
2026-03-16 16:09 ` [PATCH v8 2/3] mm: vmscan: add cgroup IDs to vmscan tracepoints Thomas Ballasi
2026-03-16 16:09 ` [PATCH v8 3/3] mm: vmscan: add PIDs " Thomas Ballasi
2026-03-16 16:46 ` [PATCH v8 0/3] mm: vmscan: add PID and cgroup ID " Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251209220944.6ff1a578@fedora \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=tballasi@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.