All of lore.kernel.org
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
Cc: SeongJae Park <sj@kernel.org>,
	akpm@linux-foundation.org, linux-mm@kvack.org
Subject: Re: [PATCH v2] tools/mm/slabinfo: Fix --partial long option mapping
Date: Tue,  9 Dec 2025 19:17:07 -0800	[thread overview]
Message-ID: <20251210031708.53876-1-sj@kernel.org> (raw)
In-Reply-To: <20251208105240.2719773-1-kaushlendra.kumar@intel.com>

On Mon,  8 Dec 2025 16:22:40 +0530 Kaushlendra Kumar <kaushlendra.kumar@intel.com> wrote:

> The long option "--partial" was incorrectly mapped to lowercase 'p' in
> the opts[] array, but the getopt string and switch case handle uppercase
> 'P'. This mismatch caused --partial to be rejected.
> 
> Fix the long_options mapping to use 'P' so --partial works correctly
> alongside the existing -P short option.

Looks nice finding and fix to me!  I also confirmed the issue exists, and this
patch fixes it.

> 
> Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>

Reviewed-by: SeongJae Park <sj@kernel.org>
Tested-by: SeongJae Park <sj@kernel.org>


Thanks,
SJ

[...]


      reply	other threads:[~2025-12-10  3:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-08 10:52 [PATCH v2] tools/mm/slabinfo: Fix --partial long option mapping Kaushlendra Kumar
2025-12-10  3:17 ` SeongJae Park [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251210031708.53876-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=kaushlendra.kumar@intel.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.