From: Boris Brezillon <boris.brezillon@collabora.com>
To: Tvrtko Ursulin <tursulin@ursulin.net>
Cc: "Loïc Molinari" <loic.molinari@collabora.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Mikołaj Wasiak" <mikolaj.wasiak@intel.com>,
"Andi Shyti" <andi.shyti@linux.intel.com>,
"Christopher Healy" <healych@amazon.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, kernel@collabora.com,
"Chaitanya Kumar Borah" <chaitanya.kumar.borah@intel.com>
Subject: Re: [PATCH] drm/i915: Fix BO alloc flags
Date: Wed, 10 Dec 2025 16:01:50 +0100 [thread overview]
Message-ID: <20251210160150.4dc8f146@fedora> (raw)
In-Reply-To: <ad82a9af-eb79-47ef-a5d3-662cff3c0ee2@ursulin.net>
On Wed, 10 Dec 2025 15:08:02 +0100
Tvrtko Ursulin <tursulin@ursulin.net> wrote:
> On 10/12/2025 12:09, Loïc Molinari wrote:
> > I915_BO_ALLOC_NOTHP must be added to the I915_BO_ALLOC_FLAGS mask in
> > order to pass GEM_BUG_ON() valid flags checks.
> >
> > Reported-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
> > Closes: https://lore.kernel.org/intel-gfx/d73adfa8-d61b-46b3-9385-dde53d8db8ad@intel.com/
> > Fixes: a8a9a590221c ("drm/i915: Use huge tmpfs mountpoint helpers")
> > Suggested-by: Tvrtko Ursulin <tursulin@ursulin.net>
> > Signed-off-by: Loïc Molinari <loic.molinari@collabora.com>
> > ---
> > drivers/gpu/drm/i915/gem/i915_gem_object_types.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object_types.h b/drivers/gpu/drm/i915/gem/i915_gem_object_types.h
> > index f94409e8ec4c..35d4c7d0c579 100644
> > --- a/drivers/gpu/drm/i915/gem/i915_gem_object_types.h
> > +++ b/drivers/gpu/drm/i915/gem/i915_gem_object_types.h
> > @@ -363,6 +363,7 @@ struct drm_i915_gem_object {
> > I915_BO_ALLOC_PM_EARLY | \
> > I915_BO_ALLOC_GPU_ONLY | \
> > I915_BO_ALLOC_CCS_AUX | \
> > + I915_BO_ALLOC_NOTHP | \
> > I915_BO_PREALLOC)
> > #define I915_BO_READONLY BIT(10)
> > #define I915_TILING_QUIRK_BIT 11 /* unknown swizzling; do not release! */
>
> Acked-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
>
> It is passing BAT so I think it is fine to go ahead and merge it. Of
> course via the same branch where the breakage is ie. drm-misc.
Pushed to drm-misc-next.
prev parent reply other threads:[~2025-12-10 15:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-10 11:09 [PATCH] drm/i915: Fix BO alloc flags Loïc Molinari
2025-12-10 13:14 ` ✓ i915.CI.BAT: success for " Patchwork
2025-12-10 14:08 ` [PATCH] " Tvrtko Ursulin
2025-12-10 15:01 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251210160150.4dc8f146@fedora \
--to=boris.brezillon@collabora.com \
--cc=airlied@gmail.com \
--cc=andi.shyti@linux.intel.com \
--cc=chaitanya.kumar.borah@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=healych@amazon.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.molinari@collabora.com \
--cc=mikolaj.wasiak@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.