From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: cem@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: validate that zoned RT devices are zone aligned
Date: Wed, 10 Dec 2025 11:18:25 -0800 [thread overview]
Message-ID: <20251210191825.GD7725@frogsfrogsfrogs> (raw)
In-Reply-To: <20251210165438.GA9489@lst.de>
On Wed, Dec 10, 2025 at 05:54:38PM +0100, Christoph Hellwig wrote:
> On Wed, Dec 10, 2025 at 08:48:59AM -0800, Darrick J. Wong wrote:
> > mkfs doesn't enforce that when you're creating a zoned filesystem on
> > non-zoned storage:
> ...
> > (The mkfs enforcement does work if you have an actual zoned storage
> > device since mkfs complains about changes in the zone sizes.)
>
> Ugg, and I thought only my horrible hacks caused that..
>
> >
> > > to avoid getting into trouble due to fuzzers or mkfs bugs.
> > >
> > > Fixes: 2167eaabe2fa ("xfs: define the zoned on-disk format")
> > > Signed-off-by: Christoph Hellwig <hch@lst.de>
> >
> > How many filesystems are there in the wild with rump rtgroups?
>
> I suspect very, very few as zoned mode on non-zoned devices is not a
> widely advertised feature, and then you'd also need wiredly sized device
> or manual override to get it. And then scrub would complain about it.
<nod>
> > Given that runt zoned rtgroups can exist in the wild, how hard would it
> > be to fix zonegc?
>
> Very nasty. We can't ever GC into one.
How nasty is it, exactly? AFAICT,
* The zone targetting code (aka the zone we copy into) then has to
know to avoid a runt endzone?
* Thresholding gets weird because they don't apply right to the runt
zone, which means the victim selection is also off.
* The code that reserves zones for gc or other ENOSPC handling then has
to ensure it never picks a runt zone to avoid corner case problems
Any other reasons? Given that zoned is still experimental I think I'm
ok with adding this restriction, but only after some more thorough
understanding. :)
Also does growfs need patching so that it doesn't create a runt zone?
--D
next prev parent reply other threads:[~2025-12-10 19:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-10 14:23 [PATCH] xfs: validate that zoned RT devices are zone aligned Christoph Hellwig
2025-12-10 16:48 ` Darrick J. Wong
2025-12-10 16:54 ` Christoph Hellwig
2025-12-10 19:18 ` Darrick J. Wong [this message]
2025-12-11 5:04 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251210191825.GD7725@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=cem@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.