From: Al Viro <viro@zeniv.linux.org.uk>
To: Mateusz Guzik <mjguzik@gmail.com>
Cc: syzbot <syzbot+d222f4b7129379c3d5bc@syzkaller.appspotmail.com>,
brauner@kernel.org, jack@suse.cz, jlbec@evilplan.org,
joseph.qi@linux.alibaba.com, linkinjeon@kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
mark@fasheh.com, ocfs2-devel@lists.linux.dev,
sj1557.seo@samsung.com, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [exfat?] [ocfs2?] kernel BUG in link_path_walk
Date: Wed, 10 Dec 2025 21:47:30 +0000 [thread overview]
Message-ID: <20251210214730.GC1712166@ZenIV> (raw)
In-Reply-To: <ff7k3zlpiueyyykotdpfcaoxn2tukceoqcbmfdwjfolndy4sen@3f5r362sg67g>
#syz test
commit 9c7d3d572d0a67484e9cbe178184cfd9a89aa430
Author: Al Viro <viro@zeniv.linux.org.uk>
Date: Wed Dec 10 16:44:53 2025 -0500
Revert "ocfs2: mark inode bad upon validation failure during read"
This reverts commit 58b6fcd2ab34399258dc509f701d0986a8e0bcaa.
You can't use make_bad_inode() on live inodes.
diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c
index 8340525e5589..53d649436017 100644
--- a/fs/ocfs2/inode.c
+++ b/fs/ocfs2/inode.c
@@ -1708,8 +1708,6 @@ int ocfs2_read_inode_block_full(struct inode *inode, struct buffer_head **bh,
rc = ocfs2_read_blocks(INODE_CACHE(inode), OCFS2_I(inode)->ip_blkno,
1, &tmp, flags, ocfs2_validate_inode_block);
- if (rc < 0)
- make_bad_inode(inode);
/* If ocfs2_read_blocks() got us a new bh, pass it up. */
if (!rc && !*bh)
*bh = tmp;
next prev parent reply other threads:[~2025-12-10 21:47 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 0:07 [syzbot] [exfat?] [ocfs2?] kernel BUG in link_path_walk syzbot
2025-12-04 0:46 ` Mateusz Guzik
2025-12-04 1:21 ` syzbot
2025-12-04 7:45 ` Mateusz Guzik
2025-12-04 8:21 ` Al Viro
2025-12-04 8:40 ` Mateusz Guzik
2025-12-10 9:45 ` [PATCH for 6.19-rc1] fs: preserve file type in make_bad_inode() unless invalid Tetsuo Handa
2025-12-10 10:09 ` Jan Kara
2025-12-10 10:24 ` Mateusz Guzik
2025-12-10 21:14 ` Al Viro
2025-12-10 23:27 ` Mateusz Guzik
2026-01-06 10:10 ` Tetsuo Handa
2026-01-07 9:36 ` Jan Kara
2026-01-07 9:53 ` Tetsuo Handa
2026-01-07 10:15 ` Jan Kara
2025-12-10 10:09 ` Mateusz Guzik
2025-12-10 15:35 ` Al Viro
2025-12-10 20:43 ` Al Viro
2025-12-10 20:55 ` Al Viro
2025-12-10 21:33 ` Al Viro
2025-12-04 9:09 ` [syzbot] [exfat?] [ocfs2?] kernel BUG in link_path_walk Mateusz Guzik
2025-12-04 10:13 ` syzbot
2025-12-04 10:15 ` Mateusz Guzik
2025-12-04 11:56 ` syzbot
2025-12-04 11:58 ` Mateusz Guzik
2025-12-10 11:00 ` Mateusz Guzik
2025-12-10 11:19 ` syzbot
2025-12-10 11:28 ` Mateusz Guzik
2025-12-10 19:44 ` Mateusz Guzik
2025-12-10 20:06 ` syzbot
2025-12-10 21:47 ` Al Viro [this message]
2025-12-10 22:09 ` syzbot
2025-12-11 9:00 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251210214730.GC1712166@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=jlbec@evilplan.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linkinjeon@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=mjguzik@gmail.com \
--cc=ocfs2-devel@lists.linux.dev \
--cc=sj1557.seo@samsung.com \
--cc=syzbot+d222f4b7129379c3d5bc@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.