From: kernel test robot <lkp@intel.com>
To: "Frank Li" <Frank.Li@nxp.com>, "Vinod Koul" <vkoul@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Bjorn Helgaas" <helgaas@kernel.org>,
"Christoph Hellwig" <hch@lst.de>,
"Sagi Grimberg" <sagi@grimberg.me>,
"Chaitanya Kulkarni" <kch@nvidia.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
"Koichiro Den" <den@valinux.co.jp>,
"Niklas Cassel" <cassel@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev, netdev@vger.kernel.org,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, linux-nvme@lists.infradead.org,
mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,
Frank Li <Frank.Li@nxp.com>
Subject: Re: [PATCH 6/8] nvmet: pci-epf: Use dmaengine_prep_slave_single_config() API
Date: Thu, 11 Dec 2025 03:05:08 +0800 [thread overview]
Message-ID: <202512110249.kCiMC4sb-lkp@intel.com> (raw)
In-Reply-To: <20251208-dma_prep_config-v1-6-53490c5e1e2a@nxp.com>
Hi Frank,
kernel test robot noticed the following build warnings:
[auto build test WARNING on bc04acf4aeca588496124a6cf54bfce3db327039]
url: https://github.com/intel-lab-lkp/linux/commits/Frank-Li/dmaengine-Add-API-to-combine-configuration-and-preparation-sg-and-single/20251209-011820
base: bc04acf4aeca588496124a6cf54bfce3db327039
patch link: https://lore.kernel.org/r/20251208-dma_prep_config-v1-6-53490c5e1e2a%40nxp.com
patch subject: [PATCH 6/8] nvmet: pci-epf: Use dmaengine_prep_slave_single_config() API
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20251211/202512110249.kCiMC4sb-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251211/202512110249.kCiMC4sb-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512110249.kCiMC4sb-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/nvme/target/pci-epf.c: In function 'nvmet_pci_epf_dma_transfer':
>> drivers/nvme/target/pci-epf.c:369:23: warning: variable 'lock' set but not used [-Wunused-but-set-variable]
369 | struct mutex *lock;
| ^~~~
vim +/lock +369 drivers/nvme/target/pci-epf.c
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 357
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 358 static int nvmet_pci_epf_dma_transfer(struct nvmet_pci_epf *nvme_epf,
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 359 struct nvmet_pci_epf_segment *seg, enum dma_data_direction dir)
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 360 {
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 361 struct pci_epf *epf = nvme_epf->epf;
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 362 struct dma_async_tx_descriptor *desc;
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 363 struct dma_slave_config sconf = {};
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 364 struct device *dev = &epf->dev;
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 365 struct device *dma_dev;
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 366 struct dma_chan *chan;
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 367 dma_cookie_t cookie;
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 368 dma_addr_t dma_addr;
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 @369 struct mutex *lock;
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 370 int ret;
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 371
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 372 switch (dir) {
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 373 case DMA_FROM_DEVICE:
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 374 lock = &nvme_epf->dma_rx_lock;
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 375 chan = nvme_epf->dma_rx_chan;
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 376 sconf.direction = DMA_DEV_TO_MEM;
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 377 sconf.src_addr = seg->pci_addr;
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 378 break;
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 379 case DMA_TO_DEVICE:
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 380 lock = &nvme_epf->dma_tx_lock;
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 381 chan = nvme_epf->dma_tx_chan;
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 382 sconf.direction = DMA_MEM_TO_DEV;
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 383 sconf.dst_addr = seg->pci_addr;
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 384 break;
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 385 default:
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 386 return -EINVAL;
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 387 }
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 388
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 389 dma_dev = dmaengine_get_dma_device(chan);
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 390 dma_addr = dma_map_single(dma_dev, seg->buf, seg->length, dir);
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 391 ret = dma_mapping_error(dma_dev, dma_addr);
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 392 if (ret)
f9f42a84df49d9 Frank Li 2025-12-08 393 return ret;
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 394
f9f42a84df49d9 Frank Li 2025-12-08 395 desc = dmaengine_prep_slave_single_config(chan, dma_addr, seg->length,
f9f42a84df49d9 Frank Li 2025-12-08 396 sconf.direction,
f9f42a84df49d9 Frank Li 2025-12-08 397 DMA_CTRL_ACK,
f9f42a84df49d9 Frank Li 2025-12-08 398 &sconf);
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 399 if (!desc) {
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 400 dev_err(dev, "Failed to prepare DMA\n");
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 401 ret = -EIO;
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 402 goto unmap;
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 403 }
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 404
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 405 cookie = dmaengine_submit(desc);
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 406 ret = dma_submit_error(cookie);
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 407 if (ret) {
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 408 dev_err(dev, "Failed to do DMA submit (err=%d)\n", ret);
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 409 goto unmap;
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 410 }
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 411
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 412 if (dma_sync_wait(chan, cookie) != DMA_COMPLETE) {
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 413 dev_err(dev, "DMA transfer failed\n");
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 414 ret = -EIO;
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 415 }
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 416
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 417 unmap:
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 418 dma_unmap_single(dma_dev, dma_addr, seg->length, dir);
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 419
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 420 return ret;
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 421 }
0faa0fe6f90ea5 Damien Le Moal 2025-01-04 422
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-12-10 19:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-08 17:09 [PATCH 0/8] dmaengine: Add new API to combine onfiguration and descriptor preparation Frank Li
2025-12-08 17:09 ` [PATCH 1/8] dmaengine: Add API to combine configuration and preparation (sg and single) Frank Li
2025-12-09 6:38 ` Christoph Hellwig
2025-12-09 15:47 ` Frank Li
2025-12-10 22:55 ` Bjorn Helgaas
2025-12-08 17:09 ` [PATCH 2/8] PCI: endpoint: pci-epf-test: use new DMA API to simple code Frank Li
2025-12-10 22:50 ` Bjorn Helgaas
2025-12-08 17:09 ` [PATCH 3/8] dmaengine: dw-edma: Use new .device_prep_slave_sg_config() callback Frank Li
2025-12-08 17:09 ` [PATCH 4/8] dmaengine: dw-edma: Pass dma_slave_config to dw_edma_device_transfer() Frank Li
2025-12-08 17:09 ` [PATCH 5/8] nvmet: pci-epf: Remove unnecessary dmaengine_terminate_sync() on each DMA transfer Frank Li
2025-12-09 6:52 ` Damien Le Moal
2025-12-09 15:44 ` Frank Li
2025-12-08 17:09 ` [PATCH 6/8] nvmet: pci-epf: Use dmaengine_prep_slave_single_config() API Frank Li
2025-12-09 6:38 ` Christoph Hellwig
2025-12-10 19:05 ` kernel test robot [this message]
2025-12-10 22:54 ` Bjorn Helgaas
2025-12-08 17:09 ` [PATCH 7/8] PCI: epf-mhi:Using new API dmaengine_prep_slave_single_config() to simple code Frank Li
2025-12-10 22:53 ` Bjorn Helgaas
2025-12-08 17:09 ` [PATCH 8/8] crypto: atmel: Use dmaengine_prep_slave_single_config() API Frank Li
2025-12-10 23:38 ` kernel test robot
2025-12-09 7:20 ` [PATCH 0/8] dmaengine: Add new API to combine onfiguration and descriptor preparation Niklas Cassel
2025-12-16 12:45 ` Vinod Koul
2025-12-16 15:10 ` Frank Li
2025-12-16 15:43 ` Vinod Koul
2025-12-16 15:55 ` Frank Li
2025-12-16 17:17 ` Vinod Koul
2025-12-16 17:28 ` Frank Li
2025-12-17 5:10 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202512110249.kCiMC4sb-lkp@intel.com \
--to=lkp@intel.com \
--cc=Frank.Li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=cassel@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=davem@davemloft.net \
--cc=den@valinux.co.jp \
--cc=dmaengine@vger.kernel.org \
--cc=hch@lst.de \
--cc=helgaas@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=imx@lists.linux.dev \
--cc=kch@nvidia.com \
--cc=kishon@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mhi@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=sagi@grimberg.me \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.