All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: cros-kernel-buildreports@googlegroups.com
Cc: oe-kbuild-all@lists.linux.dev
Subject: [android-common:android15-6.6 0/1] fs/binfmt_misc.c:95: warning: Excess function parameter 'misc' description in 'search_binfmt_handler'
Date: Thu, 11 Dec 2025 03:16:06 +0800	[thread overview]
Message-ID: <202512110306.NEASEgZ6-lkp@intel.com> (raw)

Hi Christian,

FYI, the error/warning still remains.

tree:   https://android.googlesource.com/kernel/common android15-6.6
head:   eed7f8d4a5572c294712b683d6b4890a3b5e1267
commit: 5ee7df8143c1bf81086dda152b05883ccb0b09da [0/1] binfmt_misc: cleanup on filesystem umount
config: i386-randconfig-015-20251210 (https://download.01.org/0day-ci/archive/20251211/202512110306.NEASEgZ6-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251211/202512110306.NEASEgZ6-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512110306.NEASEgZ6-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> fs/binfmt_misc.c:95: warning: Excess function parameter 'misc' description in 'search_binfmt_handler'
   fs/binfmt_misc.c:144: warning: Excess function parameter 'misc' description in 'get_binfmt_handler'
   fs/binfmt_misc.c:681: warning: Excess function parameter 'misc' description in 'remove_binfmt_handler'


vim +95 fs/binfmt_misc.c

bbaecc088245e8 Mike Frysinger    2014-10-13   83  
5ee7df8143c1bf Christian Brauner 2021-10-28   84  /**
5ee7df8143c1bf Christian Brauner 2021-10-28   85   * search_binfmt_handler - search for a binary handler for @bprm
5ee7df8143c1bf Christian Brauner 2021-10-28   86   * @misc: handle to binfmt_misc instance
5ee7df8143c1bf Christian Brauner 2021-10-28   87   * @bprm: binary for which we are looking for a handler
5ee7df8143c1bf Christian Brauner 2021-10-28   88   *
5ee7df8143c1bf Christian Brauner 2021-10-28   89   * Search for a binary type handler for @bprm in the list of registered binary
5ee7df8143c1bf Christian Brauner 2021-10-28   90   * type handlers.
5ee7df8143c1bf Christian Brauner 2021-10-28   91   *
5ee7df8143c1bf Christian Brauner 2021-10-28   92   * Return: binary type list entry on success, NULL on failure
^1da177e4c3f41 Linus Torvalds    2005-04-16   93   */
5ee7df8143c1bf Christian Brauner 2021-10-28   94  static Node *search_binfmt_handler(struct linux_binprm *bprm)
^1da177e4c3f41 Linus Torvalds    2005-04-16  @95  {
^1da177e4c3f41 Linus Torvalds    2005-04-16   96  	char *p = strrchr(bprm->interp, '.');
5ee7df8143c1bf Christian Brauner 2021-10-28   97  	Node *e;
^1da177e4c3f41 Linus Torvalds    2005-04-16   98  
6b899c4e9a049d Mike Frysinger    2014-12-10   99  	/* Walk all the registered handlers. */
5ee7df8143c1bf Christian Brauner 2021-10-28  100  	list_for_each_entry(e, &entries, list) {
^1da177e4c3f41 Linus Torvalds    2005-04-16  101  		char *s;
^1da177e4c3f41 Linus Torvalds    2005-04-16  102  		int j;
^1da177e4c3f41 Linus Torvalds    2005-04-16  103  
6b899c4e9a049d Mike Frysinger    2014-12-10  104  		/* Make sure this one is currently enabled. */
^1da177e4c3f41 Linus Torvalds    2005-04-16  105  		if (!test_bit(Enabled, &e->flags))
^1da177e4c3f41 Linus Torvalds    2005-04-16  106  			continue;
^1da177e4c3f41 Linus Torvalds    2005-04-16  107  
6b899c4e9a049d Mike Frysinger    2014-12-10  108  		/* Do matching based on extension if applicable. */
^1da177e4c3f41 Linus Torvalds    2005-04-16  109  		if (!test_bit(Magic, &e->flags)) {
^1da177e4c3f41 Linus Torvalds    2005-04-16  110  			if (p && !strcmp(e->magic, p + 1))
^1da177e4c3f41 Linus Torvalds    2005-04-16  111  				return e;
^1da177e4c3f41 Linus Torvalds    2005-04-16  112  			continue;
^1da177e4c3f41 Linus Torvalds    2005-04-16  113  		}
^1da177e4c3f41 Linus Torvalds    2005-04-16  114  
6b899c4e9a049d Mike Frysinger    2014-12-10  115  		/* Do matching based on magic & mask. */
^1da177e4c3f41 Linus Torvalds    2005-04-16  116  		s = bprm->buf + e->offset;
^1da177e4c3f41 Linus Torvalds    2005-04-16  117  		if (e->mask) {
^1da177e4c3f41 Linus Torvalds    2005-04-16  118  			for (j = 0; j < e->size; j++)
^1da177e4c3f41 Linus Torvalds    2005-04-16  119  				if ((*s++ ^ e->magic[j]) & e->mask[j])
^1da177e4c3f41 Linus Torvalds    2005-04-16  120  					break;
^1da177e4c3f41 Linus Torvalds    2005-04-16  121  		} else {
^1da177e4c3f41 Linus Torvalds    2005-04-16  122  			for (j = 0; j < e->size; j++)
^1da177e4c3f41 Linus Torvalds    2005-04-16  123  				if ((*s++ ^ e->magic[j]))
^1da177e4c3f41 Linus Torvalds    2005-04-16  124  					break;
^1da177e4c3f41 Linus Torvalds    2005-04-16  125  		}
^1da177e4c3f41 Linus Torvalds    2005-04-16  126  		if (j == e->size)
^1da177e4c3f41 Linus Torvalds    2005-04-16  127  			return e;
^1da177e4c3f41 Linus Torvalds    2005-04-16  128  	}
5ee7df8143c1bf Christian Brauner 2021-10-28  129  
^1da177e4c3f41 Linus Torvalds    2005-04-16  130  	return NULL;
^1da177e4c3f41 Linus Torvalds    2005-04-16  131  }
^1da177e4c3f41 Linus Torvalds    2005-04-16  132  

:::::: The code at line 95 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2025-12-10 19:16 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202512110306.NEASEgZ6-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=cros-kernel-buildreports@googlegroups.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.