From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 081ABD41C09 for ; Thu, 11 Dec 2025 09:17:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id CA69084D48; Thu, 11 Dec 2025 09:17:03 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id DrU9XKlHs3F7; Thu, 11 Dec 2025 09:17:01 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org C61FC84D1A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1765444621; bh=uNg4F6k/RPBTY81QVwC0LvyuJ4LEYcF026qfDZof6vc=; h=From:To:CC:Date:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=Vr3S+l7l0H0vnMFqJ+0FU3IxszvtBmUmE7Mdf/8L8HZI/Ta5iygnAll5gGOBXRKX/ vxwmqem3bOBjZdNgB4zFnAnmoeVJInHeggBXqP4cVaYqxj4JfEyyQfm5mYc/Y4OfFj NF8pMe7rssJt4WeC9Kx21kYJ3QXGvFRwp/YgfaOSdIUTk//XZpYBzNIrsJKLVgh3TW XUouNruU1f+hB/Xt2cAF9FNwboO43rPZUek7ABJVCftws51RXy8SYUSfj7zBmNyG/5 tiCwcfoZV18kOtMujn4eZQdddNVIY6S3ymqaGEA8urHJd31ztWNGYkzm1l/8ppqTyi /UdDMUgFpPYtw== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id C61FC84D1A; Thu, 11 Dec 2025 09:17:01 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists1.osuosl.org (Postfix) with ESMTP id 54EA32E9 for ; Thu, 11 Dec 2025 09:17:00 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 180BC408FD for ; Thu, 11 Dec 2025 09:16:58 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id BvIwEACYRSBm for ; Thu, 11 Dec 2025 09:16:57 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=50.112.246.219; helo=pdx-out-015.esa.us-west-2.outbound.mail-perimeter.amazon.com; envelope-from=prvs=43358fca2=enjuk@amazon.co.jp; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 2982B408CE DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 2982B408CE Received: from pdx-out-015.esa.us-west-2.outbound.mail-perimeter.amazon.com (pdx-out-015.esa.us-west-2.outbound.mail-perimeter.amazon.com [50.112.246.219]) by smtp4.osuosl.org (Postfix) with ESMTPS id 2982B408CE for ; Thu, 11 Dec 2025 09:16:56 +0000 (UTC) X-CSE-ConnectionGUID: QlD+MqTGRSK10CPQW1szGw== X-CSE-MsgGUID: rhJr8kBrQL6HS8tWaynf+w== X-IronPort-AV: E=Sophos;i="6.20,265,1758585600"; d="scan'208";a="8701028" Received: from ip-10-5-12-219.us-west-2.compute.internal (HELO smtpout.naws.us-west-2.prod.farcaster.email.amazon.dev) ([10.5.12.219]) by internal-pdx-out-015.esa.us-west-2.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2025 09:16:54 +0000 Received: from EX19MTAUWC002.ant.amazon.com [205.251.233.51:32106] by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.59.230:2525] with esmtp (Farcaster) id 02d555f5-35a8-4aa8-b756-0cb42fc2d65d; Thu, 11 Dec 2025 09:16:53 +0000 (UTC) X-Farcaster-Flow-ID: 02d555f5-35a8-4aa8-b756-0cb42fc2d65d Received: from EX19D001UWA001.ant.amazon.com (10.13.138.214) by EX19MTAUWC002.ant.amazon.com (10.250.64.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.29; Thu, 11 Dec 2025 09:16:53 +0000 Received: from b0be8375a521.amazon.com (10.37.245.7) by EX19D001UWA001.ant.amazon.com (10.13.138.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.29; Thu, 11 Dec 2025 09:16:51 +0000 From: Kohei Enju To: , CC: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , "Jakub Kicinski" , Paolo Abeni , "Jedrzej Jagielski" , Stefan Wegrzyn , Simon Horman , Jacob Keller , , Kohei Enju Date: Thu, 11 Dec 2025 18:15:30 +0900 Message-ID: <20251211091636.57722-1-enjuk@amazon.com> X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.37.245.7] X-ClientProxiedBy: EX19D040UWB002.ant.amazon.com (10.13.138.89) To EX19D001UWA001.ant.amazon.com (10.13.138.214) X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2; t=1765444617; x=1796980617; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=uNg4F6k/RPBTY81QVwC0LvyuJ4LEYcF026qfDZof6vc=; b=tPk7FuiU4VdXXIuqSLc72Yk9IQB09sB2g9Q6wBBl2f6EoGaWYa4SSJ0P M26bALVnHCO49vgMeewMq5mZVDns2xgf6nvJSfva2gj83iNl8qC/WX5eG 1YuiPkZaB/nuolpeX1yR/6K3vvTcKBwgMLJ+rRQ8EsGFhIw0f2wgrhahk HgHhz5SVeNHzVU10Wit41+H0OqQKFQL+EGk+9qBNXwFwhQhJ9E2OnFDUw ETBeUa2xOLyRzDXUD7LaRRMDrnXW6oi9qdVb1H+6kd+ex1vOMVdXDeBgL Xi+CHrUAhTN66bp1VlVGuadcnbAjJZz+jB0526IOl/Izhl1darD7XCvth w==; X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=amazon.com header.i=@amazon.com header.a=rsa-sha256 header.s=amazoncorp2 header.b=tPk7FuiU Subject: [Intel-wired-lan] [PATCH iwl-net v2 0/2] ixgbe: fix issues around ixgbe_recovery_probe() X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" ixgbe_recovery_probe() and codes around this function have two bugs: 1. resource freeing up is not complete, resulting in memory leaks 2. mutex lock (hw->aci.lock) is initialized twice Fix these issues. Changes: v2: - let ixgbe_probe() to clean up, instead of ixgbe_recovery_probe() - don't initialize aci lock twice v1: https://lore.kernel.org/intel-wired-lan/20251206155146.95857-1-enjuk@amazon.com/ Kohei Enju (2): ixgbe: fix memory leaks in the ixgbe_recovery_probe() path ixgbe: don't initialize aci lock in ixgbe_recovery_probe() drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 26 +++++++------------ 1 file changed, 10 insertions(+), 16 deletions(-) -- 2.52.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pdx-out-015.esa.us-west-2.outbound.mail-perimeter.amazon.com (pdx-out-015.esa.us-west-2.outbound.mail-perimeter.amazon.com [50.112.246.219]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0AA6381C4 for ; Thu, 11 Dec 2025 09:16:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=50.112.246.219 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765444618; cv=none; b=HZ4hcF/HQOXETATP9r/tJ4zoCVkyfVnockeN6pha3/P5NxqrOPov7Az4JWmN3Q0jO6xo3flqF5q89oNwA87PbHrCDTZodu9gspwJ7Mkzbx2l92gNYQpMHLuJG/3wVfrB2K59WfWINxWbJQIBgl0oBJfEfGCQ+nwfXx750ZbgNjQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765444618; c=relaxed/simple; bh=Z93OVyhZ68fI0HZQw0pqV0spCh3LpuId1s3A3wU5jW0=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=mmfmCOoA5UfUF7opGCyp70sm/CptmT0v9vDeimgBS6yjM2Rsq1rhelXKGb6UaxQI1ZO7WBb/+aTCVHwLJllXVGPB1IS+NotDJEiqqnCLO0RPSrfakGspZSjBrr4OJJbwTST2Rpf4CsEFu8Qy3M/DwtzL/D4p0BsJpJTwYL4SW88= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com; spf=pass smtp.mailfrom=amazon.co.jp; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b=QLT6xvxr; arc=none smtp.client-ip=50.112.246.219 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amazon.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b="QLT6xvxr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2; t=1765444616; x=1796980616; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=uNg4F6k/RPBTY81QVwC0LvyuJ4LEYcF026qfDZof6vc=; b=QLT6xvxriv9jDcqK9uy7dMi2n9dt1z5lRN+RvwzY6MzjGXdfynJq5vhJ xtxYEXCCTm8as4ECBgoMaMLNw9rNXNcoiDcS6OAU7/4DmziFO/NeSAkl2 lWTdbjZUEUp7lvWc7Zn9YlDv50vFDDr31zjabwRIpryfBg14whWEofcKw 4RE8HnMHT5FdJPLnmryKY7pZhrCJd17XoG2eM7X+QVuNvIYbGDUowHmFc 51jee47qZYMOBheDc5cjm9MwyO5MTab0rcSZ53rlOg/BqO7xxNOxkDiv3 1Rdncs6CUhFJ4TfdhUdj2HyY4P1Z7/JHWAjkcdBmFdGaTKcoqdfWYVrIn w==; X-CSE-ConnectionGUID: QlD+MqTGRSK10CPQW1szGw== X-CSE-MsgGUID: rhJr8kBrQL6HS8tWaynf+w== X-IronPort-AV: E=Sophos;i="6.20,265,1758585600"; d="scan'208";a="8701028" Received: from ip-10-5-12-219.us-west-2.compute.internal (HELO smtpout.naws.us-west-2.prod.farcaster.email.amazon.dev) ([10.5.12.219]) by internal-pdx-out-015.esa.us-west-2.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2025 09:16:54 +0000 Received: from EX19MTAUWC002.ant.amazon.com [205.251.233.51:32106] by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.59.230:2525] with esmtp (Farcaster) id 02d555f5-35a8-4aa8-b756-0cb42fc2d65d; Thu, 11 Dec 2025 09:16:53 +0000 (UTC) X-Farcaster-Flow-ID: 02d555f5-35a8-4aa8-b756-0cb42fc2d65d Received: from EX19D001UWA001.ant.amazon.com (10.13.138.214) by EX19MTAUWC002.ant.amazon.com (10.250.64.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.29; Thu, 11 Dec 2025 09:16:53 +0000 Received: from b0be8375a521.amazon.com (10.37.245.7) by EX19D001UWA001.ant.amazon.com (10.13.138.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.29; Thu, 11 Dec 2025 09:16:51 +0000 From: Kohei Enju To: , CC: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , "Jakub Kicinski" , Paolo Abeni , "Jedrzej Jagielski" , Stefan Wegrzyn , Simon Horman , Jacob Keller , , Kohei Enju Subject: [PATCH iwl-net v2 0/2] ixgbe: fix issues around ixgbe_recovery_probe() Date: Thu, 11 Dec 2025 18:15:30 +0900 Message-ID: <20251211091636.57722-1-enjuk@amazon.com> X-Mailer: git-send-email 2.48.1 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: EX19D040UWB002.ant.amazon.com (10.13.138.89) To EX19D001UWA001.ant.amazon.com (10.13.138.214) ixgbe_recovery_probe() and codes around this function have two bugs: 1. resource freeing up is not complete, resulting in memory leaks 2. mutex lock (hw->aci.lock) is initialized twice Fix these issues. Changes: v2: - let ixgbe_probe() to clean up, instead of ixgbe_recovery_probe() - don't initialize aci lock twice v1: https://lore.kernel.org/intel-wired-lan/20251206155146.95857-1-enjuk@amazon.com/ Kohei Enju (2): ixgbe: fix memory leaks in the ixgbe_recovery_probe() path ixgbe: don't initialize aci lock in ixgbe_recovery_probe() drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 26 +++++++------------ 1 file changed, 10 insertions(+), 16 deletions(-) -- 2.52.0