All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: cros-kernel-buildreports@googlegroups.com
Cc: oe-kbuild-all@lists.linux.dev
Subject: [android-common:android14-6.1-2025-05 2/2] kernel/trace/ring_buffer.c:5313: warning: Excess function parameter 'cpu' description in 'ring_buffer_reset_online_cpus'
Date: Thu, 11 Dec 2025 21:21:06 +0800	[thread overview]
Message-ID: <202512112136.1kFWFrIX-lkp@intel.com> (raw)

Hi Jiapeng,

FYI, the error/warning still remains.

tree:   https://android.googlesource.com/kernel/common android14-6.1-2025-05
head:   942b5392945334b7ed428c5982c054f66f110708
commit: b7085b6ffe71ac2668f27a2ced6a1e516f66f8c1 [2/2] ring-buffer: Fix kernel-doc
config: i386-randconfig-053-20251211 (https://download.01.org/0day-ci/archive/20251211/202512112136.1kFWFrIX-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251211/202512112136.1kFWFrIX-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512112136.1kFWFrIX-lkp@intel.com/

All warnings (new ones prefixed by >>):

   kernel/trace/ring_buffer.c:936: warning: Function parameter or member 'cpu' not described in 'ring_buffer_wake_waiters'
   kernel/trace/ring_buffer.c:1544: warning: Function parameter or member 'cpu_buffer' not described in 'rb_check_list'
   kernel/trace/ring_buffer.c:1544: warning: Function parameter or member 'list' not described in 'rb_check_list'
>> kernel/trace/ring_buffer.c:5313: warning: Excess function parameter 'cpu' description in 'ring_buffer_reset_online_cpus'


vim +5313 kernel/trace/ring_buffer.c

41b6a95d693319 Steven Rostedt          2009-09-02  5306  
b23d7a5f4a07af Nicholas Piggin         2020-06-25  5307  /**
b7085b6ffe71ac Jiapeng Chong           2022-10-09  5308   * ring_buffer_reset_online_cpus - reset a ring buffer per CPU buffer
b23d7a5f4a07af Nicholas Piggin         2020-06-25  5309   * @buffer: The ring buffer to reset a per cpu buffer of
b23d7a5f4a07af Nicholas Piggin         2020-06-25  5310   * @cpu: The CPU buffer to be reset
b23d7a5f4a07af Nicholas Piggin         2020-06-25  5311   */
b23d7a5f4a07af Nicholas Piggin         2020-06-25  5312  void ring_buffer_reset_online_cpus(struct trace_buffer *buffer)
b23d7a5f4a07af Nicholas Piggin         2020-06-25 @5313  {
b23d7a5f4a07af Nicholas Piggin         2020-06-25  5314  	struct ring_buffer_per_cpu *cpu_buffer;
b23d7a5f4a07af Nicholas Piggin         2020-06-25  5315  	int cpu;
7a8e76a3829f10 Steven Rostedt          2008-09-29  5316  
bbeb97464eefc6 Gaurav Kohli            2020-10-06  5317  	/* prevent another thread from changing buffer sizes */
bbeb97464eefc6 Gaurav Kohli            2020-10-06  5318  	mutex_lock(&buffer->mutex);
bbeb97464eefc6 Gaurav Kohli            2020-10-06  5319  
b23d7a5f4a07af Nicholas Piggin         2020-06-25  5320  	for_each_online_buffer_cpu(buffer, cpu) {
b23d7a5f4a07af Nicholas Piggin         2020-06-25  5321  		cpu_buffer = buffer->buffers[cpu];
7a8e76a3829f10 Steven Rostedt          2008-09-29  5322  
b23d7a5f4a07af Nicholas Piggin         2020-06-25  5323  		atomic_inc(&cpu_buffer->resize_disabled);
b23d7a5f4a07af Nicholas Piggin         2020-06-25  5324  		atomic_inc(&cpu_buffer->record_disabled);
b23d7a5f4a07af Nicholas Piggin         2020-06-25  5325  	}
f83c9d0fe42a75 Steven Rostedt          2008-11-11  5326  
b23d7a5f4a07af Nicholas Piggin         2020-06-25  5327  	/* Make sure all commits have finished */
b23d7a5f4a07af Nicholas Piggin         2020-06-25  5328  	synchronize_rcu();
b23d7a5f4a07af Nicholas Piggin         2020-06-25  5329  
b23d7a5f4a07af Nicholas Piggin         2020-06-25  5330  	for_each_online_buffer_cpu(buffer, cpu) {
b23d7a5f4a07af Nicholas Piggin         2020-06-25  5331  		cpu_buffer = buffer->buffers[cpu];
b23d7a5f4a07af Nicholas Piggin         2020-06-25  5332  
b23d7a5f4a07af Nicholas Piggin         2020-06-25  5333  		reset_disabled_cpu_buffer(cpu_buffer);
41ede23eded408 Steven Rostedt          2009-05-01  5334  
41ede23eded408 Steven Rostedt          2009-05-01  5335  		atomic_dec(&cpu_buffer->record_disabled);
07b8b10ec94f85 Steven Rostedt (VMware  2020-03-27  5336) 		atomic_dec(&cpu_buffer->resize_disabled);
7a8e76a3829f10 Steven Rostedt          2008-09-29  5337  	}
bbeb97464eefc6 Gaurav Kohli            2020-10-06  5338  
bbeb97464eefc6 Gaurav Kohli            2020-10-06  5339  	mutex_unlock(&buffer->mutex);
b23d7a5f4a07af Nicholas Piggin         2020-06-25  5340  }
7a8e76a3829f10 Steven Rostedt          2008-09-29  5341  

:::::: The code at line 5313 was first introduced by commit
:::::: b23d7a5f4a07af02343cdd28fe1f7488bac3afda ring-buffer: speed up buffer resets by avoiding synchronize_rcu for each CPU

:::::: TO: Nicholas Piggin <npiggin@gmail.com>
:::::: CC: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2025-12-11 13:22 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202512112136.1kFWFrIX-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=cros-kernel-buildreports@googlegroups.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.