All of lore.kernel.org
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: Enze Li <lienze@kylinos.cn>
Cc: SeongJae Park <sj@kernel.org>,
	akpm@linux-foundation.org, damon@lists.linux.dev,
	linux-mm@kvack.org, enze.li@gmx.com,
	Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] mm/damon: add loadable module support for sample modules
Date: Thu, 11 Dec 2025 13:55:03 -0800	[thread overview]
Message-ID: <20251211215504.79014-1-sj@kernel.org> (raw)
In-Reply-To: <20251211125614.1242713-1-lienze@kylinos.cn>

+ Christoph

On Thu, 11 Dec 2025 20:56:14 +0800 Enze Li <lienze@kylinos.cn> wrote:

> This patch adds loadable kernel module compilation support for the three
> DAMON sample modules.  While preserving the existing built-in compilation
> option, the change introduces necessary code exports and configuration
> updates, enabling these modules to also be built as independent loadable
> modules.
> 
> Key modifications include exporting required function symbols from
> damon/core.c and changing relevant Kconfig options from bool to
> tristate.  This allows users to select between "built-in", "module", and
> "disabled" configurations.
> 
> This enhancement provides greater flexibility for both development and
> deployment.  Users can now compile the sample modules as loadable
> modules and manage them dynamically at runtime without reconfiguration
> or system reboots.

Thank you for this patch, Enze.  Actually we tried to make the modules
loadable, but there was an objection [1] with kind clarification from
Christoph.  In short, we don't want to make DAMON supports loadable modules
unless there is a real use case in tree.  Samples are supposed to be samples,
not real usages.  Do you have a real use case of the sample modules that
require loadability?

[1] https://lore.kernel.org/damon/20231205172307.2310-1-sj@kernel.org/


Thanks,
SJ

[...]

  reply	other threads:[~2025-12-11 21:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-11 12:56 [PATCH] mm/damon: add loadable module support for sample modules Enze Li
2025-12-11 21:55 ` SeongJae Park [this message]
2025-12-15 14:19   ` Enze Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251211215504.79014-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=enze.li@gmx.com \
    --cc=hch@infradead.org \
    --cc=lienze@kylinos.cn \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.