Re: [PATCH v2 0/3] at91: Remove of_platform_default_populate() calls

From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Claudiu Beznea <claudiu.beznea@tuxon.dev>,
	Russell King <linux@armlinux.org.uk>,
	linux-mtd@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] at91: Remove of_platform_default_populate() calls
Date: Fri, 12 Dec 2025 18:37:44 +0100	[thread overview]
Message-ID: <202512121737447cdf2224@mail.local> (raw)
In-Reply-To: <20251120-at91-probe-v2-0-8c8592f02e8e@kernel.org>

On 20/11/2025 15:37:49-0600, Rob Herring (Arm) wrote:
> This is another attempt at removing of_platform_default_populate() calls 
> on at91 platforms. The last attempts were in 2018[1] and 2023[2]. The 
> problems reported are PM and NAND failures. Both of these depend on SRAM 
> pool which doesn't have any fw_devlink tracking. Also, the PM code is 
> not a driver, so fw_devlink wouldn't help. For the NAND driver, we can 
> simply defer probe. For the PM init, we can move it to the .late_init 
> hook.
> 
> Rob
> 
> [1] https://lore.kernel.org/all/20180712192222.32481-1-robh@kernel.org/
> [2] https://lore.kernel.org/all/3908fa6f-dc33-4aac-c21f-4a676a3a6b23@microchip.com/
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>

For the whole series:

Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Tested-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

I tested on at91rm9200, at91sam9m10 and sama5d3 which is a
representative sample of the older platforms.

I tested suspend/resume successfully on at91sam9m10 and sama5d3.
at91rm9200 is not waking up but this is not caused by the series.

> ---
> Rob Herring (1):
>       ARM: at91: Move PM init functions to .init_late hook
> 
> Rob Herring (Arm) (2):
>       mtd: nand: atmel: Defer probe if SRAM is missing
>       ARM: at91: remove unnecessary of_platform_default_populate calls
> 
>  arch/arm/mach-at91/at91rm9200.c              | 12 +-----------
>  arch/arm/mach-at91/at91sam9.c                | 12 +-----------
>  arch/arm/mach-at91/sam9x60.c                 | 12 +-----------
>  arch/arm/mach-at91/sam9x7.c                  | 12 +-----------
>  arch/arm/mach-at91/sama5.c                   | 21 +++------------------
>  arch/arm/mach-at91/sama7.c                   | 11 +----------
>  drivers/mtd/nand/raw/atmel/nand-controller.c |  2 +-
>  7 files changed, 9 insertions(+), 73 deletions(-)
> ---
> base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
> change-id: 20251120-at91-probe-20fbce9a6d1b
> 
> Best regards,
> --  
> Rob Herring (Arm) <robh@kernel.org>
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com