All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Matthew Maurer <mmaurer@google.com>
Cc: "Bjorn Andersson" <andersson@kernel.org>,
	"Konrad Dybcio" <konradybcio@kernel.org>,
	"Satya Durga Srinivasu Prabhala" <satyap@quicinc.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Trilok Soni" <tsoni@quicinc.com>,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	rust-for-linux@vger.kernel.org
Subject: Re: [PATCH RFC] soc: qcom: socinfo: Re-implement in Rust
Date: Sat, 13 Dec 2025 14:57:22 +0100	[thread overview]
Message-ID: <2025121303-railing-fountain-bebf@gregkh> (raw)
In-Reply-To: <20251213-qcom-socinfo-v1-1-5daa7f5f2a85@google.com>

On Sat, Dec 13, 2025 at 12:36:00AM +0000, Matthew Maurer wrote:
>  drivers/soc/qcom/Kconfig             |   1 +
>  drivers/soc/qcom/Makefile            |   2 +-
>  drivers/soc/qcom/socinfo.c           | 931 -----------------------------------
>  drivers/soc/qcom/socinfo/Makefile    |   2 +
>  drivers/soc/qcom/socinfo/bindings.rs |  59 +++
>  drivers/soc/qcom/socinfo/data.rs     | 424 ++++++++++++++++
>  drivers/soc/qcom/socinfo/socinfo.rs  | 362 ++++++++++++++

Shouldn't this all just be in 1 .rs file?  By not doing that, you have a
number of public symbols (that are very generic), that will "pollute"
the global namespace of the kernel symbol table (unless rust does this
somehow differently?)

But putting this all in 1 file should solve all of that, and remove all
global symbols.  Especially for just a small and simple driver like
this, no need to split it up at all.

thanks,

greg k-h

  parent reply	other threads:[~2025-12-13 13:57 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <x2HszWYqUaRfzLW8I1wOegJRSBRXVUzqafU9O_QLG1E-OjqkyUPQKn-jM9dzhvsgMW_M0NGXvrgEkN0p9mV7ww==@protonmail.internalid>
2025-12-13  0:36 ` [PATCH RFC] soc: qcom: socinfo: Re-implement in Rust Matthew Maurer
2025-12-13  2:50   ` Bryan O'Donoghue
2025-12-13  3:01     ` Miguel Ojeda
2025-12-13  3:54   ` Dmitry Baryshkov
2025-12-13 16:58     ` Matthew Maurer
2025-12-15 12:11       ` Gary Guo
2025-12-15 19:44       ` Dmitry Baryshkov
2025-12-16  0:55         ` Matthew Maurer
2025-12-16  9:45           ` Danilo Krummrich
2025-12-13 13:27   ` Greg KH
2025-12-13 16:26     ` Matthew Maurer
2025-12-13 17:11       ` Matthew Maurer
2025-12-13 13:57   ` Greg KH [this message]
2025-12-13 16:24     ` Matthew Maurer
2025-12-13 17:08       ` Matthew Maurer
2025-12-16 21:00       ` Bjorn Andersson
2025-12-16 20:55         ` Matthew Maurer
2025-12-16 22:14           ` Bjorn Andersson
2025-12-16 22:32             ` Matthew Maurer
2025-12-16 20:57   ` Bjorn Andersson
2025-12-16 20:53     ` Matthew Maurer
2025-12-16 22:01       ` Bjorn Andersson
2025-12-16 22:13         ` Matthew Maurer
2025-12-16 23:13           ` Bjorn Andersson
2025-12-16 23:32             ` Matthew Maurer
2025-12-17  0:23               ` Bjorn Andersson
2025-12-17  0:27                 ` Matthew Maurer
2025-12-17 18:35             ` Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025121303-railing-fountain-bebf@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=a.hindborg@kernel.org \
    --cc=aliceryhl@google.com \
    --cc=andersson@kernel.org \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=konradybcio@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=mmaurer@google.com \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=satyap@quicinc.com \
    --cc=tmgross@umich.edu \
    --cc=tsoni@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.