From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53ABC169AD2 for ; Fri, 12 Dec 2025 22:42:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765579358; cv=none; b=Db34W6qlg5P3o+KwGTxOpR79fv2u3g4yRRRsKUP9fFLdt0VDpMzguBj/8wXLgcixtunyC8RDF0H+HXSR3pJfBQOaCDjbhIJh3g1d2yUeCSCddjaCQCP+1vxHMuopEK44FDUaKYYxylO2RJifY5LnVJ3b4E4P6p9kdrGZNuEoolk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765579358; c=relaxed/simple; bh=QFFMyrWwAVoi0TuG9mHGc2qykyiBf/c0JXvKfg+uOaM=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=g8MCOYMmyxxjBdw3XOg9U1OF6BqQOHHQoHTTZ1pu8KPos5N32Iov2Czx7yjwyFewtZuM331i+OBsl3z00pQl2h7H07xlbNBU0ygjmkpp/ZsS6tKtR+5hrSfASz5izykFHebVZDChnBdp8ILa31ubkny3KFwUNCy7LWaNnuAr878= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ezs/JKu9; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ezs/JKu9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1765579356; x=1797115356; h=date:from:to:cc:subject:message-id:mime-version; bh=QFFMyrWwAVoi0TuG9mHGc2qykyiBf/c0JXvKfg+uOaM=; b=ezs/JKu9MBWR5NxvtVR74oT8L2RBLrCrxOSbElJ4yAuEtVjhRXtL3eHM vVzkuqEoVUvTzZ4c+wB/NGH2/hbkAEmguBJyjy/THtrB/SDUA4PV4cKew f3l7425YwiZCvbxs1oXg1fKE2xBhvnpYm6lpTgIsrloYOX8vQmFKNg388 W/kL5aHr7zPzib5jv+BmUpxMkYt1xXs64engVV1huB6PBr0R3+Uju49k+ ixYy/RrwY1wMbk+imVkgWeiMxSliyJn1WGSmJEHgvS45MN1L0clBKHvNn 5MGizulTUgjjb5HSk3VxWj8Z92rBcMiRE1dBAsTR05Ot7gHi+MuL+Lgr9 g==; X-CSE-ConnectionGUID: ntTbKk7jRryWBbQjo0viTA== X-CSE-MsgGUID: pIe8P/E4SGaah06tNes41Q== X-IronPort-AV: E=McAfee;i="6800,10657,11640"; a="67626949" X-IronPort-AV: E=Sophos;i="6.21,144,1763452800"; d="scan'208";a="67626949" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Dec 2025 14:42:36 -0800 X-CSE-ConnectionGUID: cyYziqaBQ4mJ9kj8oMxkaQ== X-CSE-MsgGUID: QtFBaYpaQ8Kfx1R2ikjx+w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,144,1763452800"; d="scan'208";a="197260102" Received: from lkp-server01.sh.intel.com (HELO d335e3c6db51) ([10.239.97.150]) by orviesa008.jf.intel.com with ESMTP; 12 Dec 2025 14:42:35 -0800 Received: from kbuild by d335e3c6db51 with local (Exim 4.98.2) (envelope-from ) id 1vUBqK-000000006iN-1fpg; Fri, 12 Dec 2025 22:42:32 +0000 Date: Sat, 13 Dec 2025 06:41:53 +0800 From: kernel test robot To: oe-kbuild@lists.linux.dev Cc: lkp@intel.com, Dan Carpenter Subject: drivers/of/device.c:40 of_dma_set_restricted_buffer() warn: iterator 'i' not incremented Message-ID: <202512130644.4FfBmwDO-lkp@intel.com> Precedence: bulk X-Mailing-List: oe-kbuild@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline BCC: lkp@intel.com CC: oe-kbuild-all@lists.linux.dev CC: linux-kernel@vger.kernel.org TO: "Rob Herring (Arm)" tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 187d0801404f415f22c0b31531982c7ea97fa341 commit: df56b2443e14e8288baf76aa5ee39a26289874e8 of: Simplify of_dma_set_restricted_buffer() to use of_for_each_phandle() date: 7 months ago :::::: branch date: 12 hours ago :::::: commit date: 7 months ago config: sparc-randconfig-r071-20251212 (https://download.01.org/0day-ci/archive/20251213/202512130644.4FfBmwDO-lkp@intel.com/config) compiler: sparc64-linux-gcc (GCC) 15.1.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202512130644.4FfBmwDO-lkp@intel.com/ New smatch warnings: drivers/of/device.c:40 of_dma_set_restricted_buffer() warn: iterator 'i' not incremented Old smatch warnings: drivers/of/device.c:300 of_device_make_bus_id() warn: excess argument passed to 'dev_set_name' drivers/of/device.c:304 of_device_make_bus_id() warn: excess argument passed to 'dev_set_name' drivers/of/device.c:310 of_device_make_bus_id() warn: excess argument passed to 'dev_set_name' vim +/i +40 drivers/of/device.c f85ff3056cefdf4 Stephen Rothwell 2007-05-01 34 f3cfd136aef0184 Will Deacon 2021-08-16 35 static void ce5cb67c664fbc9 Will Deacon 2021-08-16 36 of_dma_set_restricted_buffer(struct device *dev, struct device_node *np) ce5cb67c664fbc9 Will Deacon 2021-08-16 37 { df56b2443e14e82 Rob Herring (Arm 2025-04-23 38) struct device_node *of_node = dev->of_node; df56b2443e14e82 Rob Herring (Arm 2025-04-23 39) struct of_phandle_iterator it; df56b2443e14e82 Rob Herring (Arm 2025-04-23 @40) int rc, i = 0; ce5cb67c664fbc9 Will Deacon 2021-08-16 41 f3cfd136aef0184 Will Deacon 2021-08-16 42 if (!IS_ENABLED(CONFIG_DMA_RESTRICTED_POOL)) f3cfd136aef0184 Will Deacon 2021-08-16 43 return; f3cfd136aef0184 Will Deacon 2021-08-16 44 ce5cb67c664fbc9 Will Deacon 2021-08-16 45 /* ce5cb67c664fbc9 Will Deacon 2021-08-16 46 * If dev->of_node doesn't exist or doesn't contain memory-region, try ce5cb67c664fbc9 Will Deacon 2021-08-16 47 * the OF node having DMA configuration. ce5cb67c664fbc9 Will Deacon 2021-08-16 48 */ df56b2443e14e82 Rob Herring (Arm 2025-04-23 49) if (!of_property_present(of_node, "memory-region")) ce5cb67c664fbc9 Will Deacon 2021-08-16 50 of_node = np; ce5cb67c664fbc9 Will Deacon 2021-08-16 51 df56b2443e14e82 Rob Herring (Arm 2025-04-23 52) of_for_each_phandle(&it, rc, of_node, "memory-region", NULL, 0) { ce5cb67c664fbc9 Will Deacon 2021-08-16 53 /* ce5cb67c664fbc9 Will Deacon 2021-08-16 54 * There might be multiple memory regions, but only one ce5cb67c664fbc9 Will Deacon 2021-08-16 55 * restricted-dma-pool region is allowed. ce5cb67c664fbc9 Will Deacon 2021-08-16 56 */ df56b2443e14e82 Rob Herring (Arm 2025-04-23 57) if (of_device_is_compatible(it.node, "restricted-dma-pool") && df56b2443e14e82 Rob Herring (Arm 2025-04-23 58) of_device_is_available(it.node)) { df56b2443e14e82 Rob Herring (Arm 2025-04-23 59) if (of_reserved_mem_device_init_by_idx(dev, of_node, i)) df56b2443e14e82 Rob Herring (Arm 2025-04-23 60) dev_warn(dev, "failed to initialise \"restricted-dma-pool\" memory node\n"); df56b2443e14e82 Rob Herring (Arm 2025-04-23 61) of_node_put(it.node); f3cfd136aef0184 Will Deacon 2021-08-16 62 break; ce5cb67c664fbc9 Will Deacon 2021-08-16 63 } df56b2443e14e82 Rob Herring (Arm 2025-04-23 64) i++; d17e37c41b7ed38 Liang He 2022-07-02 65 } ce5cb67c664fbc9 Will Deacon 2021-08-16 66 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki