From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: drivers/usb/typec/ucsi/ucsi.c:88 ucsi_sync_control_common() error: we previously assumed 'cci' could be null (see line 84)
Date: Sat, 13 Dec 2025 07:49:29 +0800 [thread overview]
Message-ID: <202512130701.vmqs7dci-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Dmitry Baryshkov <lumag@kernel.org>
CC: "Łukasz Bartosik" <ukaszb@chromium.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 187d0801404f415f22c0b31531982c7ea97fa341
commit: 667ecac55861281c1f5e107c8550ae893b3984f6 usb: typec: ucsi: return CCI and message from sync_control callback
date: 10 months ago
:::::: branch date: 14 hours ago
:::::: commit date: 10 months ago
config: x86_64-randconfig-161-20251212 (https://download.01.org/0day-ci/archive/20251213/202512130701.vmqs7dci-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.4.0-5) 12.4.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202512130701.vmqs7dci-lkp@intel.com/
New smatch warnings:
drivers/usb/typec/ucsi/ucsi.c:88 ucsi_sync_control_common() error: we previously assumed 'cci' could be null (see line 84)
Old smatch warnings:
drivers/usb/typec/ucsi/ucsi.c:746 ucsi_get_pd_caps() warn: passing zero to 'ERR_PTR'
drivers/usb/typec/ucsi/ucsi.c:1456 ucsi_dr_swap() warn: missing error code 'ret'
vim +/cci +88 drivers/usb/typec/ucsi/ucsi.c
584e8df58942338 Dmitry Baryshkov 2024-06-27 57
667ecac55861281 Dmitry Baryshkov 2025-01-20 58 int ucsi_sync_control_common(struct ucsi *ucsi, u64 command, u32 *cci,
667ecac55861281 Dmitry Baryshkov 2025-01-20 59 void *data, size_t size)
584e8df58942338 Dmitry Baryshkov 2024-06-27 60 {
584e8df58942338 Dmitry Baryshkov 2024-06-27 61 bool ack = UCSI_COMMAND(command) == UCSI_ACK_CC_CI;
584e8df58942338 Dmitry Baryshkov 2024-06-27 62 int ret;
584e8df58942338 Dmitry Baryshkov 2024-06-27 63
584e8df58942338 Dmitry Baryshkov 2024-06-27 64 if (ack)
584e8df58942338 Dmitry Baryshkov 2024-06-27 65 set_bit(ACK_PENDING, &ucsi->flags);
584e8df58942338 Dmitry Baryshkov 2024-06-27 66 else
584e8df58942338 Dmitry Baryshkov 2024-06-27 67 set_bit(COMMAND_PENDING, &ucsi->flags);
584e8df58942338 Dmitry Baryshkov 2024-06-27 68
e37b383df91ba9b Łukasz Bartosik 2024-12-03 69 reinit_completion(&ucsi->complete);
e37b383df91ba9b Łukasz Bartosik 2024-12-03 70
584e8df58942338 Dmitry Baryshkov 2024-06-27 71 ret = ucsi->ops->async_control(ucsi, command);
584e8df58942338 Dmitry Baryshkov 2024-06-27 72 if (ret)
584e8df58942338 Dmitry Baryshkov 2024-06-27 73 goto out_clear_bit;
584e8df58942338 Dmitry Baryshkov 2024-06-27 74
584e8df58942338 Dmitry Baryshkov 2024-06-27 75 if (!wait_for_completion_timeout(&ucsi->complete, 5 * HZ))
584e8df58942338 Dmitry Baryshkov 2024-06-27 76 ret = -ETIMEDOUT;
584e8df58942338 Dmitry Baryshkov 2024-06-27 77
584e8df58942338 Dmitry Baryshkov 2024-06-27 78 out_clear_bit:
584e8df58942338 Dmitry Baryshkov 2024-06-27 79 if (ack)
584e8df58942338 Dmitry Baryshkov 2024-06-27 80 clear_bit(ACK_PENDING, &ucsi->flags);
584e8df58942338 Dmitry Baryshkov 2024-06-27 81 else
584e8df58942338 Dmitry Baryshkov 2024-06-27 82 clear_bit(COMMAND_PENDING, &ucsi->flags);
584e8df58942338 Dmitry Baryshkov 2024-06-27 83
667ecac55861281 Dmitry Baryshkov 2025-01-20 @84 if (!ret && cci)
667ecac55861281 Dmitry Baryshkov 2025-01-20 85 ret = ucsi->ops->read_cci(ucsi, cci);
667ecac55861281 Dmitry Baryshkov 2025-01-20 86
667ecac55861281 Dmitry Baryshkov 2025-01-20 87 if (!ret && data &&
667ecac55861281 Dmitry Baryshkov 2025-01-20 @88 (*cci & UCSI_CCI_COMMAND_COMPLETE))
667ecac55861281 Dmitry Baryshkov 2025-01-20 89 ret = ucsi->ops->read_message_in(ucsi, data, size);
667ecac55861281 Dmitry Baryshkov 2025-01-20 90
584e8df58942338 Dmitry Baryshkov 2024-06-27 91 return ret;
584e8df58942338 Dmitry Baryshkov 2024-06-27 92 }
584e8df58942338 Dmitry Baryshkov 2024-06-27 93 EXPORT_SYMBOL_GPL(ucsi_sync_control_common);
584e8df58942338 Dmitry Baryshkov 2024-06-27 94
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2025-12-12 23:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-12 23:49 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-24 15:05 drivers/usb/typec/ucsi/ucsi.c:88 ucsi_sync_control_common() error: we previously assumed 'cci' could be null (see line 84) kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202512130701.vmqs7dci-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.