All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/device.c:134 r535_gsp_device_ctor() warn: 'args' can also be NULL
Date: Sat, 13 Dec 2025 09:51:02 +0800	[thread overview]
Message-ID: <202512130925.UQUFlbCS-lkp@intel.com> (raw)

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Ben Skeggs <bskeggs@nvidia.com>
CC: Dave Airlie <airlied@redhat.com>
CC: Timur Tabi <ttabi@nvidia.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   187d0801404f415f22c0b31531982c7ea97fa341
commit: f964336483159da1f4ca67d7abef3d82e725ed36 drm/nouveau/gsp: split device handling out on its own
date:   7 months ago
:::::: branch date: 16 hours ago
:::::: commit date: 7 months ago
config: microblaze-randconfig-r073-20251212 (https://download.01.org/0day-ci/archive/20251213/202512130925.UQUFlbCS-lkp@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 8.5.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202512130925.UQUFlbCS-lkp@intel.com/

New smatch warnings:
drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/device.c:134 r535_gsp_device_ctor() warn: 'args' can also be NULL

Old smatch warnings:
drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/device.c:81 r535_gsp_device_event_ctor() warn: 'args' can also be NULL

vim +/args +134 drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/device.c

f964336483159d Ben Skeggs 2024-11-14  122  
f964336483159d Ben Skeggs 2024-11-14  123  static int
f964336483159d Ben Skeggs 2024-11-14  124  r535_gsp_device_ctor(struct nvkm_gsp_client *client, struct nvkm_gsp_device *device)
f964336483159d Ben Skeggs 2024-11-14  125  {
f964336483159d Ben Skeggs 2024-11-14  126  	NV0080_ALLOC_PARAMETERS *args;
f964336483159d Ben Skeggs 2024-11-14  127  	int ret;
f964336483159d Ben Skeggs 2024-11-14  128  
f964336483159d Ben Skeggs 2024-11-14  129  	args = nvkm_gsp_rm_alloc_get(&client->object, 0xde1d0000, NV01_DEVICE_0, sizeof(*args),
f964336483159d Ben Skeggs 2024-11-14  130  				     &device->object);
f964336483159d Ben Skeggs 2024-11-14  131  	if (IS_ERR(args))
f964336483159d Ben Skeggs 2024-11-14  132  		return PTR_ERR(args);
f964336483159d Ben Skeggs 2024-11-14  133  
f964336483159d Ben Skeggs 2024-11-14 @134  	args->hClientShare = client->object.handle;
f964336483159d Ben Skeggs 2024-11-14  135  
f964336483159d Ben Skeggs 2024-11-14  136  	ret = nvkm_gsp_rm_alloc_wr(&device->object, args);
f964336483159d Ben Skeggs 2024-11-14  137  	if (ret)
f964336483159d Ben Skeggs 2024-11-14  138  		return ret;
f964336483159d Ben Skeggs 2024-11-14  139  
f964336483159d Ben Skeggs 2024-11-14  140  	ret = r535_gsp_subdevice_ctor(device);
f964336483159d Ben Skeggs 2024-11-14  141  	if (ret)
f964336483159d Ben Skeggs 2024-11-14  142  		nvkm_gsp_rm_free(&device->object);
f964336483159d Ben Skeggs 2024-11-14  143  
f964336483159d Ben Skeggs 2024-11-14  144  	return ret;
f964336483159d Ben Skeggs 2024-11-14  145  }
f964336483159d Ben Skeggs 2024-11-14  146  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2025-12-13  1:51 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202512130925.UQUFlbCS-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=error27@gmail.com \
    --cc=oe-kbuild@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.