[Buildroot] [PATCH v2 1/2] package/libtirpc: introduce BR2_PACKAGE_LIBTIRPC_DB

[Buildroot] [PATCH v2 1/2] package/libtirpc: introduce BR2_PACKAGE_LIBTIRPC_DB

[Giulio Benetti]

Package libtirpc expose rpcdb so make it selectable.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
V1->V2:
* add patch to series
---
 package/libtirpc/Config.in   | 6 ++++++
 package/libtirpc/libtirpc.mk | 7 +++++++
 2 files changed, 13 insertions(+)

diff --git a/package/libtirpc/Config.in b/package/libtirpc/Config.in
index 31f1636ef5..e1ac9a4e7b 100644
--- a/package/libtirpc/Config.in
+++ b/package/libtirpc/Config.in
@@ -16,6 +16,12 @@ config BR2_PACKAGE_LIBTIRPC_GSS
 	help
 	  Enable GSSAPI support
 
+config BR2_PACKAGE_LIBTIRPC_DB
+	bool "db"
+	depends on BR2_PACKAGE_LIBTIRPC
+	help
+	  Enable RPCDB support
+
 comment "libtirpc needs a toolchain w/ threads"
 	depends on !BR2_TOOLCHAIN_HAS_THREADS
 
diff --git a/package/libtirpc/libtirpc.mk b/package/libtirpc/libtirpc.mk
index ab15954561..7aca2c83af 100644
--- a/package/libtirpc/libtirpc.mk
+++ b/package/libtirpc/libtirpc.mk
@@ -25,5 +25,12 @@ LIBTIRPC_CONF_OPTS += --disable-gssapi
 endif
 HOST_LIBTIRPC_CONF_OPTS = --disable-gssapi
 
+ifeq ($(BR2_PACKAGE_LIBTIRPC_DB),y)
+LIBTIRPC_CONF_OPTS += --enable-rpcdb
+else
+LIBTIRPC_CONF_OPTS += --disable-rpcdb
+endif
+HOST_LIBTIRPC_CONF_OPTS += --disable-rpcdb
+
 $(eval $(autotools-package))
 $(eval $(host-autotools-package))
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 2/2] pacakge/nfs-utils: fix build failure due to missing BR2_PACKAGE_LIBTIRPC_DB

[Giulio Benetti]

Pacakge nfs-utils requires libtirpc rpcdb option, so let's select it by
default.

Fixes:
https://autobuild.buildroot.org/results/29adf2d04cf4c46e492af95edaa96983985d6b57/

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
V1->V2:
* no changes
---
 package/nfs-utils/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/nfs-utils/Config.in b/package/nfs-utils/Config.in
index 02cc7e78cc..3e13bf87a9 100644
--- a/package/nfs-utils/Config.in
+++ b/package/nfs-utils/Config.in
@@ -9,6 +9,7 @@ config BR2_PACKAGE_NFS_UTILS
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_17 # getrandom()
 	select BR2_PACKAGE_LIBEVENT
 	select BR2_PACKAGE_LIBTIRPC # IPv6 requires libtirpc
+	select BR2_PACKAGE_LIBTIRPC_DB
 	select BR2_PACKAGE_SQLITE
 	select BR2_PACKAGE_UTIL_LINUX
 	select BR2_PACKAGE_UTIL_LINUX_LIBBLKID
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 2/2] pacakge/nfs-utils: fix build failure due to missing BR2_PACKAGE_LIBTIRPC_DB

[Thomas Petazzoni via buildroot]

Hello,

On Sat, 13 Dec 2025 16:17:30 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> Pacakge nfs-utils requires libtirpc rpcdb option, so let's select it by

  ^^^^^^ minor typo

Since when is this needed? When fixing an autobuilder issue, we need to
understand what introduced the problem so that we know whether the fix
needs to be backported or not.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 2/2] pacakge/nfs-utils: fix build failure due to missing BR2_PACKAGE_LIBTIRPC_DB

[Petr Vorel]

Hi Giulio, Thomas,

> Hello,

> On Sat, 13 Dec 2025 16:17:30 +0100
> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> > Pacakge nfs-utils requires libtirpc rpcdb option, so let's select it by

>   ^^^^^^ minor typo

I pointed that out in v1 :).

>        select BR2_PACKAGE_LIBTIRPC # IPv6 requires libtirpc
>+       select BR2_PACKAGE_LIBTIRPC_DB # getrpcbynumber

Maybe also here note the reason?

I hope Thomas can fix both of these before merge.

Reviewed-by: Petr Vorel <petr.vorel@gmail.com>

Kind regards,
Petr

> Since when is this needed? When fixing an autobuilder issue, we need to
> understand what introduced the problem so that we know whether the fix
> needs to be backported or not.

> Thanks a lot!

> Thomas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 2/2] pacakge/nfs-utils: fix build failure due to missing BR2_PACKAGE_LIBTIRPC_DB

[Thomas Petazzoni via buildroot]

Hello,

On Sat, 13 Dec 2025 16:17:30 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> Pacakge nfs-utils requires libtirpc rpcdb option, so let's select it by
> default.
> 
> Fixes:
> https://autobuild.buildroot.org/results/29adf2d04cf4c46e492af95edaa96983985d6b57/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

It seems like rpcbind will need the same thing?

	https://autobuild.buildroot.org/results/f461212605d9d5f1c38a1ffe00a83912522bf482/build-end.log

Let me know if you want to address it as well, or if you would like me
to send a separate patch.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 2/2] pacakge/nfs-utils: fix build failure due to missing BR2_PACKAGE_LIBTIRPC_DB

[Giulio Benetti]

Hi Thomas,

thanks for looking into these patches,

> Il giorno 13 dic 2025, alle ore 18:56, Thomas Petazzoni <thomas.petazzoni@bootlin.com> ha scritto:
> 
> Hello,
> 
>> On Sat, 13 Dec 2025 16:17:30 +0100
>> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
>> 
>> Pacakge nfs-utils requires libtirpc rpcdb option, so let's select it by
>> default.
>> 
>> Fixes:
>> https://autobuild.buildroot.org/results/29adf2d04cf4c46e492af95edaa96983985d6b57/
>> 
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> 
> It seems like rpcbind will need the same thing?
> 
>    https://autobuild.buildroot.org/results/f461212605d9d5f1c38a1ffe00a83912522bf482/build-end.log
> 
> Let me know if you want to address it as well, or if you would like me
> to send a separate patch.

I’m glad to send a patch for rpcbind in some day. So I can clean up these patches too.

Best regards.
Giulio

> 
> Thanks a lot!
> 
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 2/2] pacakge/nfs-utils: fix build failure due to missing BR2_PACKAGE_LIBTIRPC_DB

[Petr Vorel]

> Hi Thomas,

> thanks for looking into these patches,

> > Il giorno 13 dic 2025, alle ore 18:56, Thomas Petazzoni <thomas.petazzoni@bootlin.com> ha scritto:

> > Hello,

> >> On Sat, 13 Dec 2025 16:17:30 +0100
> >> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> >> Pacakge nfs-utils requires libtirpc rpcdb option, so let's select it by
> >> default.

> >> Fixes:
> >> https://autobuild.buildroot.org/results/29adf2d04cf4c46e492af95edaa96983985d6b57/

> >> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

> > It seems like rpcbind will need the same thing?

> >    https://autobuild.buildroot.org/results/f461212605d9d5f1c38a1ffe00a83912522bf482/build-end.log

Thomas, thanks for pointing this out.

> > Let me know if you want to address it as well, or if you would like me
> > to send a separate patch.

> I’m glad to send a patch for rpcbind in some day. So I can clean up these patches too.

+1, thanks! Otherwise I'd send a patch.

This is also needed since libtirpc 1.3.7. Commit
7cea8ad ("Add conditional version script support")
added --enable-rpcdb, which is the default off.

Kind regards,
Petr

> Best regards.
> Giulio
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/2] package/libtirpc: introduce BR2_PACKAGE_LIBTIRPC_DB

[Thomas Petazzoni via buildroot]

Hello Giulio,

On Sat, 13 Dec 2025 16:17:29 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> Package libtirpc expose rpcdb so make it selectable.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> V1->V2:
> * add patch to series
> ---
>  package/libtirpc/Config.in   | 6 ++++++
>  package/libtirpc/libtirpc.mk | 7 +++++++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/package/libtirpc/Config.in b/package/libtirpc/Config.in
> index 31f1636ef5..e1ac9a4e7b 100644
> --- a/package/libtirpc/Config.in
> +++ b/package/libtirpc/Config.in
> @@ -16,6 +16,12 @@ config BR2_PACKAGE_LIBTIRPC_GSS
>  	help
>  	  Enable GSSAPI support
>  
> +config BR2_PACKAGE_LIBTIRPC_DB

Perhaps: BR2_PACKAGE_LIBTIRPC_RPCDB

> +	bool "db"

	bool "rpcdb"

> +	depends on BR2_PACKAGE_LIBTIRPC

Put the option inside a

if BR2_PACKAGE_LIBTIRPC

...

endif

block instead.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/2] package/libtirpc: introduce BR2_PACKAGE_LIBTIRPC_DB

[Petr Vorel]

Hi Giulio,

> Package libtirpc expose rpcdb so make it selectable.

LGTM.
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>

Kind regards,
Petr
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot