From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A2622772D for ; Sun, 14 Dec 2025 08:33:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765701184; cv=none; b=iM8VeqScPC3dpZFC1wUuPMJZu50RGwTyQ6t3SROVl4MJgVR5IjhdHYCiUECH44+DbwVBguFfTU4FgN207WiiBJyDu5cSGnbn2C59Bsmw2Smj5ncWi3u2cpFl09xVoggsePdHmlyN+slILwc+2u6g+6P2GzhgdzYPCi/da4tRwHU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765701184; c=relaxed/simple; bh=l82qoGMmhz0CvcMPkMqa904UaAm6YZkMweGjjbvzc9A=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=TpGaPleMYe81jXXmdCglsMuMJNF5wj87QVGhsfnPpLBJbYyByq2wpOL0gBAAY6P6bDncwp2ebLQcR/mDdFITBei2dTuw8B2wcjZOGxBv5tx0H8m2mFoxdG0upw7kagURcl0xzLlQsN5vPsHnVnKjwvd1wB1S8sOsDgbtGregGzE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=cgKw79B7; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="cgKw79B7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1765701183; x=1797237183; h=date:from:to:cc:subject:message-id:mime-version; bh=l82qoGMmhz0CvcMPkMqa904UaAm6YZkMweGjjbvzc9A=; b=cgKw79B70WjiILwWb3v4prGtf9kj85cRzcgGStSpnVV4OxHQzJyak6cs 7iQcTsrq32aZn4YFM/ZELopaRWr+E01fPkjKM1bWOxh0dc7uUyzFRY/eq Q2TIFX6gNUBl0Z+sm2ttYYFNs0rQlSOUBFMvT0jQekt1Vd7UFAFHTvRUz Vx5WYEy8lu5l6wJBFBp9PDVC9j4u37IYsWcyiiaYRULPqsD7wd32HLWa2 Q5nJFtrE6VQdAh4NlD2Qs3iwZRAOjOtXaScJfkbuK6h0cEb97r/BHJ3Rq JSJL6Ud40Kpjn1X0dVOf2fJPLSUkdHDzLXj52cxI2+iNE5ZIIM7lYQP5u A==; X-CSE-ConnectionGUID: JwUyrUEQSKOvVS9WCKSBgQ== X-CSE-MsgGUID: TeoQUKOsR6KAcQyBN+yt2g== X-IronPort-AV: E=McAfee;i="6800,10657,11641"; a="85047500" X-IronPort-AV: E=Sophos;i="6.21,148,1763452800"; d="scan'208";a="85047500" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2025 00:33:02 -0800 X-CSE-ConnectionGUID: +6J+5FdES3Os/dVuHE3DKg== X-CSE-MsgGUID: p7BAIP+QSqSdPw/QxGbfeA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,148,1763452800"; d="scan'208";a="197970012" Received: from lkp-server01.sh.intel.com (HELO d335e3c6db51) ([10.239.97.150]) by fmviesa009.fm.intel.com with ESMTP; 14 Dec 2025 00:33:00 -0800 Received: from kbuild by d335e3c6db51 with local (Exim 4.98.2) (envelope-from ) id 1vUhXG-000000008sP-19EM; Sun, 14 Dec 2025 08:32:58 +0000 Date: Sun, 14 Dec 2025 16:32:13 +0800 From: kernel test robot To: oe-kbuild@lists.linux.dev Cc: lkp@intel.com, Dan Carpenter Subject: drivers/net/phy/microchip_t1.c:1299 lan887x_phy_init() warn: 'priv->clock' can also be NULL Message-ID: <202512141607.90chDMzT-lkp@intel.com> Precedence: bulk X-Mailing-List: oe-kbuild@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline BCC: lkp@intel.com CC: oe-kbuild-all@lists.linux.dev CC: linux-kernel@vger.kernel.org TO: Divya Koppera CC: Jakub Kicinski tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 8f0b4cce4481fb22653697cced8d0d04027cb1e8 commit: 8541fc12edcdef36a02885672f22ca8391bd2443 net: phy: microchip_t1: Enable pin out specific to lan887x phy for PEROUT signal date: 11 months ago :::::: branch date: 4 hours ago :::::: commit date: 11 months ago config: sparc-randconfig-r072-20251213 (https://download.01.org/0day-ci/archive/20251214/202512141607.90chDMzT-lkp@intel.com/config) compiler: sparc64-linux-gcc (GCC) 15.1.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202512141607.90chDMzT-lkp@intel.com/ smatch warnings: drivers/net/phy/microchip_t1.c:1299 lan887x_phy_init() warn: 'priv->clock' can also be NULL vim +1299 drivers/net/phy/microchip_t1.c 0941c832823498 Divya Koppera 2024-08-21 1279 0941c832823498 Divya Koppera 2024-08-21 1280 static int lan887x_phy_init(struct phy_device *phydev) 0941c832823498 Divya Koppera 2024-08-21 1281 { 9fc3d6fe802923 Divya Koppera 2024-12-19 1282 struct lan887x_priv *priv = phydev->priv; 0941c832823498 Divya Koppera 2024-08-21 1283 int ret; 0941c832823498 Divya Koppera 2024-08-21 1284 9fc3d6fe802923 Divya Koppera 2024-12-19 1285 if (!priv->init_done && phy_interrupt_is_valid(phydev)) { 9fc3d6fe802923 Divya Koppera 2024-12-19 1286 priv->clock = mchp_rds_ptp_probe(phydev, MDIO_MMD_VEND1, 9fc3d6fe802923 Divya Koppera 2024-12-19 1287 MCHP_RDS_PTP_LTC_BASE_ADDR, 9fc3d6fe802923 Divya Koppera 2024-12-19 1288 MCHP_RDS_PTP_PORT_BASE_ADDR); 9fc3d6fe802923 Divya Koppera 2024-12-19 1289 if (IS_ERR(priv->clock)) 9fc3d6fe802923 Divya Koppera 2024-12-19 1290 return PTR_ERR(priv->clock); 9fc3d6fe802923 Divya Koppera 2024-12-19 1291 8541fc12edcdef Divya Koppera 2025-01-15 1292 /* Enable pin mux for EVT */ 8541fc12edcdef Divya Koppera 2025-01-15 1293 phy_modify_mmd(phydev, MDIO_MMD_VEND1, 8541fc12edcdef Divya Koppera 2025-01-15 1294 LAN887X_MX_CHIP_TOP_REG_CONTROL1, 8541fc12edcdef Divya Koppera 2025-01-15 1295 LAN887X_MX_CHIP_TOP_REG_CONTROL1_EVT_EN, 8541fc12edcdef Divya Koppera 2025-01-15 1296 LAN887X_MX_CHIP_TOP_REG_CONTROL1_EVT_EN); 8541fc12edcdef Divya Koppera 2025-01-15 1297 8541fc12edcdef Divya Koppera 2025-01-15 1298 /* Initialize pin numbers specific to PEROUT */ 8541fc12edcdef Divya Koppera 2025-01-15 @1299 priv->clock->event_pin = 3; 8541fc12edcdef Divya Koppera 2025-01-15 1300 9fc3d6fe802923 Divya Koppera 2024-12-19 1301 priv->init_done = true; 9fc3d6fe802923 Divya Koppera 2024-12-19 1302 } 9fc3d6fe802923 Divya Koppera 2024-12-19 1303 0941c832823498 Divya Koppera 2024-08-21 1304 /* Clear loopback */ 0941c832823498 Divya Koppera 2024-08-21 1305 ret = phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1, 0941c832823498 Divya Koppera 2024-08-21 1306 LAN887X_MIS_CFG_REG2, 0941c832823498 Divya Koppera 2024-08-21 1307 LAN887X_MIS_CFG_REG2_FE_LPBK_EN); 0941c832823498 Divya Koppera 2024-08-21 1308 if (ret < 0) 0941c832823498 Divya Koppera 2024-08-21 1309 return ret; 0941c832823498 Divya Koppera 2024-08-21 1310 0941c832823498 Divya Koppera 2024-08-21 1311 /* Configure default behavior of led to link and activity for any 0941c832823498 Divya Koppera 2024-08-21 1312 * speed 0941c832823498 Divya Koppera 2024-08-21 1313 */ 0941c832823498 Divya Koppera 2024-08-21 1314 ret = phy_modify_mmd(phydev, MDIO_MMD_VEND1, 0941c832823498 Divya Koppera 2024-08-21 1315 LAN887X_COMMON_LED3_LED2, 0941c832823498 Divya Koppera 2024-08-21 1316 LAN887X_COMMON_LED2_MODE_SEL_MASK, 0941c832823498 Divya Koppera 2024-08-21 1317 LAN887X_LED_LINK_ACT_ANY_SPEED); 0941c832823498 Divya Koppera 2024-08-21 1318 if (ret < 0) 0941c832823498 Divya Koppera 2024-08-21 1319 return ret; 0941c832823498 Divya Koppera 2024-08-21 1320 0941c832823498 Divya Koppera 2024-08-21 1321 /* PHY interface setup */ 0941c832823498 Divya Koppera 2024-08-21 1322 return lan887x_config_phy_interface(phydev); 0941c832823498 Divya Koppera 2024-08-21 1323 } 0941c832823498 Divya Koppera 2024-08-21 1324 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki