From: Andrew Morton <akpm@linux-foundation.org>
To: mm-commits@vger.kernel.org,urezki@gmail.com,anshuman.khandual@arm.com,jackmanb@google.com,akpm@linux-foundation.org
Subject: + mm-vmalloc-clarify-why-vmap_range_noflush-might-sleep.patch added to mm-unstable branch
Date: Mon, 15 Dec 2025 09:50:00 -0800 [thread overview]
Message-ID: <20251215175000.DD6C0C116B1@smtp.kernel.org> (raw)
The patch titled
Subject: mm/vmalloc: clarify why vmap_range_noflush() might sleep
has been added to the -mm mm-unstable branch. Its filename is
mm-vmalloc-clarify-why-vmap_range_noflush-might-sleep.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-vmalloc-clarify-why-vmap_range_noflush-might-sleep.patch
This patch will later appear in the mm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days
------------------------------------------------------
From: Brendan Jackman <jackmanb@google.com>
Subject: mm/vmalloc: clarify why vmap_range_noflush() might sleep
Date: Mon, 15 Dec 2025 10:40:25 +0000
The only reason vmap_range_noflush() can sleep is because of pagetable
allocations.
The actual allocation mechanism is arch-specific so might_alloc() doesn't
work here (what GFP flags would be used?). Hence, just add a comment.
Also note that this might do a TLB shootdown. This is not actually
sleeping but it requires IRQs on for x86, and might_sleep() incidentally
serves to detect violations of that too.
Link: https://lkml.kernel.org/r/20251215-b4-vmalloc-might_alloc-v3-1-92dd8e406868@google.com
Signed-off-by: Brendan Jackman <jackmanb@google.com>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: "Uladzislau Rezki (Sony)" <urezki@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/vmalloc.c | 5 +++++
1 file changed, 5 insertions(+)
--- a/mm/vmalloc.c~mm-vmalloc-clarify-why-vmap_range_noflush-might-sleep
+++ a/mm/vmalloc.c
@@ -305,6 +305,11 @@ static int vmap_range_noflush(unsigned l
int err;
pgtbl_mod_mask mask = 0;
+ /*
+ * Might allocate pagetables (for most archs a more precise annotation
+ * would be might_alloc(GFP_PGTABLE_KERNEL)). Also might shootdown TLB
+ * (requires IRQs enabled on x86).
+ */
might_sleep();
BUG_ON(addr >= end);
_
Patches currently in -mm which might be from jackmanb@google.com are
mm-vmalloc-clarify-why-vmap_range_noflush-might-sleep.patch
reply other threads:[~2025-12-15 17:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251215175000.DD6C0C116B1@smtp.kernel.org \
--to=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=jackmanb@google.com \
--cc=mm-commits@vger.kernel.org \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.