All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Perez de Castro <aperez@igalia.com>
To: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
Cc: buildroot@buildroot.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	 Raphael Pavlidis <raphael.pavlidis@gmail.com>
Subject: Re: [Buildroot] [PATCH 2/2] package/sway: properly propagate wlroots dependencies
Date: Tue, 16 Dec 2025 01:46:10 +0200	[thread overview]
Message-ID: <20251216014610.GD378927@igalia.com> (raw)
In-Reply-To: <20251215225837.1257574-2-thomas.petazzoni@bootlin.com>


[-- Attachment #1.1: Type: text/plain, Size: 1799 bytes --]

On Mon, 15 Dec 2025 23:58:36 +0100 Thomas Petazzoni via buildroot <buildroot@buildroot.org> wrote:
> Commit 00fb3a57cbaedb8df43f75f0e891423c1ef7d8c6 added a wlroots ->
> libgbm dependency, but forgot to propagate it to package/sway.
> 
> Cc: Raphael Pavlidis <raphael.pavlidis@gmail.com>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Reviewed-by: Adrian Perez de Castro <aperez@igalia.com>

> ---
>  package/sway/Config.in | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/package/sway/Config.in b/package/sway/Config.in
> index 1f4b497af3..1e4c8bfd3e 100644
> --- a/package/sway/Config.in
> +++ b/package/sway/Config.in
> @@ -5,6 +5,7 @@ config BR2_PACKAGE_SWAY
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # pango, wlroots
>  	depends on BR2_PACKAGE_HAS_LIBEGL # wlroots
>  	depends on BR2_PACKAGE_HAS_LIBGLES # wlroots
> +	depends on BR2_PACKAGE_HAS_LIBGBM # wlroots
>  	depends on BR2_PACKAGE_HAS_UDEV # wlroots
>  	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # json-c, pango
>  	depends on BR2_USE_WCHAR # pango
> @@ -53,11 +54,12 @@ config BR2_PACKAGE_SWAY_SWAYNAG
>  
>  endif # BR2_PACKAGE_SWAY
>  
> -comment "sway needs systemd, udev, EGL and OpenGL ES support"
> +comment "sway needs systemd, udev, EGL, OpenGL ES and GBM support"
>  	depends on !BR2_PACKAGE_SYSTEMD || \
>  		!BR2_PACKAGE_HAS_UDEV || \
>  		!BR2_PACKAGE_HAS_LIBEGL || \
> -		!BR2_PACKAGE_HAS_LIBGLES
> +		!BR2_PACKAGE_HAS_LIBGLES || \
> +		!BR2_PACKAGE_HAS_LIBGBM
>  
>  comment "sway needs a toolchain w/ wchar, threads, C++, dynamic library, gcc >= 4.9"
>  	depends on BR2_USE_MMU
> -- 
> 2.52.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
> 

Cheers,
—Adrián

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2025-12-15 23:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-15 22:58 [Buildroot] [PATCH 1/2] package/cage: properly propagate wlroots dependencies Thomas Petazzoni via buildroot
2025-12-15 22:58 ` [Buildroot] [PATCH 2/2] package/sway: " Thomas Petazzoni via buildroot
2025-12-15 23:46   ` Adrian Perez de Castro [this message]
2025-12-17 17:13   ` Raphael Pavlidis
2026-01-07 17:48   ` Arnout Vandecappelle via buildroot
2025-12-15 23:45 ` [Buildroot] [PATCH 1/2] package/cage: " Adrian Perez de Castro
2025-12-17 20:04 ` Julien Olivain via buildroot
2026-01-07 17:48 ` Arnout Vandecappelle via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251216014610.GD378927@igalia.com \
    --to=aperez@igalia.com \
    --cc=buildroot@buildroot.org \
    --cc=raphael.pavlidis@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.