From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 782852F0C76 for ; Mon, 15 Dec 2025 20:29:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765830565; cv=none; b=IRdqYvk1MukQ5JSDAqOgNZGy4gWQKa4fu0BlMo+WSOJchabH90j9CT4p3NMhduWRZ7hSVZfPCcpu01osvhdFhtnotYl/jwF6ZDC2HrKsSmLE3OtrkZ1u/eHJ1BULi/mMeOomZ1IeFkgKq1WksnGxcRoxWzqeKNuPtU7rPNMUbq8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765830565; c=relaxed/simple; bh=xK242mhSN6rSkPKU1r1RxCfO7XmE03iH790mX9/KG9c=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=mWDV/+Z+UoChMebTUAYqnu/L0v6E4JRM0MRydvsCtwd7byPmgIRtyIf0NEFtoYjskbbKKkShe6+B5jR3/X77p4YnmcDPoD26NBx3ZUJcuRFKOCarUdG2i6BMEnMOW/kCCJWBNggmDkragvWveWaHkkM/SGxYV7FwHPvdEUP2VEw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=T5WQ5Vrz; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="T5WQ5Vrz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1765830564; x=1797366564; h=date:from:to:cc:subject:message-id:mime-version; bh=xK242mhSN6rSkPKU1r1RxCfO7XmE03iH790mX9/KG9c=; b=T5WQ5Vrzqlt+ZTR+r278FNwKO+Wktiqotzkvrm86ghIG8r0xyJGm1v6c RHqxAtr4CWmtVVvhycmgJtdKakZ+nAmZ0duJErUKkNERVxmaMCMQIwsWx cpkJKKaDzNz0zhenYrxqCXNrkEpBuc4ZX5QZfHCC/9oKWNUpWDt4PtM7V IRXwbhf2fYINPLUnyckdJLzUk+ugwfQ4n1wAwZ59JrEcJtrOVtS8b6sJr 2o/AjOL97sOuG0ElD6aACbxGEI0ODcqjDDbLgoFYtDMQvt9jJAm7sX3t7 84Po/9e0/BhhJzPCdsPiMbul5skbjkQLwqkQ4AN8DPSu7Bo8HEAlg1/Mb w==; X-CSE-ConnectionGUID: dTEPQDtaTwaEtVNSVvTvhw== X-CSE-MsgGUID: GThkrGb1TfCm5Bq5PCd+PA== X-IronPort-AV: E=McAfee;i="6800,10657,11643"; a="67625262" X-IronPort-AV: E=Sophos;i="6.21,151,1763452800"; d="scan'208";a="67625262" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2025 12:29:20 -0800 X-CSE-ConnectionGUID: A/blzpFdQIenkcsYCU1OJg== X-CSE-MsgGUID: rs26dI87QFm+tXf5kqqB5w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,151,1763452800"; d="scan'208";a="197868246" Received: from lkp-server02.sh.intel.com (HELO 034c7e8e53c3) ([10.239.97.151]) by orviesa008.jf.intel.com with ESMTP; 15 Dec 2025 12:29:18 -0800 Received: from kbuild by 034c7e8e53c3 with local (Exim 4.98.2) (envelope-from ) id 1vVFBz-000000000jJ-1Ttd; Mon, 15 Dec 2025 20:29:15 +0000 Date: Tue, 16 Dec 2025 04:28:06 +0800 From: kernel test robot To: oe-kbuild@lists.linux.dev Cc: lkp@intel.com, Julia Lawall , Elena Reshetova Subject: fs/inode.c:1924:45-46: WARNING: atomic_add_unless Message-ID: <202512160420.AI5K5vHE-lkp@intel.com> Precedence: bulk X-Mailing-List: oe-kbuild@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline BCC: lkp@intel.com CC: oe-kbuild-all@lists.linux.dev CC: linux-kernel@vger.kernel.org TO: Josef Bacik CC: Christian Brauner CC: Mateusz Guzik tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 8f0b4cce4481fb22653697cced8d0d04027cb1e8 commit: 9e70e985bdc2c6fe7a160e4d59ddd7c0a39bc077 fs: rework iput logic date: 4 months ago :::::: branch date: 2 days ago :::::: commit date: 4 months ago config: i386-randconfig-052-20251215 (https://download.01.org/0day-ci/archive/20251216/202512160420.AI5K5vHE-lkp@intel.com/config) compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Julia Lawall | Closes: https://lore.kernel.org/r/202512160420.AI5K5vHE-lkp@intel.com/ cocci warnings: (new ones prefixed by >>) >> fs/inode.c:1924:45-46: WARNING: atomic_add_unless vim +1924 fs/inode.c ^1da177e4c3f41 Linus Torvalds 2005-04-16 1899 ^1da177e4c3f41 Linus Torvalds 2005-04-16 1900 /** ^1da177e4c3f41 Linus Torvalds 2005-04-16 1901 * iput - put an inode ^1da177e4c3f41 Linus Torvalds 2005-04-16 1902 * @inode: inode to put ^1da177e4c3f41 Linus Torvalds 2005-04-16 1903 * ^1da177e4c3f41 Linus Torvalds 2005-04-16 1904 * Puts an inode, dropping its usage count. If the inode use count hits ^1da177e4c3f41 Linus Torvalds 2005-04-16 1905 * zero, the inode is then freed and may also be destroyed. ^1da177e4c3f41 Linus Torvalds 2005-04-16 1906 * ^1da177e4c3f41 Linus Torvalds 2005-04-16 1907 * Consequently, iput() can sleep. ^1da177e4c3f41 Linus Torvalds 2005-04-16 1908 */ ^1da177e4c3f41 Linus Torvalds 2005-04-16 1909 void iput(struct inode *inode) ^1da177e4c3f41 Linus Torvalds 2005-04-16 1910 { 9e70e985bdc2c6 Josef Bacik 2025-08-26 1911 if (unlikely(!inode)) 0ae45f63d4ef8d Theodore Ts'o 2015-02-02 1912 return; 9e70e985bdc2c6 Josef Bacik 2025-08-26 1913 0ae45f63d4ef8d Theodore Ts'o 2015-02-02 1914 retry: 9e70e985bdc2c6 Josef Bacik 2025-08-26 1915 lockdep_assert_not_held(&inode->i_lock); 9e70e985bdc2c6 Josef Bacik 2025-08-26 1916 VFS_BUG_ON_INODE(inode->i_state & I_CLEAR, inode); 9e70e985bdc2c6 Josef Bacik 2025-08-26 1917 /* 9e70e985bdc2c6 Josef Bacik 2025-08-26 1918 * Note this assert is technically racy as if the count is bogusly 9e70e985bdc2c6 Josef Bacik 2025-08-26 1919 * equal to one, then two CPUs racing to further drop it can both 9e70e985bdc2c6 Josef Bacik 2025-08-26 1920 * conclude it's fine. 9e70e985bdc2c6 Josef Bacik 2025-08-26 1921 */ 9e70e985bdc2c6 Josef Bacik 2025-08-26 1922 VFS_BUG_ON_INODE(atomic_read(&inode->i_count) < 1, inode); 9e70e985bdc2c6 Josef Bacik 2025-08-26 1923 9e70e985bdc2c6 Josef Bacik 2025-08-26 @1924 if (atomic_add_unless(&inode->i_count, -1, 1)) 9e70e985bdc2c6 Josef Bacik 2025-08-26 1925 return; 9e70e985bdc2c6 Josef Bacik 2025-08-26 1926 9e70e985bdc2c6 Josef Bacik 2025-08-26 1927 if ((inode->i_state & I_DIRTY_TIME) && inode->i_nlink) { 0ae45f63d4ef8d Theodore Ts'o 2015-02-02 1928 trace_writeback_lazytime_iput(inode); 0ae45f63d4ef8d Theodore Ts'o 2015-02-02 1929 mark_inode_dirty_sync(inode); 0ae45f63d4ef8d Theodore Ts'o 2015-02-02 1930 goto retry; 0ae45f63d4ef8d Theodore Ts'o 2015-02-02 1931 } 9e70e985bdc2c6 Josef Bacik 2025-08-26 1932 9e70e985bdc2c6 Josef Bacik 2025-08-26 1933 spin_lock(&inode->i_lock); 9e70e985bdc2c6 Josef Bacik 2025-08-26 1934 if (unlikely((inode->i_state & I_DIRTY_TIME) && inode->i_nlink)) { 9e70e985bdc2c6 Josef Bacik 2025-08-26 1935 spin_unlock(&inode->i_lock); 9e70e985bdc2c6 Josef Bacik 2025-08-26 1936 goto retry; ^1da177e4c3f41 Linus Torvalds 2005-04-16 1937 } 9e70e985bdc2c6 Josef Bacik 2025-08-26 1938 9e70e985bdc2c6 Josef Bacik 2025-08-26 1939 if (!atomic_dec_and_test(&inode->i_count)) { 9e70e985bdc2c6 Josef Bacik 2025-08-26 1940 spin_unlock(&inode->i_lock); 9e70e985bdc2c6 Josef Bacik 2025-08-26 1941 return; 9e70e985bdc2c6 Josef Bacik 2025-08-26 1942 } 9e70e985bdc2c6 Josef Bacik 2025-08-26 1943 9e70e985bdc2c6 Josef Bacik 2025-08-26 1944 /* 9e70e985bdc2c6 Josef Bacik 2025-08-26 1945 * iput_final() drops ->i_lock, we can't assert on it as the inode may 9e70e985bdc2c6 Josef Bacik 2025-08-26 1946 * be deallocated by the time the call returns. 9e70e985bdc2c6 Josef Bacik 2025-08-26 1947 */ 9e70e985bdc2c6 Josef Bacik 2025-08-26 1948 iput_final(inode); ^1da177e4c3f41 Linus Torvalds 2005-04-16 1949 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 1950 EXPORT_SYMBOL(iput); ^1da177e4c3f41 Linus Torvalds 2005-04-16 1951 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki