From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2B6A342507; Tue, 16 Dec 2025 11:27:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765884449; cv=none; b=JGDPRL2qa9mEkbB5ynHWhmBERMUW+uE9jWYz4wM3jix4mbK++EIIuNu/ojx27voT3qtvAJ4iVsWD7ClnjrU8oGJRCMHWsaPtTDql6QVqPFMqv8PgbtTlM4umaSJlGh/BE5R+w7Ir0/zL2JKA4VRzfG88E0pvl6rPTlMmBcfGw44= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765884449; c=relaxed/simple; bh=qQ5ySyl+lIJnpdgYcu9GZwhZwg3a4ADzuhEXCKRZmHI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WpiOK/e0GQEM1Rl/MFfjRsutvFGah2lSVhMnl5w6DKpF+kncyxPjySdpNmKtjNbV3LQAhIKkvTTyyb9izcjZGrNN76VDspBFU3dt5g+CF/Z+KzrktRHUZW8+YVgj71n0XhesMSJ09C3DI/BcVyCvONpW1OyLMK5lZ/9s0jAIX98= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=bc+sT7i0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="bc+sT7i0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39532C4CEF1; Tue, 16 Dec 2025 11:27:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1765884449; bh=qQ5ySyl+lIJnpdgYcu9GZwhZwg3a4ADzuhEXCKRZmHI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bc+sT7i0uBiliR9RLsAQIFsYVGMWo4ax1/YSrNd9kcLMPNwBfSgLSmN9h873Wb6z7 8oiAKCRHIPdAXliHHNEspp1mro6hyzzyiM3U1GqhwHqdJiFWO+3BQEk6xYRjZvggmQ 9PZtOU3dDtgucH83xf3ZQWHa+oVV8tmofG/emTMQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Alexander Dahl , "Russell King (Oracle)" , =?UTF-8?q?Nuno=20S=C3=A1?= , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.12 197/354] net: phy: adin1100: Fix software power-down ready condition Date: Tue, 16 Dec 2025 12:12:44 +0100 Message-ID: <20251216111328.049621978@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251216111320.896758933@linuxfoundation.org> References: <20251216111320.896758933@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Alexander Dahl [ Upstream commit bccaf1fe08f2c9f96f6bc38391d41e67f6bf38e3 ] Value CRSM_SFT_PD written to Software Power-Down Control Register (CRSM_SFT_PD_CNTRL) is 0x01 and therefor different to value CRSM_SFT_PD_RDY (0x02) read from System Status Register (CRSM_STAT) for confirmation powerdown has been reached. The condition could have only worked when disabling powerdown (both 0x00), but never when enabling it (0x01 != 0x02). Result is a timeout, like so: $ ifdown eth0 macb f802c000.ethernet eth0: Link is Down ADIN1100 f802c000.ethernet-ffffffff:01: adin_set_powerdown_mode failed: -110 ADIN1100 f802c000.ethernet-ffffffff:01: adin_set_powerdown_mode failed: -110 Fixes: 7eaf9132996a ("net: phy: adin1100: Add initial support for ADIN1100 industrial PHY") Signed-off-by: Alexander Dahl Reviewed-by: Russell King (Oracle) Acked-by: Nuno Sá Link: https://patch.msgid.link/20251119124737.280939-2-ada@thorsis.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/phy/adin1100.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/adin1100.c b/drivers/net/phy/adin1100.c index 85f910e2d4fb2..918bb1cf7a4e7 100644 --- a/drivers/net/phy/adin1100.c +++ b/drivers/net/phy/adin1100.c @@ -201,7 +201,7 @@ static int adin_set_powerdown_mode(struct phy_device *phydev, bool en) return ret; return phy_read_mmd_poll_timeout(phydev, MDIO_MMD_VEND1, ADIN_CRSM_STAT, ret, - (ret & ADIN_CRSM_SFT_PD_RDY) == val, + !!(ret & ADIN_CRSM_SFT_PD_RDY) == en, 1000, 30000, true); } -- 2.51.0