From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB4973446A2; Tue, 16 Dec 2025 11:36:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765884991; cv=none; b=L9h0RbTVLkLNWBvQaljlj2w0/Q1TrmG6gTQa7CUK1q9gFys6sW1dfQsbnfhHPg0JYUFVFdykgPBkgLzQMCTMjyx5PH6pT1tcLqpcxXTGWG8AHJpPeYKhukisTLiAaNkxkkw7uCqMEbxHeb1l3luE4mQ3IYd0yl9RlNLiYyieaIY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765884991; c=relaxed/simple; bh=vkm+nx5Q0UhSu90bQYqHgYg79cfk1b7WSmewZ/tMEuk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=e3qG6Pb5O9xfMdJJRGrrDQ522IaubsW+R34HJO31WhNFgwj/aL34/APuEnm8Q9i7JcAgU46JM5lCt/zcht3QTSeuu9vpRRCkezYbZrEaNbh3kImSe6f8Nsp7WHdTOZywcr30XtiU7u7DDH3iq4BqFWx1be8ROKCJBrs6qhuWzWU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=sW/yAbfp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="sW/yAbfp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F039C4CEF5; Tue, 16 Dec 2025 11:36:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1765884991; bh=vkm+nx5Q0UhSu90bQYqHgYg79cfk1b7WSmewZ/tMEuk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sW/yAbfpdPXIe6sLiITIEfy8P7WbTCCUM/MH1qbskBW1o2XduvKwynM+EJkd0zlQG OSNe+cvfrADrz5h3x1g2sZPEhEF7m2mF7H8yv4FGBWIv6zxrIntTmrNM/lFpLwYMu+ VB9jtqwElvWVbY5IT7yxUMOs0STOmxCEBtubQxYc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yuhao Jiang , Junrui Luo , Takashi Sakamoto , Takashi Iwai Subject: [PATCH 6.12 353/354] ALSA: dice: fix buffer overflow in detect_stream_formats() Date: Tue, 16 Dec 2025 12:15:20 +0100 Message-ID: <20251216111333.698643429@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251216111320.896758933@linuxfoundation.org> References: <20251216111320.896758933@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Junrui Luo commit 324f3e03e8a85931ce0880654e3c3eb38b0f0bba upstream. The function detect_stream_formats() reads the stream_count value directly from a FireWire device without validating it. This can lead to out-of-bounds writes when a malicious device provides a stream_count value greater than MAX_STREAMS. Fix by applying the same validation to both TX and RX stream counts in detect_stream_formats(). Reported-by: Yuhao Jiang Reported-by: Junrui Luo Fixes: 58579c056c1c ("ALSA: dice: use extended protocol to detect available stream formats") Cc: stable@vger.kernel.org Reviewed-by: Takashi Sakamoto Signed-off-by: Junrui Luo Link: https://patch.msgid.link/SYBPR01MB7881B043FC68B4C0DA40B73DAFDCA@SYBPR01MB7881.ausprd01.prod.outlook.com Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/firewire/dice/dice-extension.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/sound/firewire/dice/dice-extension.c +++ b/sound/firewire/dice/dice-extension.c @@ -116,7 +116,7 @@ static int detect_stream_formats(struct break; base_offset += EXT_APP_STREAM_ENTRIES; - stream_count = be32_to_cpu(reg[0]); + stream_count = min_t(unsigned int, be32_to_cpu(reg[0]), MAX_STREAMS); err = read_stream_entries(dice, section_addr, base_offset, stream_count, mode, dice->tx_pcm_chs, @@ -125,7 +125,7 @@ static int detect_stream_formats(struct break; base_offset += stream_count * EXT_APP_STREAM_ENTRY_SIZE; - stream_count = be32_to_cpu(reg[1]); + stream_count = min_t(unsigned int, be32_to_cpu(reg[1]), MAX_STREAMS); err = read_stream_entries(dice, section_addr, base_offset, stream_count, mode, dice->rx_pcm_chs,