From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7B33344040; Tue, 16 Dec 2025 11:44:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765885482; cv=none; b=o7rFwQo+fXwbLYLfa8aGZRtT9jQTrhZiQMelH+OUChJ+Ww/JT23ptChOkMpEeQ3Bh1L7HpNiKXm1k8iIDI80iYekbp+aZd0U5HHvMktbAs/a3xQDqPmtg7sNu27SLVDzOPaRy62yuXgMoW8WU8mnEFZuxSncWoM6l1XJAU6YRLc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765885482; c=relaxed/simple; bh=EsxcCkvFMHE09d3eMzDZPYd2R8Z/tMtxecnJ6w0GRDE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RqkynM5k6P+PRt+DMd3CZDjVXAgHmPfNfh7C32t/njZ/S+aS6bZHkQ3Pej+wLDEdgzggYHyvpU5CLSv/oBS1jhSsxEQSiRu8FnjFWf8sXg/BqUUnpxHrpRclO/aNeU5xx44up+9xPAhtcVMaXVLWFORAEqk1+Z3/dUZqLDh0fag= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=b8+iVz4w; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="b8+iVz4w" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3CE37C4CEF1; Tue, 16 Dec 2025 11:44:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1765885482; bh=EsxcCkvFMHE09d3eMzDZPYd2R8Z/tMtxecnJ6w0GRDE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=b8+iVz4wA+y74BiYKb9Uy1GwmJIxMAT8p9ygf9mQnvlWPQ5Mtxitym0y2D9wPb9Ep wQcofXWW8Zik2dDJA7hHIN7HPeiIUOq03O/5JpWR8aUQKzNy+Ylgmn8VxxUxkvKgzk jNXvpI2bPCsrbrxlAC1LbTP1AtDgIGokfubaHKm4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Haotian Zhang , Sebastian Reichel , Sasha Levin Subject: [PATCH 6.17 152/507] power: supply: rt5033_charger: Fix device node reference leaks Date: Tue, 16 Dec 2025 12:09:53 +0100 Message-ID: <20251216111351.032314108@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251216111345.522190956@linuxfoundation.org> References: <20251216111345.522190956@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.17-stable review patch. If anyone has any objections, please let me know. ------------------ From: Haotian Zhang [ Upstream commit 6cdc4d488c2f3a61174bfba4e8cc4ac92c219258 ] The device node pointers `np_conn` and `np_edev`, obtained from of_parse_phandle() and of_get_parent() respectively, are not released. This results in a reference count leak. Add of_node_put() calls after the last use of these device nodes to properly release their references and fix the leaks. Fixes: 8242336dc8a8 ("power: supply: rt5033_charger: Add cable detection and USB OTG supply") Signed-off-by: Haotian Zhang Link: https://patch.msgid.link/20250929113234.1726-1-vulab@iscas.ac.cn Signed-off-by: Sebastian Reichel Signed-off-by: Sasha Levin --- drivers/power/supply/rt5033_charger.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/power/supply/rt5033_charger.c b/drivers/power/supply/rt5033_charger.c index 2fdc584397075..de724f23e453b 100644 --- a/drivers/power/supply/rt5033_charger.c +++ b/drivers/power/supply/rt5033_charger.c @@ -701,6 +701,8 @@ static int rt5033_charger_probe(struct platform_device *pdev) np_conn = of_parse_phandle(pdev->dev.of_node, "richtek,usb-connector", 0); np_edev = of_get_parent(np_conn); charger->edev = extcon_find_edev_by_node(np_edev); + of_node_put(np_edev); + of_node_put(np_conn); if (IS_ERR(charger->edev)) { dev_warn(charger->dev, "no extcon device found in device-tree\n"); goto out; -- 2.51.0