From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3787C359F8E; Tue, 16 Dec 2025 12:29:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765888162; cv=none; b=INDcIueC1koQxtuo85rkSbg4eFFhKKNzFiXCDhysXByvABb6cHZVgsb+Y3xS2/Ka8lVTtjSXEiCJ2Jmxbowm1hRM2mQuxny6XtU2p7GVpXeJAiMDY8dRQ25LELaBfrTzaWzGggeE7t3ybajRFM30RZ1Gg/yGNXxkWYpdMgtQyJQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765888162; c=relaxed/simple; bh=CDw/14saPEGZPu8Bf0GKhQrmf4pgVWYh/i5lINwAmeg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YZ7P74qdBYUMPPbakmGvznt4bbFEx3wDrKbij/Q7jSPpQpzQw0Haym2yaa4i+bpts/31U2E81Yn0LBLeYFZ6MxDR1skhtNyw8OiLChlistUioqgKZFs7okxvfmahL/Dd6l66r1So6o+8dWUae9xKJc5s/EgVbsqPfkg7/T0TnEE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ZxeOecic; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ZxeOecic" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99F0DC4CEF1; Tue, 16 Dec 2025 12:29:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1765888162; bh=CDw/14saPEGZPu8Bf0GKhQrmf4pgVWYh/i5lINwAmeg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZxeOecicEv/Xk3OgBq+/FyHocFavWaI7wCtNP56WcMlJb+eQ7nKirGsTlm98dap/N /d4GaZoB3xg6xfNM+dw1AW/5SZesqVe11Y4vqq7+PD+Htj6ZnR+H7I2LLCnKl7A9gM TltYYAPcJa80hdXGdRv9SA5ct7j1at7GhbpMlcak= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Guenter Roeck , Haotian Zhang , Sasha Levin Subject: [PATCH 6.18 450/614] hwmon: sy7636a: Fix regulator_enable resource leak on error path Date: Tue, 16 Dec 2025 12:13:37 +0100 Message-ID: <20251216111417.674022565@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251216111401.280873349@linuxfoundation.org> References: <20251216111401.280873349@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Haotian Zhang [ Upstream commit 2f88425ef590b7fcc2324334b342e048edc144a9 ] In sy7636a_sensor_probe(), regulator_enable() is called but if devm_hwmon_device_register_with_info() fails, the function returns without calling regulator_disable(), leaving the regulator enabled and leaking the reference count. Switch to devm_regulator_get_enable() to automatically manage the regulator resource. Fixes: de34a4053250 ("hwmon: sy7636a: Add temperature driver for sy7636a") Suggested-by: Guenter Roeck Signed-off-by: Haotian Zhang Link: https://lore.kernel.org/r/20251126162602.2086-1-vulab@iscas.ac.cn Signed-off-by: Guenter Roeck Signed-off-by: Sasha Levin --- drivers/hwmon/sy7636a-hwmon.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/hwmon/sy7636a-hwmon.c b/drivers/hwmon/sy7636a-hwmon.c index a12fc0ce70e76..d51daaf63d632 100644 --- a/drivers/hwmon/sy7636a-hwmon.c +++ b/drivers/hwmon/sy7636a-hwmon.c @@ -66,18 +66,13 @@ static const struct hwmon_chip_info sy7636a_chip_info = { static int sy7636a_sensor_probe(struct platform_device *pdev) { struct regmap *regmap = dev_get_regmap(pdev->dev.parent, NULL); - struct regulator *regulator; struct device *hwmon_dev; int err; if (!regmap) return -EPROBE_DEFER; - regulator = devm_regulator_get(&pdev->dev, "vcom"); - if (IS_ERR(regulator)) - return PTR_ERR(regulator); - - err = regulator_enable(regulator); + err = devm_regulator_get_enable(&pdev->dev, "vcom"); if (err) return err; -- 2.51.0