From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2C5D2DA74C; Tue, 16 Dec 2025 12:34:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765888486; cv=none; b=DMfknI/e/nXdCZN2UscCulAHtKOoJsJq6By7/wjlT4xeY2NfVKSVLOrTa2pPe3V4lSbmHNTOgW9GnCP5VD2M7UFCJko0zp+5UnpbXuhJXvtUGA4GgTtCni/gmDJRd3Q7PZWPqY83Hq4x23tmoZ+bJFqUvgs7q/PRAN/Irict0go= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765888486; c=relaxed/simple; bh=+tJCX/H+vnyRG4UYBYf3qWPWk0kE7CH2fkbxTy05YQI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aRmq1EftNYOwGcR5FRBJwrmVvthbCap3CpbaIjZAfMM4UkEt/GFLXbDlJJSE1FDRooczSRjbGIPpxT3We6sUAeYDNFV3ZHvg76nWRF9BfzLL1uWyXD8APcTeIZbHdXpn8Wj/OMvIDrJhEI0ik2pUzuDZ8aRBXE7kPeUTMudQqxs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=xaln4fC1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="xaln4fC1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 604DDC4CEF1; Tue, 16 Dec 2025 12:34:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1765888485; bh=+tJCX/H+vnyRG4UYBYf3qWPWk0kE7CH2fkbxTy05YQI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xaln4fC1EY9pTroR96k+geGM7lyNmbdkVVDg8dDHnZ3ki4EiILSYcH725OEAEGxIE ckO/HSJWJYnRtoQNWBsLzO1XQ9iGTXECZztDD6I/EEgNLP930gt2hFMzsErbfVSFrM VijuCkWva0z4dNnZAmHkaiOZJw9mLu3sLbIJUgWU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Alkis Georgopoulos , Li Lingfeng , Trond Myklebust , Sasha Levin Subject: [PATCH 6.18 548/614] Revert "nfs: clear SB_RDONLY before getting superblock" Date: Tue, 16 Dec 2025 12:15:15 +0100 Message-ID: <20251216111421.234991264@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251216111401.280873349@linuxfoundation.org> References: <20251216111401.280873349@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Trond Myklebust [ Upstream commit d216b698d44e33417ad4cc796cb04ccddbb8c0ee ] This reverts commit 8cd9b785943c57a136536250da80ba1eb6f8eb18. Silently ignoring the "ro" and "rw" mount options causes user confusion, and regressions. Reported-by: Alkis Georgopoulos Cc: Li Lingfeng Fixes: 8cd9b785943c ("nfs: clear SB_RDONLY before getting superblock") Signed-off-by: Trond Myklebust Signed-off-by: Sasha Levin --- fs/nfs/super.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/fs/nfs/super.c b/fs/nfs/super.c index 527000f5d150c..9b9464e70a7f0 100644 --- a/fs/nfs/super.c +++ b/fs/nfs/super.c @@ -1308,17 +1308,8 @@ int nfs_get_tree_common(struct fs_context *fc) if (IS_ERR(server)) return PTR_ERR(server); - /* - * When NFS_MOUNT_UNSHARED is not set, NFS forces the sharing of a - * superblock among each filesystem that mounts sub-directories - * belonging to a single exported root path. - * To prevent interference between different filesystems, the - * SB_RDONLY flag should be removed from the superblock. - */ if (server->flags & NFS_MOUNT_UNSHARED) compare_super = NULL; - else - fc->sb_flags &= ~SB_RDONLY; /* -o noac implies -o sync */ if (server->flags & NFS_MOUNT_NOAC) -- 2.51.0