From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 057CA37C11A; Tue, 16 Dec 2025 12:36:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765888597; cv=none; b=I8xD85srtLk1NCbyR8qY51umVdZFIfbzHeBIAOXkFIWsaXBH50LY4BtTTqmcSRHdjnWnMVvRmrXcQwIU/4jQrCgXdFOIi3RIgpcILYmBWAIMAFyMU4Gc/ngbChkoop6CUfZK8LmqL1pUokXJdHPZJaEZGU798IrxWSNgark1MRQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765888597; c=relaxed/simple; bh=yLF8SPy09RRIb2fnFSatR3E+KytTqyC/gUZL51miT8E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LHgohLb1JLIEuf5l1jIjBI7ohLmS6BhrZ7vMioD4Gp8PdATlp8ZMACIZqlUsR4TVQZ+7E+ByPoXRiyOgoQQY7Gi2ruZplQ38lvJEt5soY3Cq5HtRvpnKeiOtrUfUqI2Y//4UtDk1uvWKof44J7njcOUPSix2NDZAEwWkLUnn+Bg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=iFGC5wz3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="iFGC5wz3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 613FFC4CEF1; Tue, 16 Dec 2025 12:36:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1765888596; bh=yLF8SPy09RRIb2fnFSatR3E+KytTqyC/gUZL51miT8E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iFGC5wz3TidWE9JEhXFtm6atvz+xt5a1OiHL+sJXWzuOCJfNg8IbykNXQqHTsUoDz OpELbjnORhizqgM+d2pqfYmlMSWQmReTjq1kJlzpUBwS5GsgaK68RxIbf/A2ay7coJ W3agfJpB3dJX9r1L0ykH9/QOTd1KnQHcUJNzImdc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Nuno=20S=C3=A1?= , Alexandre Belloni , Sasha Levin Subject: [PATCH 6.18 581/614] rtc: max31335: Fix ignored return value in set_alarm Date: Tue, 16 Dec 2025 12:15:48 +0100 Message-ID: <20251216111422.438305072@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251216111401.280873349@linuxfoundation.org> References: <20251216111401.280873349@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nuno Sá [ Upstream commit f07640f9fb8df2158199da1da1f8282948385a84 ] Return the result from regmap_update_bits() instead of ignoring it and always returning 0. Fixes: dedaf03b99d6 ("rtc: max31335: add driver support") Signed-off-by: Nuno Sá Link: https://patch.msgid.link/20251128-max31335-handler-error-v1-1-6b6f7f78dbda@analog.com Signed-off-by: Alexandre Belloni Signed-off-by: Sasha Levin --- drivers/rtc/rtc-max31335.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-max31335.c b/drivers/rtc/rtc-max31335.c index dfb5bad3a3691..23b7bf16b4cd5 100644 --- a/drivers/rtc/rtc-max31335.c +++ b/drivers/rtc/rtc-max31335.c @@ -391,10 +391,8 @@ static int max31335_set_alarm(struct device *dev, struct rtc_wkalrm *alrm) if (ret) return ret; - ret = regmap_update_bits(max31335->regmap, max31335->chip->int_status_reg, - MAX31335_STATUS1_A1F, 0); - - return 0; + return regmap_update_bits(max31335->regmap, max31335->chip->int_status_reg, + MAX31335_STATUS1_A1F, 0); } static int max31335_alarm_irq_enable(struct device *dev, unsigned int enabled) -- 2.51.0