All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Laight <david.laight.linux@gmail.com>
To: Brendan Jackman <jackmanb@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	<linux-kernel@vger.kernel.org>, <kees@kernel.org>,
	<acarmina@redhat.com>, <jpoimboe@kernel.org>,
	<mark.rutland@arm.com>, <maciej.wieczor-retman@intel.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] bug: hush suggest-attribute=format for __warn_printf()
Date: Tue, 16 Dec 2025 12:36:47 +0000	[thread overview]
Message-ID: <20251216123647.22f81a16@pumpkin> (raw)
In-Reply-To: <DEZJ0FR59QNW.AP4SRYAQV8O5@google.com>

On Tue, 16 Dec 2025 09:16:41 +0000
Brendan Jackman <jackmanb@google.com> wrote:

...
> Given the kernel is usually W=1 clean, it seems like we _do_ support it.
> It's just that we support it via these akwkward retroactive fixups
> instead of just expecting code to be W=1-clean before we merge it?

It's not that W=1 clean, the bot remembers which warnings it has seen and
only reports new ones.

There are some entirely annoying ones that haven't been moved to W=2.
Some need fixing in the compiler, for instance:
int foo[] = { [0 ... 3 ] = -1, [2] = 1 };
(to change the default initialiser)
generates a warning because [2] is initialised twice.
Any attempt to 'fix' that is likely to leave an unexpected 0 entry.

The 'suggest-attribute-format' one used to give false positives on
some architectures (IIRC including x86) for some vprintf-like functions
because va_list is 'char *'.
That must not be true for kernel builds (any more).

	David

  reply	other threads:[~2025-12-16 12:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-07  3:53 [PATCH] bug: hush suggest-attribute=format for __warn_printf() Brendan Jackman
2025-12-08  8:38 ` Peter Zijlstra
2025-12-08  8:50   ` Brendan Jackman
2025-12-08  8:58     ` Peter Zijlstra
2025-12-09  9:16 ` [tip: core/urgent] bug: Hush " tip-bot2 for Brendan Jackman
2025-12-12  9:10 ` tip-bot2 for Brendan Jackman
2025-12-12  9:29 ` tip-bot2 for Brendan Jackman
2025-12-16  4:24 ` [PATCH] bug: hush " Andrew Morton
2025-12-16  8:49   ` Peter Zijlstra
2025-12-16  9:16     ` Brendan Jackman
2025-12-16 12:36       ` David Laight [this message]
2025-12-16 12:43         ` Brendan Jackman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251216123647.22f81a16@pumpkin \
    --to=david.laight.linux@gmail.com \
    --cc=acarmina@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=jackmanb@google.com \
    --cc=jpoimboe@kernel.org \
    --cc=kees@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maciej.wieczor-retman@intel.com \
    --cc=mark.rutland@arm.com \
    --cc=peterz@infradead.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.