From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB0D0385CB6 for ; Tue, 16 Dec 2025 12:36:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765888613; cv=none; b=teyy9j9rNv7sh3UBdoOLEMoN9l/DNVUoe6ZoGQpqqKbQAmX8uaQ26mWosxEYA2Vm6+wAKO2e/ScmQZB13XHgAyts5pv0qng2HofC/2CgHcMXhqQMBcZfLCM1EcgafVAYsR5ObTt0Oa5HgxwtVo78YhJiBMqsq4rZZWf3l4c7fZU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765888613; c=relaxed/simple; bh=IXkmoAT7lBN5yQ1Q1/GbM4Dx2SihajgqCXopGHK3cJ0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bjNjpM1M82SYN0P9ERkPLpzciw94lPvG6tHYBx7790FaL/Z8EIM9uFpZzhUGEeDGlKyqOmqF5T8a2Knx95T6SE1AvYmpK0Roic0N1Id+OB8glNDWB5SOMJmFEZysmsKl4LPMzeVo68G6+2r9AwIwau6IV7vXU+ecu6lRNvS88h0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N8ZE2MxM; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N8ZE2MxM" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4779ce2a624so49677855e9.2 for ; Tue, 16 Dec 2025 04:36:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765888610; x=1766493410; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=bsoWIW1acgf5BG0AdJcdESQ3ajZLJqz+SgAHLXa+eHs=; b=N8ZE2MxMouyRIDnZRhqtzkCJODEKj+q/B5nHRCRjJawl6PlmGKWxt9BleoxHcRE+rl FlszwP1i6+mPD98tR4hM/sXN52udZOBiarzK1wPJWLwrK5imopdgqLAbO8LbzVeqNOoR 2u8zqllrt9kagTN4VoUouSb9jXlsqK+jvLVG4BZCRqfgT5exh7aoICFUA+PWtd0omO6r Imf+n58Ty4+hNFaJjaTeQB3pA42idUZTnWw9OO4IpZee7wMZrvgP9C2sfw9/m6Hz/JpY TCMtcO17MUb19yg8bMzuNQNZNHv4G8Ux+y5DaayhxIkZ4RNAyi8ptoCd60ko6w32ztbA t6NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765888610; x=1766493410; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=bsoWIW1acgf5BG0AdJcdESQ3ajZLJqz+SgAHLXa+eHs=; b=bBw7acJqg+bmfrf5WO+22ozJCtk5JwiypGt38hHWRPx3UoAXRpHondlj2Iig3sPR1h WWrfVrjjgqhi4vvMv7TTNsDhJWDAAiBcBcbyJQE8EplnQrmM/lezEYX83WmfNzd4Cjb3 u+6B1LTHSVuXkHbufv27yvN0ZUgoq8vWrx0YWNyATaBUQ2a5Mj/9WoVJcUR8TDury+zU w9fajo6DY8BgLxd59a+oVforqpF7qRjIPL4DEGV/VkAnquxkxO87N/0H67u9MUoUdVLK aAflFgPwQ8epofJ3hdDWNCqJGw97rO/Yx+djlaPLW1I2A/O5JRuU0Rmen0W1GAaO5R90 EyIw== X-Forwarded-Encrypted: i=1; AJvYcCUPgN+0VhdsgwbGNJXE5gouiGp7bl6GzU4GqT95cxAljNEIA4hs9waluCIYiu7Y+F6ez3kNseyZNxpypXs=@vger.kernel.org X-Gm-Message-State: AOJu0YxZf3/Hn8MFRPQ85El1j4ltuMxTPMxUAfXFe8A4KfaObiy51b8M LU9Qq/AXQSp1sZjA/aApCkfQP1OmV4fbbTrkCtZnR7hpZQKinGcDhEYQ X-Gm-Gg: AY/fxX5xxh6q4P6pMlRgSqV+wnHKUW7HvcegrrToo3njKOdlYByIswziZoy/BMndWT9 ty20rpr1bXvhCLbGqUGEHrR3oi+N9Jk9hwPm5BsR9I8xsELr/1/eWqicb0GMZCv8CJWhc70qg9e IgAtoNBDt2/uIiEVd42COsFWR9ZnFou07wrE0N9IPL6m11feYKHH6CyNPtbWneMeZqauBEfuxNK tA+SXi9aB7lsiYZYcdnKBeVoDmom8Y24B8jucz2h2nmDN4qP06ZizaUq1QsLE9WPdJ9E2qSJpkf z4v4rOUX3FawNPdRGdMIiK3S0oAmUflrMSZt/zrMfz5imA647S8UaYpzOCUBidc/Bj0keq7HlBq rmO2wGBG6yZoQ0FI4+yNjMMpu1+nH1PHGHypxoUSg5LrHe5mNnqvVb9/k2OWuaV4r6SrlCq+JX9 rUWAzCtp/jndIDfFv194wBa5zeQ8ezRm+Tz7KUJSGEq6sS0yTpSwI4 X-Google-Smtp-Source: AGHT+IFLxdkGVodP6ZT2nU2vGZ8esNTchbsUDgulsk7YQUdJrMcG5yqB5IOw0c2J0qbyxycZJZjdjQ== X-Received: by 2002:a05:600c:45cb:b0:475:e007:bae0 with SMTP id 5b1f17b1804b1-47a8f8d2537mr192607075e9.16.1765888609827; Tue, 16 Dec 2025 04:36:49 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47bd9966f61sm7910925e9.20.2025.12.16.04.36.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Dec 2025 04:36:49 -0800 (PST) Date: Tue, 16 Dec 2025 12:36:47 +0000 From: David Laight To: Brendan Jackman Cc: Peter Zijlstra , Andrew Morton , , , , , , , Andy Shevchenko , Linus Torvalds Subject: Re: [PATCH] bug: hush suggest-attribute=format for __warn_printf() Message-ID: <20251216123647.22f81a16@pumpkin> In-Reply-To: References: <20251207-warn-printf-gcc-v1-1-b597d612b94b@google.com> <20251215202430.c35c2d29c4f9ff614d2ab534@linux-foundation.org> <20251216084949.GQ3707837@noisy.programming.kicks-ass.net> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 16 Dec 2025 09:16:41 +0000 Brendan Jackman wrote: ... > Given the kernel is usually W=1 clean, it seems like we _do_ support it. > It's just that we support it via these akwkward retroactive fixups > instead of just expecting code to be W=1-clean before we merge it? It's not that W=1 clean, the bot remembers which warnings it has seen and only reports new ones. There are some entirely annoying ones that haven't been moved to W=2. Some need fixing in the compiler, for instance: int foo[] = { [0 ... 3 ] = -1, [2] = 1 }; (to change the default initialiser) generates a warning because [2] is initialised twice. Any attempt to 'fix' that is likely to leave an unexpected 0 entry. The 'suggest-attribute-format' one used to give false positives on some architectures (IIRC including x86) for some vprintf-like functions because va_list is 'char *'. That must not be true for kernel builds (any more). David