All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Binbin Zhou <zhoubinbin@loongson.cn>
Cc: Yao Zi <me@ziyao.cc>, Binbin Zhou <zhoubb.aaron@gmail.com>,
	Huacai Chen <chenhuacai@loongson.cn>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Huacai Chen <chenhuacai@kernel.org>,
	Xuerui Wang <kernel@xen0n.name>,
	loongarch@lists.linux.dev, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/7] dt-bindings: interrupt-controller: loongson,pch-pic: Change to unevaluatedProperties
Date: Tue, 16 Dec 2025 10:16:41 -0600	[thread overview]
Message-ID: <20251216161641.GA2573095-robh@kernel.org> (raw)
In-Reply-To: <db24b6366bb0d49e9dcc04328ffad7a37f687a89.1765778124.git.zhoubinbin@loongson.cn>

On Tue, Dec 16, 2025 at 03:55:13PM +0800, Binbin Zhou wrote:
> Change additionalProperties to unevaluatedProperties because it refs to
> interrupt-controller.yaml.
> 
> Fix below CHECK_DTBS warnings:
> arch/loongarch/boot/dts/loongson-2k2000-ref.dtb: interrupt-controller@10000000 (loongson,pch-pic-1.0): '#address-cells' does not match any of the regexes: '^pinctrl-[0-9]+$'
>         from schema $id: http://devicetree.org/schemas/interrupt-controller/loongson,pch-pic.yaml
> 
> Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
> ---
>  .../bindings/interrupt-controller/loongson,pch-pic.yaml      | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/loongson,pch-pic.yaml b/Documentation/devicetree/bindings/interrupt-controller/loongson,pch-pic.yaml
> index b7bc5cb1dff2..1f818316082e 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/loongson,pch-pic.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/loongson,pch-pic.yaml
> @@ -14,6 +14,9 @@ description:
>    transforming interrupts from on-chip devices into HyperTransport vectorized
>    interrupts.
>  
> +allOf:
> +  - $ref: /schemas/interrupt-controller.yaml#

Adding this does not define the value(s) #address-cells must be. I'd 
assume it is 0 in this case.

> +
>  properties:
>    compatible:
>      const: loongson,pch-pic-1.0
> @@ -41,7 +44,7 @@ required:
>    - interrupt-controller
>    - '#interrupt-cells'
>  
> -additionalProperties: false
> +unevaluatedProperties: false
>  
>  examples:
>    - |
> -- 
> 2.47.3
> 

  reply	other threads:[~2025-12-16 16:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-16  7:54 [PATCH 0/7] LoongArch: DTS: Fix dtbs_check warnings Binbin Zhou
2025-12-16  7:54 ` [PATCH 1/7] dt-bindings: PCI: loongson: Document msi-parent property Binbin Zhou
2025-12-16  7:55 ` [PATCH 2/7] dt-bindings: interrupt-controller: loongson,pch-pic: Change to unevaluatedProperties Binbin Zhou
2025-12-16 16:16   ` Rob Herring [this message]
2025-12-17  7:17     ` Binbin Zhou
2025-12-16  7:55 ` [PATCH 3/7] LoongArch: dts: Describe PCI sideband IRQ through interrupt-extended Binbin Zhou
2025-12-16  7:56 ` [PATCH 4/7] LoongArch: dts: loongson-2k0500: Add default Extend I/O Interrupt controller address cells Binbin Zhou
2025-12-16  7:56 ` [PATCH 5/7] LoongArch: dts: loongson-2k1000: Add default Local " Binbin Zhou
2025-12-17  4:49   ` Huacai Chen
2025-12-16  7:56 ` [PATCH 6/7] LoongArch: dts: loongson-2k2000: Add default PCH PIC " Binbin Zhou
2025-12-16  7:56 ` [PATCH 7/7] LoongArch: dts: loongson-2k1000: Fix i2c-gpio node names Binbin Zhou
2025-12-16  9:44   ` Yao Zi
2025-12-16 16:24     ` Krzysztof Kozlowski
2025-12-16 16:25   ` Krzysztof Kozlowski
2025-12-16  9:31 ` [PATCH 0/7] LoongArch: DTS: Fix dtbs_check warnings Yao Zi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251216161641.GA2573095-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=chenhuacai@kernel.org \
    --cc=chenhuacai@loongson.cn \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@xen0n.name \
    --cc=krzk+dt@kernel.org \
    --cc=loongarch@lists.linux.dev \
    --cc=me@ziyao.cc \
    --cc=zhoubb.aaron@gmail.com \
    --cc=zhoubinbin@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.