From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7BA32D7386 for ; Tue, 16 Dec 2025 19:50:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765914607; cv=none; b=d0IuVODLFBPF5DsvP2G9Y3kx7X4kcqmg4tq33MsqyI5K7FoWqbY7bvcW4Szlvd9oZixXeZ3BISYb9wvFsLEkZsOKNnn+Hk9T60ldrr9ZfPxpE54RfC2DnHLGlU8d4au6qYSmPpO9e/xolA27SdgBVRPjB0Ym+FXUeoo1oL0Sb18= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765914607; c=relaxed/simple; bh=LhDaLeCZWsHCYax2twni8UOs0PGob8be0zMxM5OeaYY=; h=Date:To:From:Subject:Message-Id; b=tkdx9UsNCGcZxnTwxsCgxEvTOzAd0X3YdSxfDC+ds1JJxEEyYts8u2UHClKc/bXgBaSLvoLTcsxqJZVZ5pUzzCyd0+l+WHxh6QZ3Mx0Uj1FDDoLbUbNf4lgNmwSNxNQPPT9WWAwj7SKzH77ZKsUOk2I+PI5zACib1gBRhS86DNc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=RPyDQoGC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="RPyDQoGC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C59AC4CEF1; Tue, 16 Dec 2025 19:50:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1765914606; bh=LhDaLeCZWsHCYax2twni8UOs0PGob8be0zMxM5OeaYY=; h=Date:To:From:Subject:From; b=RPyDQoGCi6zcPJpdvIoPnSJs5F4ElZCL3sqyVpWB/4PbFnzlDyYd6BgkWjon4b6hL DGJWaTrYAi0+8LdSCudfVYMLcLCHLRS7A67peGlfRp9barC7R6bo2kF/bWzhVwYhNV J27mel7Is+WJ4CLdXM9SRf6GI+HMvH9Nj99/K5NM= Date: Tue, 16 Dec 2025 11:50:05 -0800 To: mm-commits@vger.kernel.org,ysato@users.sourceforge.jp,yonghong.song@linux.dev,will@kernel.org,stefan.kristiansson@saunalahti.fi,song@kernel.org,shorne@gmail.com,sdf@fomichev.me,peterz@infradead.org,martin.lau@linux.dev,mark.rutland@arm.com,kpsingh@kernel.org,jonas@southpole.se,jolsa@kernel.org,john.fastabend@gmail.com,haoluo@google.com,guoren@kernel.org,glaubitz@physik.fu-berlin.de,geert@linux-m68k.org,gary@garyguo.net,eddyz87@gmail.com,dinguyen@kernel.org,daniel@iogearbox.net,dalias@libc.org,boqun.feng@gmail.com,ast@kernel.org,arnd@arndb.de,andrii@kernel.org,fthain@linux-m68k.org,akpm@linux-foundation.org From: Andrew Morton Subject: + atomic-add-option-for-weaker-alignment-check.patch added to mm-nonmm-unstable branch Message-Id: <20251216195006.2C59AC4CEF1@smtp.kernel.org> Precedence: bulk X-Mailing-List: mm-commits@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: The patch titled Subject: atomic: add option for weaker alignment check has been added to the -mm mm-nonmm-unstable branch. Its filename is atomic-add-option-for-weaker-alignment-check.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/atomic-add-option-for-weaker-alignment-check.patch This patch will later appear in the mm-nonmm-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via various branches at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there most days ------------------------------------------------------ From: Finn Thain Subject: atomic: add option for weaker alignment check Date: Tue, 16 Dec 2025 17:31:05 +1100 Add a new Kconfig symbol to make CONFIG_DEBUG_ATOMIC more useful on those architectures which do not align dynamic allocations to 8-byte boundaries. Without this, CONFIG_DEBUG_ATOMIC produces excessive WARN splats. Link: https://lkml.kernel.org/r/ff38f3d6c7a3e5b8c680013de15540f3ef903522.1765866665.git.fthain@linux-m68k.org Signed-off-by: Finn Thain Cc: Alexei Starovoitov Cc: Andrii Nakryiko Cc: Arnd Bergmann Cc: Boqun Feng Cc: Daniel Borkman Cc: Dinh Nguyen Cc: Eduard Zingerman Cc: Gary Guo Cc: Geert Uytterhoeven Cc: Guo Ren Cc: Hao Luo Cc: Jiri Olsa Cc: John Fastabend Cc: John Paul Adrian Glaubitz Cc: Jonas Bonn Cc: KP Singh Cc: Marc Rutland Cc: Martin KaFai Lau Cc: Peter Zijlstra Cc: Rich Felker Cc: Song Liu Cc: Stafford Horne Cc: Stanislav Fomichev Cc: Stefan Kristiansson Cc: Will Deacon Cc: Yonghong Song Cc: Yoshinori Sato Signed-off-by: Andrew Morton --- include/linux/instrumented.h | 17 ++++++++++++++--- lib/Kconfig.debug | 8 ++++++++ 2 files changed, 22 insertions(+), 3 deletions(-) --- a/include/linux/instrumented.h~atomic-add-option-for-weaker-alignment-check +++ a/include/linux/instrumented.h @@ -56,6 +56,17 @@ static __always_inline void instrument_r kcsan_check_read_write(v, size); } +static __always_inline void instrument_atomic_check_alignment(const volatile void *v, size_t size) +{ + if (IS_ENABLED(CONFIG_DEBUG_ATOMIC)) { + unsigned int mask = size - 1; + + if (IS_ENABLED(CONFIG_DEBUG_ATOMIC_LARGEST_ALIGN)) + mask &= sizeof(struct { long x; } __aligned_largest) - 1; + WARN_ON_ONCE((unsigned long)v & mask); + } +} + /** * instrument_atomic_read - instrument atomic read access * @v: address of access @@ -68,7 +79,7 @@ static __always_inline void instrument_a { kasan_check_read(v, size); kcsan_check_atomic_read(v, size); - WARN_ON_ONCE(IS_ENABLED(CONFIG_DEBUG_ATOMIC) && ((unsigned long)v & (size - 1))); + instrument_atomic_check_alignment(v, size); } /** @@ -83,7 +94,7 @@ static __always_inline void instrument_a { kasan_check_write(v, size); kcsan_check_atomic_write(v, size); - WARN_ON_ONCE(IS_ENABLED(CONFIG_DEBUG_ATOMIC) && ((unsigned long)v & (size - 1))); + instrument_atomic_check_alignment(v, size); } /** @@ -98,7 +109,7 @@ static __always_inline void instrument_a { kasan_check_write(v, size); kcsan_check_atomic_read_write(v, size); - WARN_ON_ONCE(IS_ENABLED(CONFIG_DEBUG_ATOMIC) && ((unsigned long)v & (size - 1))); + instrument_atomic_check_alignment(v, size); } /** --- a/lib/Kconfig.debug~atomic-add-option-for-weaker-alignment-check +++ a/lib/Kconfig.debug @@ -1370,6 +1370,14 @@ config DEBUG_ATOMIC This option has potentially significant overhead. +config DEBUG_ATOMIC_LARGEST_ALIGN + bool "Check alignment only up to __aligned_largest" + depends on DEBUG_ATOMIC + help + If you say Y here then the check for natural alignment of + atomic accesses will be constrained to the compiler's largest + alignment for scalar types. + menu "Lock Debugging (spinlocks, mutexes, etc...)" config LOCK_DEBUGGING_SUPPORT _ Patches currently in -mm which might be from fthain@linux-m68k.org are bpf-explicitly-align-bpf_res_spin_lock.patch atomic-specify-alignment-for-atomic_t-and-atomic64_t.patch atomic-add-option-for-weaker-alignment-check.patch