From: Jason Gunthorpe <jgg@nvidia.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Leon Romanovsky <leon@kernel.org>,
Or Har-Toov <ohartoov@nvidia.com>,
Vlad Dumitrescu <vdumitrescu@nvidia.com>,
Mark Zhang <markzhang@nvidia.com>, Arnd Bergmann <arnd@arndb.de>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/ucma: fix rdma_ucm_query_ib_service_resp struct padding
Date: Tue, 16 Dec 2025 21:45:52 -0400 [thread overview]
Message-ID: <20251217014552.GC148079@nvidia.com> (raw)
In-Reply-To: <20251208133311.313977-1-arnd@kernel.org>
On Mon, Dec 08, 2025 at 02:33:05PM +0100, Arnd Bergmann wrote:
> diff --git a/include/uapi/rdma/rdma_user_cm.h b/include/uapi/rdma/rdma_user_cm.h
> index 5ded174687ee..8e1d584f6633 100644
> --- a/include/uapi/rdma/rdma_user_cm.h
> +++ b/include/uapi/rdma/rdma_user_cm.h
> @@ -192,6 +192,7 @@ struct rdma_ucm_query_path_resp {
>
> struct rdma_ucm_query_ib_service_resp {
> __u32 num_service_recs;
> + __u32 :32;
> struct ib_user_service_rec recs[];
> };
RDMA doesn't use bitfields here, I changed these to be reserved like
the others.
> @@ -362,6 +363,7 @@ struct rdma_ucm_ib_service {
>
> struct rdma_ucm_resolve_ib_service {
> __u32 id;
> + __u32 :32;
> struct rdma_ucm_ib_service ibs;
> };
And I added the missing
struct rdma_ucm_ib_service {
- __u64 service_id;
+ __aligned_u64 service_id;
Again, like the others.
Applied to for-rc thanks
Jason
prev parent reply other threads:[~2025-12-17 1:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-08 13:33 [PATCH] RDMA/ucma: fix rdma_ucm_query_ib_service_resp struct padding Arnd Bergmann
2025-12-17 1:45 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251217014552.GC148079@nvidia.com \
--to=jgg@nvidia.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=markzhang@nvidia.com \
--cc=ohartoov@nvidia.com \
--cc=vdumitrescu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.