From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [PATCH i-g-t 02/11] lib/kms: Nuke 'n_planes' from igt_crtc_init()
Date: Wed, 17 Dec 2025 17:37:48 +0200 [thread overview]
Message-ID: <20251217153758.9369-3-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20251217153758.9369-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
The 'n_planes' varaible is essentially just a duplicate of
'pipe->n_planes'. Get rid of the copy and just populate the
real thing early.
Having less variables around will help with carving up
igt_crtc_init() further.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
lib/igt_kms.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 4993d4db8a8a..082934e4e216 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -3059,7 +3059,7 @@ static void igt_crtc_init(igt_display_t *display,
igt_plane_t *plane;
int p = 1, crtc_mask = 0;
int j, type;
- uint8_t last_plane = 0, n_planes = 0;
+ uint8_t last_plane = 0;
pipe->display = display;
pipe->plane_cursor = -1;
@@ -3078,13 +3078,14 @@ static void igt_crtc_init(igt_display_t *display,
igt_assert(drm_plane);
if (drm_plane->possible_crtcs & crtc_mask)
- n_planes++;
+ pipe->n_planes++;
}
- igt_assert_lt(0, n_planes);
- pipe->planes = calloc(n_planes, sizeof(igt_plane_t));
- igt_assert_f(pipe->planes, "Failed to allocate memory for %d planes\n", n_planes);
- last_plane = n_planes - 1;
+ igt_assert_lt(0, pipe->n_planes);
+ pipe->planes = calloc(pipe->n_planes, sizeof(igt_plane_t));
+ igt_assert_f(pipe->planes, "Failed to allocate memory for %d planes\n",
+ pipe->n_planes);
+ last_plane = pipe->n_planes - 1;
/* add the planes that can be used with that pipe */
for (j = 0; j < display->n_planes; j++) {
@@ -3118,7 +3119,8 @@ static void igt_crtc_init(igt_display_t *display,
plane->index = p++;
}
- igt_assert_f(plane->index < n_planes, "n_planes < plane->index failed\n");
+ igt_assert_f(plane->index < pipe->n_planes,
+ "n_planes < plane->index failed\n");
plane->type = type;
plane->pipe = pipe;
plane->drm_plane = drm_plane;
@@ -3147,9 +3149,7 @@ static void igt_crtc_init(igt_display_t *display,
if (display->has_cursor_plane)
igt_assert_eq(p, last_plane);
else
- igt_assert_eq(p, n_planes);
-
- pipe->n_planes = n_planes;
+ igt_assert_eq(p, pipe->n_planes);
}
/**
--
2.51.2
next prev parent reply other threads:[~2025-12-17 15:38 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-17 15:37 [PATCH i-g-t 00/11] lib/kms: Carve up igt_display_require() Ville Syrjala
2025-12-17 15:37 ` [PATCH i-g-t 01/11] lib/kms: Extract igt_crtc_init() Ville Syrjala
2025-12-17 19:04 ` Jani Nikula
2025-12-17 15:37 ` Ville Syrjala [this message]
2025-12-17 19:11 ` [PATCH i-g-t 02/11] lib/kms: Nuke 'n_planes' from igt_crtc_init() Jani Nikula
2025-12-17 15:37 ` [PATCH i-g-t 03/11] lib/kms: Nuke 'last_plane' " Ville Syrjala
2025-12-17 19:12 ` Jani Nikula
2025-12-17 15:37 ` [PATCH i-g-t 04/11] lib/kms: Get rid of the 'p' plane index variable Ville Syrjala
2025-12-17 19:17 ` Jani Nikula
2025-12-18 11:33 ` Jani Nikula
2025-12-18 15:47 ` [PATCH i-g-t v2 " Ville Syrjala
2025-12-19 10:55 ` Jani Nikula
2025-12-17 15:37 ` [PATCH i-g-t 05/11] lib/kms: Extract igt_crtc_plane_init() Ville Syrjala
2025-12-17 19:18 ` Jani Nikula
2025-12-18 15:48 ` [PATCH i-g-t v2 " Ville Syrjala
2025-12-17 15:37 ` [PATCH i-g-t 06/11] lib/kms: Nuke pipe->plane_primary Ville Syrjala
2025-12-18 11:37 ` Jani Nikula
2025-12-17 15:37 ` [PATCH i-g-t 07/11] lib/kms: Nuke pipe->plane_cursor Ville Syrjala
2025-12-18 11:39 ` Jani Nikula
2025-12-17 15:37 ` [PATCH i-g-t 08/11] lib/kms: Use '{old, new}_primary' variable names in plane swapping Ville Syrjala
2025-12-17 19:20 ` Jani Nikula
2025-12-17 15:37 ` [PATCH i-g-t 09/11] lib/kms: Pimp the priamry " Ville Syrjala
2025-12-19 12:00 ` Jani Nikula
2025-12-17 15:37 ` [PATCH i-g-t 10/11] lib/kms: Extract plane_type_index() Ville Syrjala
2025-12-19 12:08 ` Jani Nikula
2025-12-17 15:37 ` [PATCH i-g-t 11/11] lib/kms: Streamline plane index handling further Ville Syrjala
2025-12-19 12:10 ` Jani Nikula
2025-12-17 20:36 ` ✗ Xe.CI.BAT: failure for lib/kms: Carve up igt_display_require() Patchwork
2025-12-17 21:00 ` ✗ i915.CI.BAT: " Patchwork
2025-12-18 20:21 ` ✗ Xe.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251217153758.9369-3-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.