All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Nirmoy Das <nirmoyd@nvidia.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	Robin Murphy <robin.murphy@arm.com>,
	Will Deacon <will@kernel.org>, Joerg Roedel <joro@8bytes.org>,
	iommu@lists.linux.dev, jammy_huang@aspeedtech.com,
	mochs@nvidia.com
Subject: Re: [PATCH v2 2/2] PCI: Add PCI_BRIDGE_NO_ALIASES quirk for ASPEED AST1150
Date: Wed, 17 Dec 2025 12:01:33 -0400	[thread overview]
Message-ID: <20251217160133.GQ6079@nvidia.com> (raw)
In-Reply-To: <20251217154529.377586-2-nirmoyd@nvidia.com>

On Wed, Dec 17, 2025 at 07:45:29AM -0800, Nirmoy Das wrote:
> ASPEED BMC controllers have VGA and USB functions behind a PCIe-to-PCI
> bridge that causes them to share the same stream ID:
> 
>   [e0]---00.0-[e1-e2]----00.0-[e2]--+-00.0  ASPEED Graphics Family
>                                     \-02.0  ASPEED USB Controller
> 
> Both devices get stream ID 0x5e200 due to bridge aliasing, causing the
> USB controller to be rejected with 'Aliasing StreamID unsupported'.
> 
> Per ASPEED, the AST1150 doesn't use a real PCI bus and always forwards
> the original requester ID from downstream devices rather than replacing
> it with any alias.
> 
> Add a new PCI_DEV_FLAGS_PCI_BRIDGE_NO_ALIASES flag and apply it to the
> AST1150.
> 
> Suggested-by: Jason Gunthorpe <jgg@nvidia.com>
> Signed-off-by: Nirmoy Das <nirmoyd@nvidia.com>
> ---
> v2:
>   - Use new PCI_DEV_FLAGS_PCI_BRIDGE_NO_ALIASES flag instead of
>     PCI_DEV_FLAGS_BRIDGE_XLATE_ROOT to only skip aliasing at this
>     bridge, not stop the entire upstream alias walk (Jason Gunthorpe)
> 
>  drivers/pci/quirks.c | 10 ++++++++++
>  drivers/pci/search.c |  2 ++
>  include/linux/pci.h  |  5 +++++
>  3 files changed, 17 insertions(+)

I bet there will be more aspeed devices to come, but this is a
reasonable start

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Thanks,
Jason

  reply	other threads:[~2025-12-17 16:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-17 15:45 [PATCH v2 1/2] PCI: Add ASPEED vendor ID to pci_ids.h Nirmoy Das
2025-12-17 15:45 ` [PATCH v2 2/2] PCI: Add PCI_BRIDGE_NO_ALIASES quirk for ASPEED AST1150 Nirmoy Das
2025-12-17 16:01   ` Jason Gunthorpe [this message]
2025-12-17 18:07   ` Robin Murphy
2025-12-18 14:15     ` Nirmoy Das
2025-12-17 15:47 ` [PATCH v2 1/2] PCI: Add ASPEED vendor ID to pci_ids.h Jason Gunthorpe
2026-01-09 19:29 ` Nirmoy Das
2026-01-09 20:26 ` Bjorn Helgaas
2026-01-09 20:54   ` Nirmoy Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251217160133.GQ6079@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=bhelgaas@google.com \
    --cc=iommu@lists.linux.dev \
    --cc=jammy_huang@aspeedtech.com \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mochs@nvidia.com \
    --cc=nirmoyd@nvidia.com \
    --cc=robin.murphy@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.