Re: [PATCH rdma-next v5 3/4] RDMA/bnxt_re: Direct Verbs: Support DBR verbs

[Jason Gunthorpe <jgg@nvidia.com>]

On Sat, Nov 29, 2025 at 10:24:40PM +0530, Sriharsha Basavapatna wrote:
> +DECLARE_UVERBS_NAMED_METHOD(BNXT_RE_METHOD_DBR_QUERY,
> +			    UVERBS_ATTR_PTR_OUT(BNXT_RE_DV_QUERY_DBR_ATTR,
> +						UVERBS_ATTR_STRUCT(struct bnxt_re_dv_db_region,
> +								   dbr),
> +						UA_MANDATORY));
> +
> +DECLARE_UVERBS_NAMED_METHOD_DESTROY(BNXT_RE_METHOD_DBR_FREE,
> +				    UVERBS_ATTR_IDR(BNXT_RE_DV_FREE_DBR_HANDLE,
> +						    BNXT_RE_OBJECT_DBR,
> +						    UVERBS_ACCESS_DESTROY,
> +						    UA_MANDATORY));
> +
> +DECLARE_UVERBS_NAMED_OBJECT(BNXT_RE_OBJECT_DBR,
> +			    UVERBS_TYPE_ALLOC_IDR(bnxt_re_dv_dbr_cleanup),
> +			    &UVERBS_METHOD(BNXT_RE_METHOD_DBR_ALLOC),
> +			    &UVERBS_METHOD(BNXT_RE_METHOD_DBR_FREE),
> +			    &UVERBS_METHOD(BNXT_RE_METHOD_DBR_QUERY));

This is not a "method" on an object because it doesn't accept any
object ID as an argument. This is just a global function, so it should
be using DECLARE_UVERBS_GLOBAL_METHODS().

It should probably also have a clearer name that it is about returning
the ucontext's DBR.

>  /* DPIs */
> +int bnxt_qplib_alloc_uc_dpi(struct bnxt_qplib_res *res, struct bnxt_qplib_dpi *dpi)
> +{
> +	struct bnxt_qplib_dpi_tbl *dpit = &res->dpi_tbl;
> +	struct bnxt_qplib_reg_desc *reg;
> +	u32 bit_num;
> +	int rc = 0;
> +
> +	reg = &dpit->wcreg;
> +	mutex_lock(&res->dpi_tbl_lock);
> +	bit_num = find_first_bit(dpit->tbl, dpit->max);
> +	if (bit_num >= dpit->max) {
> +		rc = -ENOMEM;
> +		goto unlock;
> +	}
> +	/* Found unused DPI */
> +	clear_bit(bit_num, dpit->tbl);

Stuff like this should be implemented as an ida..

Jason