From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6179219D071 for ; Thu, 18 Dec 2025 08:54:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766048094; cv=none; b=JvfVA4NNs3Rm1sjfLD0lr1VbNN42gkq0z9vV9IjcNlJbF+qZkKx6+XIEaoNaIcFuDSwG3pKj9T1+QtvXVXFZqtMorYnQBCuTuxqNSpmaRoOabWYdXLsDJ7oLTrLLgXWtxIdDX/GY+sqiWtoiHxk8FnCtFsu+biSQoBxayeRVoKA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766048094; c=relaxed/simple; bh=gsRGf++nu844nnp4eug1sC+iAAl0JUR8Xjz4R0G0b2Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=A0lBu2qTPplQIM0fMgowdUTYLVS79Hi56SegjQZcCDuZ4j2YXu8qi0Q4TBM5lN/F51QMtV95a2+62yqN4L9ACN6GSR2h0HZwamhkPZaLSjv6iZV9TWObadkf0lCOyORIJDaKDk04KEgcWJCj/iacBtLCo3tYlXfA18evjy6ZO14= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=sFjdab/3; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="sFjdab/3" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=BNeeY42bJIB+5Bd62T4W5bsub72nnE6oq+P0uCFgb90=; b=sFjdab/3/t7P3iHkrTelDaSEaU OaIw5WyxYgUoe3llY9JOalytBhc8KucDu9B6yGPjskNOY84p9Da4w3Oc4ApdEgrVSVlq6kDAPhhHt 7sHj9AnDyEKmucs3Ht75LViEfHR0H5NDUuEbEpin1Zgaq6w9CGIlNwLRf6/51v36fxm+PGyXaHMR3 wv7d8nAOSJ9mjn9X+pCPd7orLMjNA2Aw6xDlYTxreiWTbvOBYWeGed4SnN0xSkm+Lf3XhKEBNW8FI P4KdO6KvI5CPmGMKk7IBoZb77hcwHnQhhSuIB5qUgT/sxRIJdRknEazaTAmicSG0RMjZeZZvWfEj4 fFZ8eY8g==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1vW9ma-00000005sUZ-3eN5; Thu, 18 Dec 2025 08:54:49 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id AC5CB30056B; Thu, 18 Dec 2025 09:54:47 +0100 (CET) Date: Thu, 18 Dec 2025 09:54:47 +0100 From: Peter Zijlstra To: Uros Bizjak Cc: Jean Delvare , LKML , Josh Poimboeuf , ardb@kernel.org, Linus Torvalds , x86@kernel.org Subject: Re: Build breakage caused by the use of UDB Message-ID: <20251218085447.GJ3707891@noisy.programming.kicks-ass.net> References: <20251217124119.5832bba7@endymion> <20251217123536.GE3707891@noisy.programming.kicks-ass.net> <20251217124713.GD3708021@noisy.programming.kicks-ass.net> <20251217130204.GE3708021@noisy.programming.kicks-ass.net> <20251217133431.GF3708021@noisy.programming.kicks-ass.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Dec 17, 2025 at 03:39:07PM +0100, Uros Bizjak wrote: > > > What's worse, it only sometimes does this: > > > > > > $ grep ".byte[ ]*0x0f" defconfig-build/drivers/net/wireless/realtek/rtlwifi/base.s > > > 1: .byte0x0f,0x0b ; > > > 1: .byte 0x0f,0x0b ; > > > > > > W.T.F. and all that. > How about the attached patch that ensures that separator survives > macro expansion? Right, I think I tried that, it doesn't like things like retpoline.S > diff --git a/arch/x86/include/asm/asm.h b/arch/x86/include/asm/asm.h > index 0e8c611bc9e2..76d2eb96dd49 100644 > --- a/arch/x86/include/asm/asm.h > +++ b/arch/x86/include/asm/asm.h > @@ -17,7 +17,7 @@ > # define __ASM_REGPFX %% > #endif > > -#define _ASM_BYTES(x, ...) __ASM_FORM(.byte x,##__VA_ARGS__ ;) > +#define _ASM_BYTES(x, ...) __ASM_FORM(.byte\t x,##__VA_ARGS__) > > #ifndef __x86_64__ > /* 32 bit */ $ make O=defconfig-build/ CC=gcc-8 arch/x86/lib/retpoline.o make[1]: Entering directory '/mnt/nvme/linux-2.6/defconfig-build' GEN Makefile CALL ../scripts/checksyscalls.sh DESCEND objtool INSTALL libsubcmd_headers AS arch/x86/lib/retpoline.o ../arch/x86/include/asm/GEN-for-each-reg.h: Assembler messages: ../arch/x86/include/asm/GEN-for-each-reg.h:140: Error: bad expression ../arch/x86/include/asm/GEN-for-each-reg.h:6: Info: macro invoked from here ../arch/x86/include/asm/GEN-for-each-reg.h:140: Error: junk at end of line, first unrecognized character is `t' Which is why I ended up splitting the definition :/