From: Greg KH <gregkh@linuxfoundation.org>
To: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
Cc: lenb@kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, rafael@kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] PNP: add a error handling in pnpacpi_init()
Date: Thu, 18 Dec 2025 13:40:09 +0100 [thread overview]
Message-ID: <2025121811-password-reroute-6880@gregkh> (raw)
In-Reply-To: <20251218122422.573466-1-lihaoxiang@isrc.iscas.ac.cn>
On Thu, Dec 18, 2025 at 08:24:22PM +0800, Haoxiang Li wrote:
> On Thu, 18 Dec 2025 12:33:05 +0100, Greg KH Wrote:
> > What tool are you all using to "find" these issues? Why aren't you
> > properly documenting it?
>
> Sorry for the inconvenience. I found these through manual code review.
Manually? Really? Why are you manually reviewing pnp code? Do you
have this hardware? Why not focus on code for hardware you have and can
test the fix for?
> I will document how the issue was identified later.
It should be in the changelog text, as is required.
thanks,
greg k-h
next prev parent reply other threads:[~2025-12-18 12:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-18 8:29 [PATCH] PNP: add a error handling in pnpacpi_init() Haoxiang Li
2025-12-18 11:33 ` Greg KH
2025-12-18 12:24 ` Haoxiang Li
2025-12-18 12:40 ` Greg KH [this message]
2025-12-18 13:07 ` Haoxiang Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025121811-password-reroute-6880@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=lenb@kernel.org \
--cc=lihaoxiang@isrc.iscas.ac.cn \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.