Re: [PATCH v5 25/28] hw/core/machine: Remove hw_compat_2_7[] array

[Igor Mammedov <imammedo@redhat.com>]

On Wed,  3 Dec 2025 00:28:32 +0800
Zhao Liu <zhao1.liu@intel.com> wrote:

> From: Philippe Mathieu-Daudé <philmd@linaro.org>
> 
> The hw_compat_2_7[] array was only used by the pc-q35-2.7 and
> pc-i440fx-2.7 machines, which got removed. Remove it.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Reviewed-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
> Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>

Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  hw/core/machine.c   | 9 ---------
>  include/hw/boards.h | 3 ---
>  2 files changed, 12 deletions(-)
> 
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index 0b10adb5d538..f3e9346965c3 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -281,15 +281,6 @@ GlobalProperty hw_compat_2_8[] = {
>  };
>  const size_t hw_compat_2_8_len = G_N_ELEMENTS(hw_compat_2_8);
>  
> -GlobalProperty hw_compat_2_7[] = {
> -    { "virtio-pci", "page-per-vq", "on" },
> -    { "virtio-serial-device", "emergency-write", "off" },
> -    { "ioapic", "version", "0x11" },
> -    { "intel-iommu", "x-buggy-eim", "true" },
> -    { "virtio-pci", "x-ignore-backend-features", "on" },
> -};
> -const size_t hw_compat_2_7_len = G_N_ELEMENTS(hw_compat_2_7);
> -
>  MachineState *current_machine;
>  
>  static char *machine_get_kernel(Object *obj, Error **errp)
> diff --git a/include/hw/boards.h b/include/hw/boards.h
> index 5ddadbfd8a83..83b78b35f2bf 100644
> --- a/include/hw/boards.h
> +++ b/include/hw/boards.h
> @@ -879,7 +879,4 @@ extern const size_t hw_compat_2_9_len;
>  extern GlobalProperty hw_compat_2_8[];
>  extern const size_t hw_compat_2_8_len;
>  
> -extern GlobalProperty hw_compat_2_7[];
> -extern const size_t hw_compat_2_7_len;
> -
>  #endif