Re: [PATCH 00/12] NH library and Adiantum cleanup

[Eric Biggers <ebiggers@kernel.org>]

On Wed, Dec 10, 2025 at 05:18:32PM -0800, Eric Biggers wrote:
> This series can also be retrieved from:
> 
>     git fetch https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git nh-lib-v1
> 
> This series removes the nhpoly1305 crypto_shash algorithm, which existed
> only to fit Adiantum hashing into the traditional Linux crypto API
> paradigm.  It replaces it with an nh() library function, combined with
> code in the "adiantum" template that handles the Poly1305 step.
> 
> The result is simpler code.  As usual, I've also fixed the issue where
> the architecture-optimized code was disabled by default.
> 
> I've also included some additional cleanups for the Adiantum code.
> 
> I'm planning to take this via libcrypto-next.
> 
> Eric Biggers (12):
>   lib/crypto: nh: Add NH library
>   lib/crypto: tests: Add KUnit tests for NH
>   lib/crypto: arm/nh: Migrate optimized code into library
>   lib/crypto: arm64/nh: Migrate optimized code into library
>   lib/crypto: x86/nh: Migrate optimized code into library
>   crypto: adiantum - Convert to use NH library
>   crypto: adiantum - Use scatter_walk API instead of sg_miter
>   crypto: adiantum - Use memcpy_{to,from}_sglist()
>   crypto: adiantum - Drop support for asynchronous xchacha ciphers
>   crypto: nhpoly1305 - Remove crypto_shash support
>   crypto: testmgr - Remove nhpoly1305 tests
>   fscrypt: Drop obsolete recommendation to enable optimized NHPoly1305

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=libcrypto-next

More reviews and acks would be appreciated!

- Eric