All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: "Rusydi H. Makarim" <rusydi.makarim@kriptograf.id>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
	Ard Biesheuvel <ardb@kernel.org>,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitor@vger.kernel.org
Subject: Re: [PATCH] lib/crypto: use rol32 in md5.c
Date: Thu, 18 Dec 2025 11:33:12 -0800	[thread overview]
Message-ID: <20251218193312.GE21380@sol> (raw)
In-Reply-To: <20251214-rol32_in_md5-v1-1-20f5f11a92b2@kriptograf.id>

On Sun, Dec 14, 2025 at 06:15:12PM +0700, Rusydi H. Makarim wrote:
> use rol32 in MD5STEP
> 
> ---
> this patch replaces the bitwise left rotation in lib/crypto/md5.c
> with rol32
> 
> Signed-off-by: Rusydi H. Makarim <rusydi.makarim@kriptograf.id>
> ---
>  lib/crypto/md5.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=libcrypto-next

I cleaned up your commit message as follows:

commit 325c29e7d11caaf3b4f04f2c8f7d6bc4861cce5a
Author: Rusydi H. Makarim <rusydi.makarim@kriptograf.id>
Date:   Sun Dec 14 18:15:12 2025 +0700

    lib/crypto: md5: Use rol32() instead of open-coding it

    For the bitwise left rotation in MD5STEP, use rol32() from
    <linux/bitops.h> instead of open-coding it.

    Signed-off-by: Rusydi H. Makarim <rusydi.makarim@kriptograf.id>
    Link: https://lore.kernel.org/r/20251214-rol32_in_md5-v1-1-20f5f11a92b2@kriptograf.id
    Signed-off-by: Eric Biggers <ebiggers@kernel.org>

For future reference: please don't include a scissors line in the middle
of your commit message.  Everything below it gets cut off.

- Eric

      reply	other threads:[~2025-12-18 19:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-14 11:15 [PATCH] lib/crypto: use rol32 in md5.c Rusydi H. Makarim
2025-12-18 19:33 ` Eric Biggers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251218193312.GE21380@sol \
    --to=ebiggers@kernel.org \
    --cc=Jason@zx2c4.com \
    --cc=ardb@kernel.org \
    --cc=kernel-janitor@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusydi.makarim@kriptograf.id \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.