From: David Sterba <dsterba@suse.cz>
To: Mark Harmstone <mark@harmstone.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: show correct warning if can't read data reloc tree
Date: Sat, 20 Dec 2025 01:24:27 +0100 [thread overview]
Message-ID: <20251220002427.GD3195@twin.jikos.cz> (raw)
In-Reply-To: <20251219181550.12901-1-mark@harmstone.com>
On Fri, Dec 19, 2025 at 06:15:28PM +0000, Mark Harmstone wrote:
> If a filesystem is missing its data reloc tree, we get something like
> this in dmesg:
>
> BTRFS warning (device loop11): failed to read root (objectid=4): -2
> BTRFS error (device loop11): open_ctree failed: -2
>
> objectid is BTRFS_DEV_TREE_OBJECTID, but this should actually be the
> value of BTRFS_DATA_RELOC_TREE_OBJECTID.
>
> btrfs_read_roots() prints location.objectid on failure, but this isn't
> set when reading the data reloc tree. Set location.objectid to the
> correct value on failure, so that the error message makes sense.
>
> Signed-off-by: Mark Harmstone <mark@harmstone.com>
Added to for-next, thanks.
prev parent reply other threads:[~2025-12-20 0:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-19 18:15 [PATCH] btrfs: show correct warning if can't read data reloc tree Mark Harmstone
2025-12-20 0:00 ` Qu Wenruo
2025-12-20 0:24 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251220002427.GD3195@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=mark@harmstone.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.