All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: "Benoît Monin" <benoit.monin@bootlin.com>,
	"Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
	"Gregory CLEMENT" <gregory.clement@bootlin.com>,
	"Théo Lebrun" <theo.lebrun@bootlin.com>,
	"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Linus Walleij" <linusw@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Tawfik Bayouk" <tawfik.bayouk@mobileye.com>,
	linux-mips@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-gpio@vger.kernel.org,
	"Benoît Monin" <benoit.monin@bootlin.com>
Subject: Re: [PATCH 05/13] pinctrl: eyeq5: Use match data
Date: Sat, 20 Dec 2025 22:34:48 +0800	[thread overview]
Message-ID: <202512202142.StvDXvbg-lkp@intel.com> (raw)
In-Reply-To: <20251217-eyeq6lplus-v1-5-e9cdbd3af4c2@bootlin.com>

Hi Benoît,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 8f0b4cce4481fb22653697cced8d0d04027cb1e8]

url:    https://github.com/intel-lab-lkp/linux/commits/Beno-t-Monin/dt-bindings-mips-Add-Mobileye-EyeQ6Lplus-SoC/20251217-214926
base:   8f0b4cce4481fb22653697cced8d0d04027cb1e8
patch link:    https://lore.kernel.org/r/20251217-eyeq6lplus-v1-5-e9cdbd3af4c2%40bootlin.com
patch subject: [PATCH 05/13] pinctrl: eyeq5: Use match data
config: parisc-allyesconfig (https://download.01.org/0day-ci/archive/20251220/202512202142.StvDXvbg-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251220/202512202142.StvDXvbg-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512202142.StvDXvbg-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/pinctrl/pinctrl-eyeq5.c: In function 'eq5p_pinconf_set':
>> drivers/pinctrl/pinctrl-eyeq5.c:533:13: warning: 'offset' is used uninitialized [-Wuninitialized]
     533 |         u32 val = BIT(offset);
         |             ^~~
   drivers/pinctrl/pinctrl-eyeq5.c:532:22: note: 'offset' was declared here
     532 |         unsigned int offset;
         |                      ^~~~~~


vim +/offset +533 drivers/pinctrl/pinctrl-eyeq5.c

41795aa1f56a6e Théo Lebrun  2024-07-30  524  
41795aa1f56a6e Théo Lebrun  2024-07-30  525  static int eq5p_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
41795aa1f56a6e Théo Lebrun  2024-07-30  526  			    unsigned long *configs, unsigned int num_configs)
41795aa1f56a6e Théo Lebrun  2024-07-30  527  {
41795aa1f56a6e Théo Lebrun  2024-07-30  528  	struct eq5p_pinctrl *pctrl = pinctrl_dev_get_drvdata(pctldev);
41795aa1f56a6e Théo Lebrun  2024-07-30  529  	const char *pin_name = pctldev->desc->pins[pin].name;
41795aa1f56a6e Théo Lebrun  2024-07-30  530  	struct device *dev = pctldev->dev;
e3ba56038b97ee Benoît Monin 2025-12-17  531  	const struct eq5p_bank *bank;
e3ba56038b97ee Benoît Monin 2025-12-17  532  	unsigned int offset;
41795aa1f56a6e Théo Lebrun  2024-07-30 @533  	u32 val = BIT(offset);
41795aa1f56a6e Théo Lebrun  2024-07-30  534  	unsigned int i;
e3ba56038b97ee Benoît Monin 2025-12-17  535  	int ret;
e3ba56038b97ee Benoît Monin 2025-12-17  536  
e3ba56038b97ee Benoît Monin 2025-12-17  537  	ret = eq5p_pin_to_bank_offset(pctrl, pin, &bank, &offset);
e3ba56038b97ee Benoît Monin 2025-12-17  538  	if (ret)
e3ba56038b97ee Benoît Monin 2025-12-17  539  		return ret;
41795aa1f56a6e Théo Lebrun  2024-07-30  540  
41795aa1f56a6e Théo Lebrun  2024-07-30  541  	for (i = 0; i < num_configs; i++) {
41795aa1f56a6e Théo Lebrun  2024-07-30  542  		enum pin_config_param param = pinconf_to_config_param(configs[i]);
41795aa1f56a6e Théo Lebrun  2024-07-30  543  		u32 arg = pinconf_to_config_argument(configs[i]);
41795aa1f56a6e Théo Lebrun  2024-07-30  544  
41795aa1f56a6e Théo Lebrun  2024-07-30  545  		switch (param) {
41795aa1f56a6e Théo Lebrun  2024-07-30  546  		case PIN_CONFIG_BIAS_DISABLE:
41795aa1f56a6e Théo Lebrun  2024-07-30  547  			dev_dbg(dev, "pin=%s bias_disable\n", pin_name);
41795aa1f56a6e Théo Lebrun  2024-07-30  548  
41795aa1f56a6e Théo Lebrun  2024-07-30  549  			eq5p_update_bits(pctrl, bank, EQ5P_PD, val, 0);
41795aa1f56a6e Théo Lebrun  2024-07-30  550  			eq5p_update_bits(pctrl, bank, EQ5P_PU, val, 0);
41795aa1f56a6e Théo Lebrun  2024-07-30  551  			break;
41795aa1f56a6e Théo Lebrun  2024-07-30  552  
41795aa1f56a6e Théo Lebrun  2024-07-30  553  		case PIN_CONFIG_BIAS_PULL_DOWN:
41795aa1f56a6e Théo Lebrun  2024-07-30  554  			dev_dbg(dev, "pin=%s bias_pull_down arg=%u\n",
41795aa1f56a6e Théo Lebrun  2024-07-30  555  				pin_name, arg);
41795aa1f56a6e Théo Lebrun  2024-07-30  556  
41795aa1f56a6e Théo Lebrun  2024-07-30  557  			if (arg == 0) /* cannot connect to GND */
41795aa1f56a6e Théo Lebrun  2024-07-30  558  				return -ENOTSUPP;
41795aa1f56a6e Théo Lebrun  2024-07-30  559  
41795aa1f56a6e Théo Lebrun  2024-07-30  560  			eq5p_update_bits(pctrl, bank, EQ5P_PD, val, val);
41795aa1f56a6e Théo Lebrun  2024-07-30  561  			eq5p_update_bits(pctrl, bank, EQ5P_PU, val, 0);
41795aa1f56a6e Théo Lebrun  2024-07-30  562  			break;
41795aa1f56a6e Théo Lebrun  2024-07-30  563  
41795aa1f56a6e Théo Lebrun  2024-07-30  564  		case PIN_CONFIG_BIAS_PULL_UP:
41795aa1f56a6e Théo Lebrun  2024-07-30  565  			dev_dbg(dev, "pin=%s bias_pull_up arg=%u\n",
41795aa1f56a6e Théo Lebrun  2024-07-30  566  				pin_name, arg);
41795aa1f56a6e Théo Lebrun  2024-07-30  567  
41795aa1f56a6e Théo Lebrun  2024-07-30  568  			if (arg == 0) /* cannot connect to VDD */
41795aa1f56a6e Théo Lebrun  2024-07-30  569  				return -ENOTSUPP;
41795aa1f56a6e Théo Lebrun  2024-07-30  570  
41795aa1f56a6e Théo Lebrun  2024-07-30  571  			eq5p_update_bits(pctrl, bank, EQ5P_PD, val, 0);
41795aa1f56a6e Théo Lebrun  2024-07-30  572  			eq5p_update_bits(pctrl, bank, EQ5P_PU, val, val);
41795aa1f56a6e Théo Lebrun  2024-07-30  573  			break;
41795aa1f56a6e Théo Lebrun  2024-07-30  574  
41795aa1f56a6e Théo Lebrun  2024-07-30  575  		case PIN_CONFIG_DRIVE_STRENGTH:
41795aa1f56a6e Théo Lebrun  2024-07-30  576  			dev_dbg(dev, "pin=%s drive_strength arg=%u\n",
41795aa1f56a6e Théo Lebrun  2024-07-30  577  				pin_name, arg);
41795aa1f56a6e Théo Lebrun  2024-07-30  578  
41795aa1f56a6e Théo Lebrun  2024-07-30  579  			eq5p_pinconf_set_drive_strength(pctldev, pin, arg);
41795aa1f56a6e Théo Lebrun  2024-07-30  580  			break;
41795aa1f56a6e Théo Lebrun  2024-07-30  581  
41795aa1f56a6e Théo Lebrun  2024-07-30  582  		default:
41795aa1f56a6e Théo Lebrun  2024-07-30  583  			dev_err(dev, "Unsupported pinconf %u\n", param);
41795aa1f56a6e Théo Lebrun  2024-07-30  584  			return -ENOTSUPP;
41795aa1f56a6e Théo Lebrun  2024-07-30  585  		}
41795aa1f56a6e Théo Lebrun  2024-07-30  586  	}
41795aa1f56a6e Théo Lebrun  2024-07-30  587  
41795aa1f56a6e Théo Lebrun  2024-07-30  588  	return 0;
41795aa1f56a6e Théo Lebrun  2024-07-30  589  }
41795aa1f56a6e Théo Lebrun  2024-07-30  590  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  parent reply	other threads:[~2025-12-20 14:35 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-17 13:35 [PATCH 00/13] Introducing the Mobileye EyeQ6Lplus SoC Benoît Monin
2025-12-17 13:35 ` [PATCH 01/13] dt-bindings: mips: Add " Benoît Monin
2025-12-19 21:10   ` Rob Herring (Arm)
2025-12-17 13:35 ` [PATCH 02/13] dt-bindings: soc: mobileye: Add EyeQ6Lplus OLB Benoît Monin
2025-12-19 21:10   ` Rob Herring (Arm)
2025-12-17 13:35 ` [PATCH 03/13] MIPS: Add Mobileye eyeQ6Lplus support Benoît Monin
2025-12-17 13:35 ` [PATCH 04/13] reset: eyeq: Add Mobileye EyeQ6Lplus OLB Benoît Monin
2025-12-17 13:35 ` [PATCH 05/13] pinctrl: eyeq5: Use match data Benoît Monin
2025-12-20 13:46   ` kernel test robot
2025-12-20 14:34   ` kernel test robot [this message]
2025-12-17 13:35 ` [PATCH 06/13] pinctrl: eyeq5: Add Mobileye EyeQ6Lplus OLB Benoît Monin
2025-12-17 13:35 ` [PATCH 07/13] clk: eyeq: Skip post-divisor when computing PLL frequency Benoît Monin
2025-12-17 13:35 ` [PATCH 08/13] clk: eyeq: Adjust PLL accuracy computation Benoît Monin
2025-12-17 13:35 ` [PATCH 09/13] clk: eyeq: Add Mobileye EyeQ6Lplus OLB Benoît Monin
2025-12-17 13:36 ` [PATCH 10/13] MIPS: Add Mobileye EyeQ6Lplus SoC dtsi Benoît Monin
2025-12-17 13:36 ` [PATCH 11/13] MIPS: Add Mobileye EyeQ6Lplus evaluation board dts Benoît Monin
2025-12-18 15:30   ` Krzysztof Kozlowski
2025-12-19 15:57     ` Benoît Monin
2025-12-19 16:28       ` Krzysztof Kozlowski
2026-01-01 22:42       ` Linus Walleij
2026-01-02 15:27         ` Benoît Monin
2025-12-17 13:36 ` [PATCH 12/13] MIPS: config: add eyeq6lplus_defconfig Benoît Monin
2025-12-17 13:36 ` [PATCH 13/13] MAINTAINERS: Mobileye: Add EyeQ6Lplus files Benoît Monin
2025-12-19 12:03 ` [PATCH 00/13] Introducing the Mobileye EyeQ6Lplus SoC Linus Walleij
2025-12-19 16:22   ` Benoît Monin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202512202142.StvDXvbg-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=benoit.monin@bootlin.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=krzk@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=tawfik.bayouk@mobileye.com \
    --cc=theo.lebrun@bootlin.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tsbogend@alpha.franken.de \
    --cc=vladimir.kondratiev@mobileye.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.