Re: [PATCH 6.1.y] spi: cadence-qspi: fix pointer reference in runtime PM hooks

[Greg KH <gregkh@linuxfoundation.org>]

On Fri, May 16, 2025 at 02:25:28PM +0800, Zhaoyang Li wrote:
> From: Théo Lebrun <theo.lebrun@bootlin.com>
> 
> [ Upstream commit 32ce3bb57b6b402de2aec1012511e7ac4e7449dc ]
> 
> dev_get_drvdata() gets used to acquire the pointer to cqspi and the SPI
> controller. Neither embed the other; this lead to memory corruption.
> 
> On a given platform (Mobileye EyeQ5) the memory corruption is hidden
> inside cqspi->f_pdata. Also, this uninitialised memory is used as a
> mutex (ctlr->bus_lock_mutex) by spi_controller_suspend().
> 
> Fixes: 2087e85bb66e ("spi: cadence-quadspi: fix suspend-resume implementations")
> Reviewed-by: Dhruva Gole <d-gole@ti.com>
> Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
> Link: https://msgid.link/r/20240222-cdns-qspi-pm-fix-v4-1-6b6af8bcbf59@bootlin.com
> Signed-off-by: Mark Brown <broonie@kernel.org>
> Signed-off-by: Zhaoyang Li <lizy04@hust.edu.cn>
> ---
>  drivers/spi/spi-cadence-quadspi.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

Turns out you used a LLM tool to generate this backport.  Any specific
reason why you didn't identify that and tell us you did so?

thanks,

greg k-h