Re: [PATCH 4/4] staging: greybus: greybus_firmware: fix long macro lines

[Greg KH <gregkh@linuxfoundation.org>]

On Fri, Dec 19, 2025 at 02:34:15PM +0800, Zhan Xusheng wrote:
> Break long ioctl macro definitions into multiple lines to satisfy
> checkpatch.pl line-length checks (<100 columns).
> 
> Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>
> ---
>  drivers/staging/greybus/greybus_firmware.h | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/greybus/greybus_firmware.h b/drivers/staging/greybus/greybus_firmware.h
> index b6042a82ada4..f59a2def3d45 100644
> --- a/drivers/staging/greybus/greybus_firmware.h
> +++ b/drivers/staging/greybus/greybus_firmware.h
> @@ -64,11 +64,16 @@ struct fw_mgmt_ioc_backend_fw_update {
>  } __packed;
>  
>  #define FW_MGMT_IOCTL_BASE			'F'
> -#define FW_MGMT_IOC_GET_INTF_FW			_IOR(FW_MGMT_IOCTL_BASE, 0, struct fw_mgmt_ioc_get_intf_version)
> -#define FW_MGMT_IOC_GET_BACKEND_FW		_IOWR(FW_MGMT_IOCTL_BASE, 1, struct fw_mgmt_ioc_get_backend_version)
> -#define FW_MGMT_IOC_INTF_LOAD_AND_VALIDATE	_IOWR(FW_MGMT_IOCTL_BASE, 2, struct fw_mgmt_ioc_intf_load_and_validate)
> -#define FW_MGMT_IOC_INTF_BACKEND_FW_UPDATE	_IOWR(FW_MGMT_IOCTL_BASE, 3, struct fw_mgmt_ioc_backend_fw_update)
> -#define FW_MGMT_IOC_SET_TIMEOUT_MS		_IOW(FW_MGMT_IOCTL_BASE, 4, unsigned int)
> +#define FW_MGMT_IOC_GET_INTF_FW			\
> +	_IOR(FW_MGMT_IOCTL_BASE, 0, struct fw_mgmt_ioc_get_intf_version)
> +#define FW_MGMT_IOC_GET_BACKEND_FW		\
> +	_IOWR(FW_MGMT_IOCTL_BASE, 1, struct fw_mgmt_ioc_get_backend_version)
> +#define FW_MGMT_IOC_INTF_LOAD_AND_VALIDATE	\
> +	_IOWR(FW_MGMT_IOCTL_BASE, 2, struct fw_mgmt_ioc_intf_load_and_validate)
> +#define FW_MGMT_IOC_INTF_BACKEND_FW_UPDATE	\
> +	_IOWR(FW_MGMT_IOCTL_BASE, 3, struct fw_mgmt_ioc_backend_fw_update)
> +#define FW_MGMT_IOC_SET_TIMEOUT_MS		\
> +	_IOW(FW_MGMT_IOCTL_BASE, 4, unsigned int)

The originals are fine, ioctls are messy, it's good to see them all on
one line usually.

thanks,

greg k-h