Re: [PATCH] gpiolib: fix race condition for gdev->srcu

[kernel test robot <lkp@intel.com>]

Hi Paweł,

kernel test robot noticed the following build errors:

[auto build test ERROR on brgl/gpio/for-next]
[also build test ERROR on next-20251219]
[cannot apply to linus/master v6.16-rc1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Pawe-Narewski/gpiolib-fix-race-condition-for-gdev-srcu/20251223-165142
base:   https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/for-next
patch link:    https://lore.kernel.org/r/20251223084952.1847489-1-pawel.narewski%40nokia.com
patch subject: [PATCH] gpiolib: fix race condition for gdev->srcu
config: x86_64-rhel-9.4-ltp (https://download.01.org/0day-ci/archive/20251224/202512240750.LQnDrYIF-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251224/202512240750.LQnDrYIF-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512240750.LQnDrYIF-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from include/linux/mm_types.h:13,
                    from include/linux/mmzone.h:22,
                    from include/linux/gfp.h:7,
                    from include/linux/slab.h:16,
                    from include/linux/resource_ext.h:11,
                    from include/linux/acpi.h:14,
                    from drivers/gpio/gpiolib.c:3:
   drivers/gpio/gpiolib.c: In function 'gpiochip_add_data_with_key':
>> include/linux/notifier.h:86:35: error: 'struct raw_notifier_head' has no member named 'rwsem'
      86 |                 init_rwsem(&(name)->rwsem);     \
         |                                   ^~
   include/linux/rwsem.h:121:23: note: in definition of macro 'init_rwsem'
     121 |         __init_rwsem((sem), #sem, &__key);                      \
         |                       ^~~
   drivers/gpio/gpiolib.c:1109:9: note: in expansion of macro 'BLOCKING_INIT_NOTIFIER_HEAD'
    1109 |         BLOCKING_INIT_NOTIFIER_HEAD(&gdev->line_state_notifier);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +86 include/linux/notifier.h

eabc069401bcf4 Alan Stern 2006-10-04  80  
e041c683412d5b Alan Stern 2006-03-27  81  #define ATOMIC_INIT_NOTIFIER_HEAD(name) do {	\
e041c683412d5b Alan Stern 2006-03-27  82  		spin_lock_init(&(name)->lock);	\
e041c683412d5b Alan Stern 2006-03-27  83  		(name)->head = NULL;		\
e041c683412d5b Alan Stern 2006-03-27  84  	} while (0)
e041c683412d5b Alan Stern 2006-03-27  85  #define BLOCKING_INIT_NOTIFIER_HEAD(name) do {	\
e041c683412d5b Alan Stern 2006-03-27 @86  		init_rwsem(&(name)->rwsem);	\
e041c683412d5b Alan Stern 2006-03-27  87  		(name)->head = NULL;		\
e041c683412d5b Alan Stern 2006-03-27  88  	} while (0)
e041c683412d5b Alan Stern 2006-03-27  89  #define RAW_INIT_NOTIFIER_HEAD(name) do {	\
e041c683412d5b Alan Stern 2006-03-27  90  		(name)->head = NULL;		\
e041c683412d5b Alan Stern 2006-03-27  91  	} while (0)
e041c683412d5b Alan Stern 2006-03-27  92  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki