All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Michael Nosthoff via buildroot <buildroot@buildroot.org>
Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Subject: Re: [Buildroot] [PATCH 1/2] package/gerbera: bump to version 2.6.1
Date: Fri, 26 Dec 2025 17:46:31 +0100	[thread overview]
Message-ID: <20251226174631.16e970ee@windsurf> (raw)
In-Reply-To: <20251103115220.2911208-2-buildroot@heine.tech>

Hello Michael,

On Mon,  3 Nov 2025 12:52:07 +0100
Michael Nosthoff via buildroot <buildroot@buildroot.org> wrote:

> - new dependencies on icu and jsoncpp
> - fixes most deprecations of fmt >= 12
> 
> - add upstream patch which fixes another deprecation of fmt >=12

Thanks for this patch. However, I believe it breaks the build for the
following configuration:

BR2_aarch64=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y
BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_AARCH64_GLIBC_STABLE=y
BR2_INIT_NONE=y
BR2_SYSTEM_BIN_SH_NONE=y
# BR2_PACKAGE_BUSYBOX is not set
BR2_PACKAGE_LIBNPUPNP=y
BR2_PACKAGE_GERBERA=y
# BR2_TARGET_ROOTFS_TAR is not set

Note: this configuration uses BR2_PACKAGE_LIBNPUPNP instead of the
default BR2_PACKAGE_LIBUPNP selected by gerbera.

The build failure goes like this:

In file included from /home/thomas/projets/br/all-fixes/output/build/gerbera-2.6.1/src/upnp/cont_dir_service.cc:51:
/home/thomas/projets/br/all-fixes/output/build/gerbera-2.6.1/src/upnp/cont_dir_service.cc: In member function ‘virtual bool ContentDirectoryService::processSubscriptionRequest(const SubscriptionRequest&)’:
/home/thomas/projets/br/all-fixes/output/build/gerbera-2.6.1/src/upnp/cont_dir_service.cc:451:57: error: cannot convert ‘const std::string’ {aka ‘const std::__cxx11::basic_string<char>’} to ‘const char*’
  451 |                serviceID, xml, request.getSubscriptionID());
      |                                ~~~~~~~~~~~~~~~~~~~~~~~~~^~
      |                                                         |
      |                                                         const std::string {aka const std::__cxx11::basic_string<char>}
/home/thomas/projets/br/all-fixes/output/build/gerbera-2.6.1/src/upnp/compat.h:83:147: note: in definition of macro ‘GrbUpnpAcceptSubscription’
   83 | #define GrbUpnpAcceptSubscription(handle, udn, serviceId, xml, subsId) UpnpAcceptSubscriptionXML(handle, (udn).c_str(), (serviceId).c_str(), xml, subsId)
      |                                                                                                                                                   ^~~~~~
In file included from /home/thomas/projets/br/all-fixes/output/build/gerbera-2.6.1/src/upnp/upnp_service.h:34,
                 from /home/thomas/projets/br/all-fixes/output/build/gerbera-2.6.1/src/upnp/cont_dir_service.h:37,
                 from /home/thomas/projets/br/all-fixes/output/build/gerbera-2.6.1/src/upnp/cont_dir_service.cc:35:
/home/thomas/projets/br/all-fixes/output/host/aarch64-buildroot-linux-gnu/sysroot/usr/include/npupnp/upnp.h:1514:20: note:   initializing argument 5 of ‘int UpnpAcceptSubscriptionXML(UpnpDevice_Handle, const char*, const char*, const std::string&, const char*)’
 1514 |     const Upnp_SID SubsId);
      |     ~~~~~~~~~~~~~~~^~~~~~

I am not 100% sure that this regression is caused by this bump: I tried
to revert the bump, but then the build fails because fmt::localtime()
no longer exists (this issue was fixed in gerbera 2.6.1).

I believe gerbera needs a later version of libnpupnp, even though the
table in README.md states that 4.2.1 is the minimum version (and we
have 4.2.1 in Buildroot).

Could you have a look at this issue?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2025-12-26 16:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-03 11:52 [Buildroot] [PATCH 1/2] package/gerbera: bump to version 2.6.1 Michael Nosthoff via buildroot
2025-11-03 11:52 ` [Buildroot] [PATCH 2/2] package/fmt: bump to version 12.1.0 Michael Nosthoff via buildroot
2025-11-08 10:17 ` [Buildroot] [PATCH 1/2] package/gerbera: bump to version 2.6.1 Julien Olivain via buildroot
2025-12-26 16:46 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251226174631.16e970ee@windsurf \
    --to=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.