Re: [Buildroot] [PATCH 3/4] package/janet: new infrastructure

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello François,

On Sat, 20 Dec 2025 18:34:11 +0100
Francois Perrad via buildroot <buildroot@buildroot.org> wrote:

> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>

How many Janet packages do you expect to add? We normally add a package
infra once we have 3-5 packages at least. Adding one for just one
package seems excessive, but perhaps you have many more packages to add
in the future?


> diff --git a/docs/manual/adding-packages-janet.adoc b/docs/manual/adding-packages-janet.adoc
> new file mode 100644
> index 000000000..3b39da7ba
> --- /dev/null
> +++ b/docs/manual/adding-packages-janet.adoc
> @@ -0,0 +1,59 @@
> +// -*- mode:doc; -*-
> +// vim: set syntax=asciidoc:
> +
> +=== Infrastructure for Janet packages
> +

Please add some intro about Janet here, what it is, etc. Clearly not
obvious.

But honestly aside for that it looks all good to me. I see they have
--offline option, which seems to imply that they thought about offline
builds, which is great.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot