From: "Mickaël Salaün" <mic@digikod.net>
To: Tingmao Wang <m@maowtm.org>
Cc: "Günther Noack" <gnoack@google.com>,
"Günther Noack" <gnoack3000@gmail.com>,
"Samasth Norway Ananda" <samasth.norway.ananda@oracle.com>,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH 3/5] Documentation/landlock: Fix missing case for ABI 6 in downgrade example
Date: Sun, 28 Dec 2025 19:16:36 +0100 [thread overview]
Message-ID: <20251228.Ohvaelo1AePi@digikod.net> (raw)
In-Reply-To: <1175b37d065b49520cbc335a9a2d501513a6c6ef.1766885035.git.m@maowtm.org>
The subject for documentation should just start with "landlock: "
On Sun, Dec 28, 2025 at 01:27:33AM +0000, Tingmao Wang wrote:
> Note that this code is different from the one in sandboxer.c since
> sandboxer won't ever add LANDLOCK_RESTRICT_SELF_LOG_SAME_EXEC_OFF and
> LANDLOCK_RESTRICT_SELF_LOG_SUBDOMAINS_OFF.
A more complet patch was sent a few days ago:
https://lore.kernel.org/r/3e21551d-24c3-459f-8cee-4d85c97c0120@oracle.com
>
> Fixes: 12bfcda73ac2 ("landlock: Add LANDLOCK_RESTRICT_SELF_LOG_*_EXEC_* flags")
Unless required by other parts of the patch, there is no need to
backport documentation changes, so there should not be any Fixes tag.
> Signed-off-by: Tingmao Wang <m@maowtm.org>
> ---
> Documentation/userspace-api/landlock.rst | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/userspace-api/landlock.rst b/Documentation/userspace-api/landlock.rst
> index 1d0c2c15c22e..903d2ad11852 100644
> --- a/Documentation/userspace-api/landlock.rst
> +++ b/Documentation/userspace-api/landlock.rst
> @@ -127,6 +127,12 @@ version, and only use the available subset of access rights:
> /* Removes LANDLOCK_SCOPE_* for ABI < 6 */
> ruleset_attr.scoped &= ~(LANDLOCK_SCOPE_ABSTRACT_UNIX_SOCKET |
> LANDLOCK_SCOPE_SIGNAL);
> + __attribute__((fallthrough));
> + case 6:
> + /* Removes LANDLOCK_RESTRICT_SELF_LOG_* for ABI < 7 */
> + supported_restrict_flags &= ~(LANDLOCK_RESTRICT_SELF_LOG_NEW_EXEC_ON |
> + LANDLOCK_RESTRICT_SELF_LOG_SAME_EXEC_OFF |
> + LANDLOCK_RESTRICT_SELF_LOG_SUBDOMAINS_OFF);
As Günther pointed out, this switch/case might not be needed for this
part of the documentation.
> }
>
> This enables the creation of an inclusive ruleset that will contain our rules.
> --
> 2.52.0
>
>
next prev parent reply other threads:[~2025-12-28 18:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-28 1:27 [PATCH 0/5] Landlock: Test, comment and doc improvements Tingmao Wang
2025-12-28 1:27 ` [PATCH 1/5] selftests/landlock: Fix typo in fs_test Tingmao Wang
2025-12-28 1:27 ` [PATCH 2/5] selftests/landlock: Fix missing semicolon Tingmao Wang
2025-12-28 1:27 ` [PATCH 3/5] Documentation/landlock: Fix missing case for ABI 6 in downgrade example Tingmao Wang
2025-12-28 18:16 ` Mickaël Salaün [this message]
2025-12-28 1:27 ` [PATCH 4/5] selftests/landlock: Use scoped_base_variants.h for ptrace_test Tingmao Wang
2025-12-28 1:27 ` [RFC PATCH 5/5] landlock: Improve the comment for domain_is_scoped Tingmao Wang
2025-12-28 18:16 ` Mickaël Salaün
2025-12-28 18:16 ` [PATCH 0/5] Landlock: Test, comment and doc improvements Mickaël Salaün
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251228.Ohvaelo1AePi@digikod.net \
--to=mic@digikod.net \
--cc=gnoack3000@gmail.com \
--cc=gnoack@google.com \
--cc=linux-security-module@vger.kernel.org \
--cc=m@maowtm.org \
--cc=samasth.norway.ananda@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.